Repository navigation
Conversation
This was referenced Oct 8, 2026
Owner
Author
This was referenced Oct 8, 2026
thebhef
marked this pull request as ready for review
October 14, 2026 21:09
thebhef
force-pushed
the
fix-python-toolchain
branch
from
October 15, 2026 00:13
f0faf9c to
6d33236
Compare
thebhef
force-pushed
the
task160-wire-rule
branch
from
October 15, 2026 00:14
9328e50 to
30b67ba
Compare
This was referenced Oct 15, 2026
Owner
Author
Merge activity
|
Owner ruling 2026-10-07: "I thought we weren't appending transmit messages to the trace store anymore ... They should only come in from echo." The one exception the echo-row change kept — a `Tx ✗` row appended when an enqueue was refused, "because there the queue did say no" — is withdrawn. A refused send was still an intent written into the store every consumer reads (decode, plots, per-message counts, fps.tx, bus load, logger, Save Capture), so the store now takes no row from any transmit intent, accepted or refused. Removed: - `append_refused_tx_row`, `UndeliveredTx`, `MAX_UNDELIVERED_RUNS`, the `AppState::undelivered_tx` field and its clear-with-the-capture. - The paged trace record's `tx_delivery` field (host `ipc.rs` and the frontend `types.ts`), the trace's `Tx ✗` label, its row class, tooltip and CSS. - The tests that pinned the old row and the marks' run-length bound. What a refusal is now: the manual send's wire status to its caller (`not_connected` / `failed`); a periodic with no room as a missed period, and one whose route is down parks (ADR 0039); a batch a session has gone away under is dropped and the next tick parks it; the peer's own refusals stay the bus-health per-bus refusal count (ADR 0060). The rule is written down where reviewers read it: ADR 0061 (a row is the wire's account; an enqueue or send return is an intent and yields no row, count or sample; a `Tx` row is an echo; the PEAK caveat — its echo means "on the wire", not "acknowledged", so an error-passive transmitter's echoes are withheld and the controller's TEC is the wire's account of a failed transmission; backends without `receive_own_messages` show no `Tx` rows), a CONTEXT.md entry, and a paragraph in CLAUDE.md. ADR 0039 and ADR 0023 carry dated amendments for the withdrawn row; README's transmit section is corrected. Tests: a send no session carries, a send onto a gone adapter, a periodic batch the session refuses (new, through `fire_due`) and an accepted send each leave no row, no per-message count and no tx rate. Verified: cargo test -p cannet-gui (1437 passed), clippy -p cannet-gui --all-targets -D warnings, cargo fmt --check, rustdoc -D warnings for cannet-gui, pnpm test (3765 passed), pnpm build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thebhef
force-pushed
the
fix-python-toolchain
branch
from
October 26, 2026 22:42
6d33236 to
9670a33
Compare
thebhef
force-pushed
the
task160-wire-rule
branch
from
October 26, 2026 22:42
30b67ba to
5877b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Owner ruling 2026-10-07: "I thought we weren't appending transmit
messages to the trace store anymore ... They should only come in from
echo." The one exception the echo-row change kept — a
Tx ✗rowappended when an enqueue was refused, "because there the queue did say
no" — is withdrawn. A refused send was still an intent written into
the store every consumer reads (decode, plots, per-message counts,
fps.tx, bus load, logger, Save Capture), so the store now takes no row
from any transmit intent, accepted or refused.
Removed:
append_refused_tx_row,UndeliveredTx,MAX_UNDELIVERED_RUNS, theAppState::undelivered_txfield and its clear-with-the-capture.tx_deliveryfield (hostipc.rsand thefrontend
types.ts), the trace'sTx ✗label, its row class,tooltip and CSS.
What a refusal is now: the manual send's wire status to its caller
(
not_connected/failed); a periodic with no room as a missedperiod, and one whose route is down parks (ADR 0039); a batch a session
has gone away under is dropped and the next tick parks it; the peer's
own refusals stay the bus-health per-bus refusal count (ADR 0060).
The rule is written down where reviewers read it: ADR 0061 (a row is
the wire's account; an enqueue or send return is an intent and yields
no row, count or sample; a
Txrow is an echo; the PEAK caveat — itsecho means "on the wire", not "acknowledged", so an error-passive
transmitter's echoes are withheld and the controller's TEC is the
wire's account of a failed transmission; backends without
receive_own_messagesshow noTxrows), a CONTEXT.md entry, and aparagraph in CLAUDE.md. ADR 0039 and ADR 0023 carry dated amendments
for the withdrawn row; README's transmit section is corrected.
Tests: a send no session carries, a send onto a gone adapter, a
periodic batch the session refuses (new, through
fire_due) and anaccepted send each leave no row, no per-message count and no tx rate.
Verified: cargo test -p cannet-gui (1437 passed), clippy -p cannet-gui
--all-targets -D warnings, cargo fmt --check, rustdoc -D warnings for
cannet-gui, pnpm test (3765 passed), pnpm build.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com