Repository navigation
Conversation
This was referenced Oct 15, 2026
This was referenced Oct 15, 2026
Open
NameText renders a long name as an inline-flex box, an atomic inline. Placed after a bus dot, a CAN id or ahead of a badge in a block line that clips with text-overflow, the box no longer fits and the engine hides it whole: the label disappeared at once instead of ellipsizing its head and keeping its tail. The plot legend's "bus . ecu . message" line is the reported case; five table cells share the shape. One shared .name-row class is a flex row whose children keep their width, with .name-row-text the only box that shrinks and ellipsizes. It now backs the plot legend's message line and the message cells of the Signals panel (math row's bus dots, file-backed badge), the View Signals panel (CAN id; the unknown-unit flag, wrapped only on flagged rows so an unflagged cell stays a bare name) and the RBS Signals panel (CAN id). The id's literal space became .name-row-lead's margin. nameOverflow asserts the stylesheet contract (jsdom does no layout) and lists each surface; ViewSignalsPanel's tests select the flagged row's name through the new box. ADR 0026 states the rule. The plot axis label holds NameText as its only child and is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
thebhef
force-pushed
the
task166-label-ellipsis
branch
from
October 26, 2026 22:42
de60775 to
8af8775
Compare
thebhef
force-pushed
the
task166-axis-collapse
branch
from
October 26, 2026 22:42
33b8a80 to
813e924
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameText renders a long name as an inline-flex box, an atomic inline.
Placed after a bus dot, a CAN id or ahead of a badge in a block line
that clips with text-overflow, the box no longer fits and the engine
hides it whole: the label disappeared at once instead of ellipsizing
its head and keeping its tail. The plot legend's "bus . ecu . message"
line is the reported case; five table cells share the shape.
One shared .name-row class is a flex row whose children keep their
width, with .name-row-text the only box that shrinks and ellipsizes.
It now backs the plot legend's message line and the message cells of
the Signals panel (math row's bus dots, file-backed badge), the View
Signals panel (CAN id; the unknown-unit flag, wrapped only on flagged
rows so an unflagged cell stays a bare name) and the RBS Signals panel
(CAN id). The id's literal space became .name-row-lead's margin.
nameOverflow asserts the stylesheet contract (jsdom does no layout)
and lists each surface; ViewSignalsPanel's tests select the flagged
row's name through the new box. ADR 0026 states the rule. The plot
axis label holds NameText as its only child and is unchanged.
Co-Authored-By: Claude Sonnet 5.5 noreply@anthropic.com