Repository navigation
Close the palette before running the picked command - #503
Merged
Merged
Conversation
This was referenced Sep 21, 2026
This was referenced Oct 6, 2026
Open
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation: opening a project from the command palette (owner report,
Windows, 2026-09-21; plans/ungroomed-user-feedback.md item 11) leaves
the mouse pointer invisible — hidden by WebView2 while the palette
input is typed in, and still hidden once the native Open dialog is up.
No app code hides the cursor (git grep for
cursor: none/ host cursorcalls finds nothing).
Hypothesis: the hidden-pointer state carries into the native dialog
because the dialog opens before the palette has actually left the DOM.
PaletteModal's Enter/click pick handler called
onPickdirectly, andthe command palette's
onPickraiseshandleOpenProject's nativeOpen dialog synchronously in the same handler that also closes the
palette (
setOpenPalette(null)) — so the dialog request goes outbefore React (and the webview) has processed the palette's removal
and returned focus.
Fix: PaletteModal now closes first (
onClose) and defers the pickitself by one tick (
setTimeout(…, 0)), for both the Enter path andmouse-click picks, so any native dialog a command raises opens only
after the modal is gone. This is the ordering fix described in the
report; it is unverified on the owner's machine until they try it.
Tests: PaletteModal.dom.test.tsx now runs under fake timers and adds a
case asserting
onClosefires before the deferred pick, and that thepick still runs exactly once.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com