Skip to content

Copy plot areas with the platform's modifier, same panel included - #563

Draft
thebhef wants to merge 1 commit into
task166-label-ellipsisfrom
task166-copy-drag
Draft

thebhef wants to merge 1 commit into
task166-label-ellipsisfrom
task166-copy-drag

Conversation

@thebhef

@thebhef thebhef commented Oct 15, 2026

Copy link
Copy Markdown
Owner

A plot-area drag copied only on Ctrl at the drop, never showed a copy
cursor, and a same-panel drop was always a reorder. The copy modifier is
now Alt on macOS and Ctrl elsewhere, decided in one helper
(plotAreaTransfer.isCopyDrag, reusing keybindings.isMacPlatform).

dragover sets dropEffect to copy while the modifier is held and move
otherwise, read on every event so a mid-drag toggle updates the pointer.
At the drop the modifier inserts a copy under a fresh id (ranges
re-keyed) at the drop position, in the same panel or another; without it
same-panel stays the reorder and cross-panel stays the move, claim
registry untouched. Grip and collapsed-handle tooltips name the
platform's modifier.

ADR 0045's drop table and prose are rewritten to the new rule, per the
owner's ruling that a same-panel modifier drop copies too.

This was referenced Oct 15, 2026

thebhef commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

A plot-area drag copied only on Ctrl at the drop, never showed a copy
cursor, and a same-panel drop was always a reorder. The copy modifier is
now Alt on macOS and Ctrl elsewhere, decided in one helper
(plotAreaTransfer.isCopyDrag, reusing keybindings.isMacPlatform).

dragover sets dropEffect to copy while the modifier is held and move
otherwise, read on every event so a mid-drag toggle updates the pointer.
At the drop the modifier inserts a copy under a fresh id (ranges
re-keyed) at the drop position, in the same panel or another; without it
same-panel stays the reorder and cross-panel stays the move, claim
registry untouched. Grip and collapsed-handle tooltips name the
platform's modifier.

ADR 0045's drop table and prose are rewritten to the new rule, per the
owner's ruling that a same-panel modifier drop copies too.
@thebhef
thebhef force-pushed the task166-label-ellipsis branch from de60775 to 8af8775 Compare October 26, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant