Skip to content

chore(deps): update dependency eslint to v10 - #1024

Closed
mergeraptor[bot] wants to merge 1 commit into
mainfrom
renovate/major-eslint-monorepo
Closed

mergeraptor[bot] wants to merge 1 commit into
mainfrom
renovate/major-eslint-monorepo

Conversation

@mergeraptor

@mergeraptor mergeraptor Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
eslint (source) 9.39.5 → 10.15.0 age confidence

Release Notes

eslint/eslint (eslint)

v10.15.0

Compare Source

Features

  • ec52157 feat: check proto and assignment targets in func-names (#​21521) (Lê Văn Xuân Hoàn)
  • 34a8b1b feat: recognize string and computed keys in accessor-pairs descriptors (#​21519) (Lê Văn Xuân Hoàn)
  • 663c825 feat: handle TS type assertions in no-invalid-this (#​21464) (Valentin)
  • 4941015 feat: check individual specifier importKind in no-shadow (#​21518) (Lê Văn Xuân Hoàn)
  • 17f17cd feat: update error location to head for default-case (#​21469) (Tanuj Kanti)

Bug Fixes

Documentation

  • 16eb1d9 docs: remove Contributor Pool reference (#​21539) (Nicholas C. Zakas)
  • e368730 docs: discourage non-serializable values in rule options (#​21487) (Vitalii Maslianok)
  • 0146008 docs: revamp code path analysis docs (#​21423) (xbinaryx)
  • aeb2267 docs: revise AI acknowledgment options in templates (#​21489) (lumir)
  • e47a477 docs: Update README (GitHub Actions Bot)
  • 11c66ba docs: fix typo in custom rules documentation (#​21472) (Pixel)

Chores

v10.14.0

Compare Source

Features

  • d23a7f9 feat: fix property descriptor handling in func-name-matching (#​21400) (xbinaryx)

Bug Fixes

Documentation

  • 0f94f47 docs: remove zh-hans from docs language switcher (#​21437) (lumir)
  • dab466e docs: Update README (GitHub Actions Bot)
  • 97431f8 docs: replace --rulesdir with a virtual plugin in custom rules docs (#​21452) (Pixel)
  • 7697550 docs: Update README (GitHub Actions Bot)
  • 0c699d5 docs: Remove Tidelift commercial support (#​21416) (Milos Djermanovic)
  • 0880666 docs: update loadESLint() documentation for v10 (#​21374) (Minseon Kim)
  • e06fe87 docs: Revise AI acknowledgment options in PR template (#​21414) (Nicholas C. Zakas)

Chores

  • 0e2ab70 ci: disable eslint-plugin-unicorn ecosystem test (#​21462) (Francesco Trotta)
  • 6e3f988 chore: update github/codeql-action action to v4.39.1 (#​21450) (renovate[bot])
  • a031c40 chore: update ecosystem plugins (#​21445) (ESLint Bot)
  • 67d2ca2 chore: add troubleshooting page URL to circular fixes warning message (#​21429) (Milos Djermanovic)
  • 276021d chore: update github/codeql-action action to v4.39.0 (#​21432) (renovate[bot])
  • 449724e chore: update ecosystem plugins (#​21420) (ESLint Bot)
  • 8ffeb8c chore: update dependency prettier to v3.9.10 (#​21417) (renovate[bot])

v10.13.0

Compare Source

Features

  • 48d5cc4 feat: report references inside IIFEs in no-use-before-define (#​21238) (Irfan fandi)
  • a39d9fb feat: add globalThis to no-obj-calls (#​21382) (synthex-byte)
  • 66ac583 feat: check yield* expressions in no-unsafe-optional-chaining (#​21399) (xbinaryx)

Bug Fixes

  • 87bd2ce fix: avoid redeclared let when no-var and one-var fix together (#​21389) (Daniel Pinto)

Documentation

  • 4783a68 docs: Update README (GitHub Actions Bot)
  • 43f0ac9 docs: clarify parameter description in getText (#​21287) (lumir)

Chores

v10.12.0

Compare Source

Features

  • 4618052 feat: handle astral letters in new-cap (#​21357) (sary)
  • 4ec5168 feat: allow SourceCode#getText() to accept tokens and comments (#​21340) (electrohyun)

Bug Fixes

  • bc51eee fix: prefer-arrow-callback false positive in conditional test (#​21373) (Daniel Pinto)
  • bbff86c fix: skip lines with multiple comments in max-lines-per-function (#​21332) (xbinaryx)
  • efc4d6b fix: astral letters in consistent-return, no-eval, no-invalid-this (#​21360) (lumir)
  • 93de066 fix: prefer-exponentiation-operator autofix for async function base (#​21322) (Vladimir Babin)
  • 02e34ff fix: add missing space after else in curly autofix (#​21355) (Pixel)
  • b14b8bc fix: correct id-length message for long private names (#​21348) (Pixel)
  • 69aac01 fix: support TSFunctionType in getFunctionHeadLoc (#​21335) (xbinaryx)
  • 686630e fix: no-loss-of-precision false positive with 0.e5 (#​21337) (sethamus)

Documentation

  • 67eb586 docs: Update README (GitHub Actions Bot)
  • 5370d7e docs: clarify one-var separateRequires matches any require() call (#​21192) (sethamus)
  • 8816c1d docs: Update README (GitHub Actions Bot)
  • 3d2e7ce docs: fix typo in no-unused-expressions documentation (#​21346) (bytedoe)

Chores

  • 152067f chore: update ecosystem plugins (#​21362) (ESLint Bot)
  • b56d58e chore: update github/codeql-action action to v4.38.2 (#​21376) (renovate[bot])
  • bfaea12 perf: cache normalized config globals per languageOptions (#​21364) (James Ross)
  • 322209e ci: avoid Nx cache in ecosystem tests and disable failing test (#​21369) (Francesco Trotta)
  • d166567 chore: update dependency prettier to v3.9.9 (#​21371) (renovate[bot])
  • 29585ce chore: update dependency eslint-plugin-expect-type to ^0.7.0 (#​21359) (renovate[bot])
  • 39d79ba chore: update github/codeql-action action to v4.38.1 (#​21354) (renovate[bot])
  • 182a6e9 chore: update dependency prettier to v3.9.8 (#​21352) (renovate[bot])
  • f995127 chore: remove CLAUDE.md in favor of AGENTS.md (#​21339) (Jarren)
  • b95fb6c chore: update dependency prettier to v3.9.7 (#​21347) (renovate[bot])
  • 3782dd4 chore: update ecosystem plugins (#​21342) (ESLint Bot)

v10.11.0

Compare Source

Features

  • d136fa4 feat: object-shorthand handle quoted properties for ignoreConstructors (#​21271) (Pavel)
  • 397b3b8 feat: report unsafe labeled continue in no-unsafe-finally rule (#​21316) (electrohyun)
  • d3dd47f feat: only exempt new-cap built-ins that reference the global (#​21290) (sethamus)

Bug Fixes

  • 22b09f5 fix: ignore __proto__ properties in prefer-object-spread (#​21311) (xbinaryx)
  • b684bb1 fix: make TimePass.parse optional in types and docs (#​21313) (ntnyq)
  • 26d11bc fix: don't report __proto__ properties in object-shorthand (#​21310) (xbinaryx)

Documentation

  • 9ecfdc5 docs: note that --cache can serve stale results for cross-file rules (#​21312) (bytedoe)
  • 6c789ff docs: Update README (GitHub Actions Bot)
  • 5997825 docs: clarify preserve-caught-error known limitation (#​21294) (Akinyemi Toluwalase)

Chores

  • 520dd77 perf: Implement fast paths in critical areas (#​21210) (Nicholas C. Zakas)
  • 92086c8 test: update EMFILE error generation for Node.js 26.9.0 compatibility (#​21330) (Francesco Trotta)
  • 9ac7eb6 chore: update github/codeql-action action to v4.38.0 (#​21331) (renovate[bot])
  • 24310e3 chore: update ecosystem plugins (#​21324) (ESLint Bot)
  • 45ad79e ci: bump pnpm/action-setup from 6.0.10 to 6.1.0 (#​21318) (dependabot[bot])
  • ac74e37 chore: Add AGENTS.md with AI disclosure requirements (#​21221) (Nicholas C. Zakas)
  • c832660 chore: Upgrade Stylelint to the latest version in docs (#​21245) (Jung Hyeon Jun)
  • f9f88fc chore: update ecosystem plugins (#​21308) (ESLint Bot)
  • fc81076 ci: add more types integration tests (#​20395) (Nitin Kumar)

v10.10.0

Compare Source

Features

  • 264b434 feat: add d and v flags to no-unexpected-multiline (#​21305) (Gihyeon Jeong / 정기현)
  • c6cc6c5 feat: check Object.prototype property names in new-cap (#​21269) (crimsonjay0)
  • 5661fa6 feat: no-extra-bind false negatives with class fields and static blocks (#​21260) (synthex-byte)

Bug Fixes

  • bb47dc6 fix: update dependency file-entry-cache to v11 (#​20801) (Milos Djermanovic)
  • 427ac0a fix: use format strings in debug calls (#​21247) (Francesco Trotta)
  • 9d81532 fix: support __proto__ in /* exported */ comments (#​21261) (sethamus)
  • 87e0a08 fix: prefer-object-has-own autofix breaks when Object is shadowed (#​21282) (김채영)
  • 8e2cb14 fix: new-cap false positive for UTC calls with properties: false (#​21275) (Pixel)
  • 9f4a364 fix: Ignore static imports in no-unreachable (#​21276) (Taha Kotil)

Documentation

  • 2417cad docs: Update README (GitHub Actions Bot)
  • 9cecb8a docs: document \c control letter escapes in no-control-regex (#​21286) (한국)
  • 8724829 docs: update compat table links (#​21263) (fnx)
  • 5634542 docs: Clarify eqeqeq suggestion behavior (#​21256) (Müslüm Yılmaz)

Chores

v10.9.1

Compare Source

Bug Fixes

  • 1e641c9 fix: no-loss-of-precision false positive with trailing decimal point (#​21251) (Aleksandr Shoronov)

Documentation

  • ad74a8d docs: add deprecation steps for EOL package versions (#​21248) (Francesco Trotta)

Chores

v10.9.0

Compare Source

Features

  • 08de88e feat: handle underflow in no-loss-of-precision (#​21218) (Rithish S)
  • 55db479 feat: add checkConditionalExpressions to no-unmodified-loop-condition (#​21175) (sethamus)

Bug Fixes

  • 2ba3025 fix: prevent unsafe no-var autofix with hoisted functions (#​21213) (sethamus)
  • 8e69622 fix: Prevent no-var autofix when var is shadowed by catch parameter (#​21204) (Yang Hyeonjong)
  • 684b579 fix: prefer-template invalid autofix creates a tagged template call (#​21207) (김채영)

Documentation

  • 9ef407a docs: use eslint.config.* wherever config file names are listed (#​21216) (Marry (Subin Yang))
  • 87f66f4 docs: Update README (GitHub Actions Bot)
  • 585ef37 docs: update architecture documentation (#​21112) (Francesco Trotta)
  • f3993b0 docs: Update README (GitHub Actions Bot)
  • ffc87d6 docs: fix broken links in Further Reading sections (#​21203) (Minsu)
  • 1a761e1 docs: update moved JSX specification links (#​21198) (Imran Mustafa)
  • 4d00ca4 docs: update ESLint peer dependency to ^10.0.0 in shareable configs (#​21202) (lumir)
  • 510d1a2 docs: Update README (GitHub Actions Bot)

Chores

v10.8.1

Compare Source

Bug Fixes

  • 18eb0a7 fix: prevent ASI hazard in no-unused-labels autofix (#​21173) (dongkyu lee)
  • 151ba3f fix: false positives in getter-return and accessor-pairs (#​21163) (Grit)
  • 6898df9 fix: ignore meta-property names in id-denylist (#​21166) (Pixel)
  • 4d7db66 fix: ignore meta-property names in id-match (#​21167) (Pixel)
  • 677214e fix: handle ASI hazards in no-unused-vars removeVar suggestion (#​20935) (kuldeep kumar)

Documentation

  • 7d0cbf8 docs: Update README (GitHub Actions Bot)
  • 0a05812 docs: add missing backticks to no-duplicate-imports.js (#​21183) (Lee Daeun)
  • 678c90b docs: Update README (GitHub Actions Bot)
  • 8a10424 docs: Update README (GitHub Actions Bot)
  • 69bb948 docs: Update README (GitHub Actions Bot)

Chores

v10.8.0

Compare Source

Features

Bug Fixes

  • 6b8d2f7 fix: escape reserved characters in rule id in html formatter (#​21129) (Francesco Trotta)
  • 9091071 fix: prevent no-unreachable-loop crash when all loop types are ignored (#​21116) (Pixel)
  • e23fafe fix: prefer-object-spread add semicolon when adding parenthesis (#​21081) (synthex-byte)
  • 20b5ad0 fix: quadratic-time regex in prefer-template (#​21096) (Milos Djermanovic)
  • 8b6f6c0 fix: apply ignore configs to computed methods in class-methods-use-this (#​21094) (Pixel)
  • b2c608c fix: NewExpression with parenthesized callee in preserve-caught-error (#​21083) (Francesco Trotta)

Documentation

  • 6ddf858 docs: fix broken Specify Parser Options anchor link (#​21106) (Minsu)
  • 784dfbe docs: Clarify no-eq-null description (#​21120) (Park Harin)
  • 7ec733a docs: Fix typos and grammar in glossary (#​21095) (Marry (Subin Yang))
  • 92bb13f docs: replace quake link (#​21108) (Jung Hyeon Jun)
  • 68eb4a5 docs: fix broken Specify Globals anchor links in rule pages (#​21103) (Minsu)
  • d28f697 docs: replace Code Climate CLI links with Qlty CLI links (#​21099) (Jung Hyeon Jun)
  • eccc68d docs: correct --suppressions-location option description (#​21093) (Ga eun Lee)
  • c5963f7 docs: Update README (GitHub Actions Bot)

Chores

[!IMPORTANT]
✂ PR body was truncated to here.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@mergeraptor

mergeraptor Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm warn Unknown env config "store". This will stop working in the next major version of npm. See `npm help npmrc` for supported config options.
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @antfu/eslint-config@6.7.3
npm error Found: eslint@10.15.0
npm error node_modules/eslint
npm error   dev eslint@"10.15.0" from the root project
npm error   peer eslint@"^8.57.0 || ^9.0.0 || ^10.0.0" from @typescript-eslint/utils@8.72.0
npm error   node_modules/@antfu/eslint-config/node_modules/@typescript-eslint/utils
npm error     @typescript-eslint/utils@"^8.71.2" from @vitest/eslint-plugin@1.6.28
npm error     node_modules/@antfu/eslint-config/node_modules/@vitest/eslint-plugin
npm error       @vitest/eslint-plugin@"^1.5.4" from @antfu/eslint-config@6.7.3
npm error       node_modules/@antfu/eslint-config
npm error         dev @antfu/eslint-config@"6.7.3" from the root project
npm error   32 more (@vitest/eslint-plugin, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^9.10.0" from @antfu/eslint-config@6.7.3
npm error node_modules/@antfu/eslint-config
npm error   dev @antfu/eslint-config@"6.7.3" from the root project
npm error
npm error Conflicting peer dependency: eslint@9.39.5
npm error node_modules/eslint
npm error   peer eslint@"^9.10.0" from @antfu/eslint-config@6.7.3
npm error   node_modules/@antfu/eslint-config
npm error     dev @antfu/eslint-config@"6.7.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry this command with --force or --legacy-peer-deps to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2026-11-20T03_03_25_505Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2026-11-20T03_03_25_505Z-debug-0.log

@hivecommons-hive hivecommons-hive Bot added no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 16, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

🐝 Superseded regeneration series

mergeraptor[bot] has 2 open PRs regenerating the same file(s). This one is the newest, so the 1 older one(s) are superseded by construction:

Posted once on the newest PR rather than on each of them, so a daily regeneration does not produce a daily comment on every PR in the series.

Evidence — identical changed-file set (1 file(s)):

  • package.json

This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides.

It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting.

@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor
ee5db85

ℹ️ Sentinel notice — informational; author is trusted (allow-listed bot), merge is not blocked

Hive flagged this PR (author @mergeraptor[bot], head ee5db85d3099) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • package.json

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot added the stage/stalled No activity (head, comment, review, CI, label) longer than the stage expects; nobody is working it label Nov 16, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/major-eslint-monorepo branch from 532ffea to 4c7744b Compare November 17, 2026 00:23

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on #1023. Renovate could not regenerate package-lock.json (renovate/artifacts: "Artifact file update failure"), so only package.json changed. npm ci then fails (job 133718254022):

npm error Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0

The root cause is the pinned @antfu/eslint-config@6.7.3 on main. Its peer range is eslint@^9.10.0, so eslint 10 cannot resolve beside it. #1023 bumps that config to 10.0.0, whose peer range is ^9.10.0 || ^10.0.0.

Next step: land #1023 after its lint fix. Then trigger a Renovate rebase here so the lock file regenerates. No manual change to this PR should be needed.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer (folded here because this head already carries its hive review):

This appears to duplicate part of #1038, which makes the same change to package.json.

Verified by comparing diffs: this PR moves eslint from 9.39.5 to 10.15.0. #1038 makes that identical edit, and also moves ```antfu/eslint-config 6.7.3 to 10.0.0` in the same step. Neither half passes CI alone: `test` is red on this head. #1038 explains why: `antfu/eslint-config` 6.x accepts only eslint 9, and 10.x needs eslint 10. #1038 also applies the reformat that the new rules require, and its `test` check is green.

#1038 is the better survivor: it is the only one of the three that can pass, and its body already says it supersedes #1023 and #1024. Note that #1038 is currently in merge conflict with main, so it needs a rebase before it can land.

Flagging for a maintainer: if you agree, this one could be closed in favour of #1038. I have not closed anything.

@Danathar

Copy link
Copy Markdown
Contributor

Not approving. Renovate couldn't build the lockfile, because the @antfu/eslint-config 6.7.3 on main only accepts eslint 9. So npm ci fails ("lock file's eslint@9.39.5 does not satisfy eslint@10.15.0", https://github.com/projectbluefin/website/actions/runs/43987184052/job/133718254022).

This needs the config bump in #1023, and the two are best landed together. See my note there.

@Danathar

Copy link
Copy Markdown
Contributor

The fix on main is tracked in #1033.

@mergeraptor
mergeraptor Bot force-pushed the renovate/major-eslint-monorepo branch from 4c7744b to 8e375b9 Compare November 17, 2026 15:10

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This automated update moves the website's code-checking tool (ESLint, which flags style and error patterns in the source) to a new major version. The branch was refreshed onto the latest main, but it still changes only the version number. It does not update the file that pins exact installed versions, and the shared lint ruleset this site uses does not support the new version yet. So the project's automated checks fail before any test runs.

What I need from you: Hold this update until the shared lint ruleset supports ESLint 10, or regenerate the lock file and bump that ruleset in the same change.


Delta re-review: head 8e375b9e vs. previous head 4c7744b5. Everything in the delta comes from the rebase onto main (#1002, #1021, #1022, #1026, #1027, #1028). The PR's own diff is still only package.json:60 (eslint 9.39.5 → 10.15.0).

Earlier findings:

  • Lock file not regenerated, so npm ci fails: still present (see the inline thread).
  • @antfu/eslint-config 6.7.3 peer range excludes ESLint 10: still present (see the inline thread).

CI on this head (test job 134137314961, head_sha 8e375b9e) fails at npm ci:

npm error Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0
npm warn peer eslint@"^9.10.0" from @antfu/eslint-config@6.7.3

No findings from: security, intent-alignment, style, docs-currency.

Findings not on a changed line

  • package.json:51: correctness (still present): @antfu/eslint-config 6.7.3 declares peerDependencies.eslint: ^9.10.0 (from package-lock.json at this head). ESLint 10 is outside that range. The CI log shows Could not resolve dependency: peer eslint@"^9.10.0" from @antfu/eslint-config@6.7.3. Fix: bump @antfu/eslint-config to a release whose peer range includes ^10, in the same change. If no such release exists, hold this PR, for example with a Renovate allowedVersions: "<10" rule for eslint.

Confidence: 1/5 (needs attention) — 2 high findings

— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

Comment thread package.json
"@vue/test-utils": "2.5.1",
"@xmldom/xmldom": "0.9.12",
"eslint": "9.39.5",
"eslint": "10.15.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness (still present): The lock file was not regenerated. At this head package-lock.json still pins node_modules/eslint to 9.39.5, and its root devDependencies.eslint is 9.39.5. npm ci aborts with EUSAGE: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0 (CI test job 134137314961 on 8e375b9e). Every job that runs npm ci fails. Fix: run npm install and commit the regenerated package-lock.json together with the bump. That only works once the peer conflict on line 51 is resolved.

@Danathar

Copy link
Copy Markdown
Contributor

Correction: this PR isn't superseded. It updates eslint to v10, which no other open PR updates. It only shares package.json / package-lock.json with the other Renovate PRs. Ignore the hive's "Superseded regeneration series" note above: it treated every bot PR that touches the same files as one series. That's fixed in hivecommons/hive#18837.

@mergeraptor
mergeraptor Bot force-pushed the renovate/major-eslint-monorepo branch from 8e375b9 to 1dfdbee Compare November 18, 2026 00:22

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This automated update moves the website's code-style checker (ESLint) to a new major version, but it still cannot be merged. The record of exact installed versions was never updated to match, so a clean install fails, and the shared style preset the site uses does not yet support the new checker version. The site's automated tests fail on this revision too.


Re-review of head 1dfdbee. Since the previous head, only the rebase changed things: the lockfile picked up bumps from the base branch (playwright 1.65.1, vue-i18n/@intlify 11.4.20). None of it touches ESLint.

Earlier findings:

  • Lock file not regenerated (package.json:60) is still present. package.json:60 pins "eslint": "10.15.0", but package-lock.json:40 still records "eslint": "9.39.5", and packages["node_modules/eslint"].version is 9.39.5. npm ci refuses a lockfile that does not match package.json.
  • @antfu/eslint-config peer range (package.json:51) is still present. package.json:51 pins @antfu/eslint-config 6.7.3. Its lock entry (package-lock.json:108) declares peer "eslint": "^9.10.0", which excludes 10.x.

CI at this head: the test and wolves-movie-flow check runs both concluded failure (head_sha 1dfdbee). I could not read the job logs, so I am not citing a cause from them.

Fix on the base branch, not here (the bot overwrites this branch). Either wait for an @antfu/eslint-config release whose peer range includes ^10, or bump it together with eslint as one grouped update. Then regenerate package-lock.json with npm install, so the bot's next run carries a consistent lock.

No findings from: security, intent-alignment, style, docs-currency.

Findings not on a changed line

  • package.json:51: Still present: @antfu/eslint-config 6.7.3 declares peer eslint: ^9.10.0 (package-lock.json:108), which excludes ESLint 10. Bump it to a release that supports ^10 in the same update, or hold this eslint bump until one exists.

Confidence: 1/5 (needs attention) — 2 high findings

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

Comment thread package.json
"@vue/test-utils": "2.5.1",
"@xmldom/xmldom": "0.9.12",
"eslint": "9.39.5",
"eslint": "10.15.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still present: package.json pins eslint 10.15.0, but package-lock.json:40 and node_modules/eslint in the lock are still 9.39.5. npm ci fails on the mismatch. Regenerate the lockfile with npm install once the peer conflict on line 51 is resolved.

@hivecommons-hive hivecommons-hive Bot removed the stage/stalled No activity (head, comment, review, CI, label) longer than the stage expects; nobody is working it label Nov 18, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/major-eslint-monorepo branch from 1dfdbee to 1444205 Compare November 18, 2026 03:14

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend closing in favour of #1038. This PR cannot pass CI on its own, and #1038 already includes this exact bump.

1. Lockfile not updated, so npm ci fails. This PR changes only package.json:60 (eslint 9.39.5 → 10.15.0). package-lock.json is unchanged; Renovate's renovate/artifacts check reports "Artifact file update failure". The test and wolves-movie-flow jobs (run 44228959911) both stop at install:

npm error Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0

2. Already part of #1038. #1038 makes the same "eslint": "10.15.0" change in package.json. It also bumps @antfu/eslint-config 6.7.3 → 10.0.0, regenerates package-lock.json, and applies the formatting changes the new rules require. ESLint 10 also has to move together with @antfu/eslint-config v10 (#1023), and #1038 is the only PR that does both together.

If #1038 lands, this PR will either conflict with main or change nothing. If a maintainer agrees, this PR and #1023 can be closed in favour of #1038. I have not closed anything.

Confidence: 0/5 (do not merge) — 1 high finding; 1 medium finding; reject verdict

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326

@hivecommons-hive hivecommons-hive Bot added stage/stalled No activity (head, comment, review, CI, label) longer than the stage expects; nobody is working it hive:unauthorized labels Nov 18, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

The hive's GitHub App lacks actions: write, so it cannot rerun shared ci for head ac0cd95d6726. A repository maintainer with Actions write can re-run failed jobs at https://github.com/projectbluefin/website/actions/runs/44665188423 . Alternatively, the App owner can request Actions read and write for this recovery installation and its owner must accept the update. This is a CI recovery permission block, not a source-code failure or merge approval. Hive retries after its bounded permission cooldown; no alternate credential is selected. Hive will resume automatically once the step is done; this label and note clear themselves.

Attempt 7: the same block hit heads 24011800d7cb, da8e06af92c2, 3d9e7e07770f, ee5db85d3099, ac0cd95d6726.

@hivecommons-hive hivecommons-hive Bot removed the stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it label Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 19, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/major-eslint-monorepo branch from 3d9e7e0 to ee5db85 Compare November 20, 2026 00:20
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head hive:unauthorized stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed hive:unauthorized stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 20, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This automated update moves the website's code-checking tool (ESLint, which flags style and bug patterns in the source) to a new major version. As it stands it cannot be installed: the file that records exact package versions was not updated with it, so every automated check stops at the install step. The site's shared lint rule set also only declares support for the old version, so a simple refresh of that file may not be enough.

What I need from you: Don't merge this head; decide whether to upgrade the shared rule set alongside ESLint or hold this update.


correctness

See the inline thread on package.json:60. Both failing checks at this head (test, wolves-movie-flow, head ee5db85) fail in the npm ci step with EUSAGE and Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0. Lint, typecheck, tests and build never ran, so this head is untested.

Limits: I did not run npm install locally. I could not confirm whether a newer @antfu/eslint-config release supports ESLint 10, or whether eslint.config.js works under ESLint 10.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 high finding

-- hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327

Comment thread package.json
"@vue/test-utils": "2.6.0",
"@xmldom/xmldom": "0.9.12",
"eslint": "9.39.5",
"eslint": "10.15.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness (in-scope, high): This bumps eslint to 10.15.0, but package-lock.json was not regenerated. At this head the lockfile still has root devDependency "eslint": "9.39.5" (package-lock.json:40), and node_modules/eslint is 9.39.5. CI npm ci fails at this head (job 135985517298): npm error Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0.

A plain lockfile refresh is also likely to hit a peer conflict. @antfu/eslint-config@6.7.3 (package.json:51), which eslint.config.js:1,13 builds the whole lint config from, declares peer "eslint": "^9.10.0" (package-lock.json:108). npm install would raise ERESOLVE without --legacy-peer-deps.

Fix on main: bump @antfu/eslint-config to a release whose peer range includes ^10, together with this ESLint bump. Then regenerate package-lock.json with npm install and confirm npm run lint passes. If no such release exists, hold ESLint at 9.x, for example with a Renovate packageRules entry: {"matchPackageNames":["eslint"],"allowedVersions":"<10"}. Renovate's next run will then rebase this PR.

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 20, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/major-eslint-monorepo branch from ee5db85 to ac0cd95 Compare November 20, 2026 03:04
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head hive:unauthorized stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue hive:unauthorized stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 20, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @Danathar should decide whether to close this Renovate PR in favour of #1038, which carries the same eslint v10 pins together with the required config and reformat.

Duplicate, superseded by #1038. Recommend closing this one once #1038 lands. I have not closed anything.

What I verified:

  • #1038 changes package.json with @antfu/eslint-config 6.7.3 to 10.0.0 and eslint 9.39.5 to 10.15.0, the same pins as this PR and #1023, plus the lockfile, eslint.config.js and the lint:fix reformat.
  • Base main still pins @antfu/eslint-config 6.7.3 and eslint 9.39.5 (package.json:51, package.json:60), so neither bump has landed yet.
  • This PR moves only eslint and has no lockfile change (renovate/artifacts reports "Artifact file update failure"); test and wolves-movie-flow fail.
  • The two bumps must move together: config 10.x needs eslint 10, and config 6.x accepts only eslint 9. Merging this PR alone cannot go green.

Caveat: #1038 is currently mergeable_state=dirty (needs a rebase on main). Keep this PR open until #1038 merges; then it is a no-op and can be closed. If Renovate reopens the split pair afterwards, grouping eslint with @antfu/eslint-config in the Renovate config would stop that.

Confidence: 3/5 (needs attention) — 2 medium findings

-- hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327

@castrojo

Copy link
Copy Markdown
Contributor

Closed as superseded by #1038.

@castrojo castrojo closed this Nov 20, 2026
@mergeraptor
mergeraptor Bot deleted the renovate/major-eslint-monorepo branch November 20, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hive:unauthorized no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants