Repository navigation
chore(renovate): pin Renovate's npm to CI's and guard the pin - #1050
Merged
Merged
Conversation
Renovate runs npm 12, but CI runs npm 11 (Node 26 bundles it). npm 12 refuses some downloads npm 11 allows, so Renovate can't write the lock file for the Tailwind 4.3.5 update (#1009): npm error code EALLOWREMOTE npm error Fetching packages of type "remote" have been disabled - renovate.json: constraints.npm ^11.20.0, so Renovate's lock-file runs use CI's npm. Stop offering updates to that pin, and put a reminder in every Node major PR to raise it in the same PR. - scripts/tests/npm-constraint.test.ts: fails when the npm running the tests differs from the pin's major, with the exact value to set. - docs/skills/validation/SKILL.md: explain the pin and the test. Same change as projectbluefin/documentation#1729 and projectbluefin/testsuite#1278 (testsuite's pin dates from #1255). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qptoi6WwWFaNJymyz Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
castrojo
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The update bot uses a newer npm (12) than the site's own tests (npm 11, which comes with Node 26). npm 12 refuses a download npm 11 allows, so the bot can't finish updates like the Tailwind one in #1009. This makes the bot use the same npm as the tests, stops it proposing npm upgrades on its own, and adds a test that fails if the two ever disagree, so the setting can't be forgotten when the site moves to a newer Node.
What I need from you: a review and approval from a maintainer other than Danathar (this repo needs one approval).
Cause
Renovate's lock-file step on #1009:
Checked locally with npm 11.20.0 (CI's version): #1009's
package.jsonresolves cleanly withnpm install --package-lock-only --ignore-scripts, and the lock gets tailwindcss 4.3.5.Changes
renovate.json:constraints.npm: ^11.20.0, so Renovate writes lock files with CI's npm.renovate-configmanager, depTypetool-constraint; renovatebot/renovatelib/modules/manager/renovate-config/extract.ts:93).scripts/tests/npm-constraint.test.ts: fails when the npm running the tests (npm_config_user_agent) differs from the pin's major, with the exact value to set. It skips when the tests aren't run through npm. It runs in the requiredtestjob (npm run test:run).docs/skills/validation/SKILL.md: point 11 explains the pin and the test, so the fix is to raise the pin, not to edit the test.After merge
Tick the rebase box on #1009; its
renovate/artifactsshould go green.Not covered: #1024 (ESLint 10) fails for a different reason.
@antfu/eslint-configdoesn't accept ESLint 10 yet (ERESOLVE), and it's a major that waits for a person anyway.Same change as projectbluefin/documentation#1729 and projectbluefin/testsuite#1278.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WcWm7qptoi6WwWFaNJymyz