Repository navigation
π dupsweep: a bot series is the same job, not just the same bot and files - #18837
Merged
hivecommons-hive[bot] merged 1 commit intoNov 17, 2026
Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons-hive[bot] merged 1 commit into
Conversation
isBotSeries counted any two open PRs by one bot that touch the same files as a regeneration series, so a dependency bot's separate bumps sharing package.json were called superseded by construction. A series now also needs the same job: titles equal once versions, dates and hashes are set aside, or byte-identical patches. One bot's different jobs form no cluster; finding-identity clusters are kept. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#18837e0029ba` sha256:24a943db4a6e514f1a84c9fd9eb179a267ae0ec5c9f2417e96884d30e64c9aba β download from the dashboard or `hivectl review evidence #18837`.merged by Hive trusted-author auto-merge: author |
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The duplicate-PR sweep treated any two open PRs by one bot that touch the same files as a "Superseded regeneration series". A dependency bot opens one PR per dependency, and they all edit
package.jsonand its lockfile. So the sweep told maintainers the older bumps were "superseded by construction", even though each one updates a different dependency.With this change a bot series has to be the same job run again:
One bot's separate jobs that merely share a file form no cluster and get no comment.
What happened
Seen on projectbluefin/website. The bot is
mergeraptor[bot], which is Renovate running as an App. Times are Eastern.@antfu/eslint-configv10 bump, "supersedes" feat: styled 403 page + API column in dashboardΒ #1019, avue-tscbump.Every one of those comments then ends with "Here the patches DIFFER β¦ dependency-bump PRs that edit one shared manifest β¦ land in it". So the hive contradicts itself and invites a maintainer to close real updates. The branches (
renovate/antfu-eslint-config-10.x,renovate/js-yaml-5.x, β¦) show they are separate updates.Cause
isBotSeries(src/pkg/dupsweep/dupsweep.go) checked only three things:Targets()posts one summary on the newest PR, andrenderBotSeriessays the older ones "are superseded by construction".Confidencecomment and β¨ The reviewer cannot reduce a PR queue: no write path, no cross-PR view, and its verdicts only gate a merge sweep unused spokes never runΒ #7469 itself name "renovate digest bumps for three different images" as the known false positive. The bot-series path ignored that.What changed
All in
src/pkg/dupsweep:sameJob. Titles are compared afterjobTitlenormalises them:#;web3,python3) kept.So "chore: regenerate X (2026-11-16)" and "(2026-11-17)" match, while "update dependency vue-tsc to v3.3.14" and "update dependency js-yaml to v5" don't.
Same author is necessary, not sufficient.
isBotSeriesbecomessameBotAuthor. A cluster is a bot series when it has the same bot author and eithersameJobmatches or the confidence is identical-diff.One bot's different jobs are dropped. A cluster where every member is the same bot, that is not a series, and is graded below finding-identity forms no cluster. Without this, the fix would only swap "superseded" for a "Possible duplicate" comment on each bump.
Unchanged:
Findwithout authors.Head branch not used. Bots never share a head branch between two open PRs, whether they are reruns or separate bumps, so a branch cannot tell the two cases apart. The title is the name the bot gives its job, and
PR.Titlewas already on the struct, so no new field was needed.Docs:
docs/duplicate-sweep.md(survivor selection). Plus a changelog fragment.Comments already posted
The sweep edits only the comment of a cluster it still finds (keyed by
MarkerFor). It never withdraws a comment once the cluster is gone, which is also what happens today when a member PR merges. So the comments already on projectbluefin/website#1023, #1024, #1037 and #1044 stay as they are, and the sweep posts nothing new there. Withdrawing stale suggestions would mean scanning the comments of every un-clustered PR on each pass, so I left it out of this PR.Not in this PR
pr_duplicate_fix_sweep.go). It is a different mechanism with its own owner decision (Scanner dispatches issues that already have an open linked PR; duplicates escalate to owner instead of auto-resolvingΒ #14799).Tests
dupsweep_test.go:jobTitletable of same-job and different-job pairs.duplicate_sweep_test.go: an end-to-end sweep over threemergeraptor[bot]bumps, with posting on, produces no cluster, no comment and no GitHub write.bot_authorstests are unchanged and still describe the behaviour.Only
gofmt -lwas run locally (AGENTS.md bans localgo test/go build/go vet); CI runs the tests. The normalisation patterns were also checked by hand against the titles above.No open issue covers this. The searches for "regeneration series",
isBotSeries,dupsweep, "bot series" and "superseded by construction" found only the closed #7469 and the merged #7512.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1