Skip to content

chore(deps): update the code-style checker to version 10 and apply its formatting - #1038

Merged
castrojo merged 6 commits into
mainfrom
chore/eslint-10
Nov 20, 2026
Merged

castrojo merged 6 commits into
mainfrom
chore/eslint-10

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary: This updates the website's code-style checker to its newest version. The checker and its rule set have to be updated together, and the two separate automatic update requests could never pass on their own. Nothing visitors see changes. Most of the diff is line breaks the new rules ask for, plus one heading fix in a character dossier.


Closes #1033. Supersedes #1023 and #1024. Both can be closed once this merges.

Why

@antfu/eslint-config 6.x accepts only eslint 9, and 10.x needs eslint 10 (through eslint-plugin-unicorn and eslint-plugin-slop). So #1023 and #1024 each fail alone. This PR moves both in one change, in three commits so the large reformat can be reviewed separately:

  1. build(deps): @antfu/eslint-config 6.7.3 → 10.0.0 and eslint 9.39.5 → 10.15.0. I regenerated the lockfile with npm 11 by uninstalling and reinstalling just these two packages. Only lint tooling moves: no root runtime or build dependency (vite, vue, vitest, typescript) changes version.
  2. fix(lint): the config and content changes.
    • Two new rules turned off: e18e/prefer-array-fill and e18e/prefer-object-has-own. Their auto-fixes rewrite code instead of reformatting it. Object.hasOwn is outside the ES2020 lib in tsconfig.json. The Array.from({ length }).fill(x) rewrite widens a number[] to unknown[]. The issue keeps behaviour changes out of scope, so they are off here and can be turned on in a separate change.
    • Heading fix: markdown/heading-increment in src/data/lore/chris-aniszczyk.md. The four ### section headings are now ##. Lore bodies show heading markers as literal text (renderLoreParagraphs does not parse headings), so this removes one # from each of those four on-screen lines. No test or timeline refers to that text.
    • Skill note: the validation skill now records this upgrade procedure.
  3. style: the output of npm run lint:fix, mostly the new antfu/reasonable-newline rule. I checked it mechanically: once whitespace is stripped, every touched file is identical to the version before, with one exception. In wolves-track-zero-manifest.ts, antfu/top-level-function turned a one-line arrow helper (status) into an equivalent function declaration. No Vue <template> or <style> block changed.

About the unused-imports/no-unused-vars hits the issue lists: those 55 errors came from running config v10 on eslint 9 (#1023's CI). On eslint 10 they no longer appear, so I made no config change or _ renames for them. After the fix, lint reports 0 errors and 25 jsdoc/require-returns-description warnings. Those are warnings, so they don't fail lint.

Validation

Per the hive's rules, I ran no test, typecheck or build locally. The only local ESLint run was the --fix codemod the issue asks for. CI gives the verdict for lint, typecheck, test:gate, build and wolves-movie-flow.

— hive: agent=scanner backend=claude model=claude-opus-5-5

🤖 Generated with Claude Code


🐝 Hive Agent: contributor | SHA: 87482a3f

@Danathar

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 17, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

ℹ️ Sentinel: informational, author is trusted (owner), merge is not blocked. Head 08b79c0ad7ec matched:

  • sensitive_path: changes 2 sensitive path(s) (package-lock.json, package.json)

No sentinel-alert label was added. The finding is recorded in the dashboard Security tab and /api/sentinel; set sentinel.trusted_authors_block: true to block trusted authors too.

@hivecommons-hive hivecommons-hive Bot added stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 17, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @c184246, 4/4 checks green, soak 30m0s elapsed. Auto-merge is off for this repo, so a person merges.

The hive never approves on your behalf: approve and merge it on GitHub if you accept it.

Updated 2026-11-18 17:58 UTC.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/072-returned-to-contributor Clanker PR: CI red, changes requested or conflicting; diagnosis posted, its hive must act and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

Danathar and others added 4 commits November 18, 2026 17:21
@antfu/eslint-config 6.7.3 only accepts eslint 9, and v10 of the config
needs eslint 10 (through eslint-plugin-unicorn and eslint-plugin-slop), so
the two cannot move separately. Lockfile regenerated with npm 11; only
lint tooling packages change.

Refs #1033

Hive-Run: #1033
Hive-Plan: issue-1033 What to change
Hive-Spec: issue-1033#acceptance
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Turn off e18e/prefer-array-fill and e18e/prefer-object-has-own: their
auto-fixes rewrite code (Object.hasOwn is outside the ES2020 lib in
tsconfig.json; the fill() rewrite widens a number[] to unknown[]).
Fix the skipped heading level that markdown/heading-increment reports
in the Chris Aniszczyk dossier, and record the upgrade procedure in the
validation skill.

Refs #1033

Hive-Run: #1033
Hive-Plan: issue-1033 What to change
Hive-Spec: issue-1033#acceptance
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Output of `npm run lint:fix` under the v10 config, mostly the new
antfu/reasonable-newline rule. Every touched file is identical to the
previous version once whitespace is removed, except one top-level arrow
helper in wolves-track-zero-manifest.ts that antfu/top-level-function
turned into an equivalent function declaration. No Vue template or
style block changes.

Refs #1033

Hive-Run: #1033
Hive-Plan: issue-1033 What to change
Hive-Spec: issue-1033#acceptance
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Clanker PR: CI red, changes requested or conflicting; diagnosis posted, its hive must act labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/072-returned-to-contributor Clanker PR: CI red, changes requested or conflicting; diagnosis posted, its hive must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing labels Nov 19, 2026
Resolve conflict in docs/skills/validation/SKILL.md by preserving both
the ESLint upgrade procedure and Renovate's npm pin documentation.

Assisted-by: Gemini via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: castrojo <castrojo@users.noreply.github.com>
castrojo
castrojo previously approved these changes Nov 20, 2026

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved. Rebased onto main with both ESLint v10 and Renovate npm pin preserved.

@castrojo
castrojo enabled auto-merge November 20, 2026 04:03
Assisted-by: Gemini via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: castrojo <castrojo@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Clanker PR: CI red, changes requested or conflicting; diagnosis posted, its hive must act labels Nov 20, 2026

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved with validation skill fix.

@castrojo
castrojo added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 9874240 Nov 20, 2026
4 checks passed
@castrojo
castrojo deleted the chore/eslint-10 branch November 20, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: upgrade eslint and @antfu/eslint-config to v10 together and fix the new lint errors

2 participants