Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@vitest/coverage-v8": "5.1.0",
"@vue/test-utils": "2.6.0",
"@xmldom/xmldom": "0.9.12",
"eslint": "9.39.5",
"eslint": "10.15.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness (still present): The lock file was not regenerated. At this head package-lock.json still pins node_modules/eslint to 9.39.5, and its root devDependencies.eslint is 9.39.5. npm ci aborts with EUSAGE: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0 (CI test job 134137314961 on 8e375b9e). Every job that runs npm ci fails. Fix: run npm install and commit the regenerated package-lock.json together with the bump. That only works once the peer conflict on line 51 is resolved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still present: package.json pins eslint 10.15.0, but package-lock.json:40 and node_modules/eslint in the lock are still 9.39.5. npm ci fails on the mismatch. Regenerate the lockfile with npm install once the peer conflict on line 51 is resolved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint is bumped to 10.15.0 here, but package-lock.json:5383 still pins 9.39.5. npm ci fails at this head (test and wolves-movie-flow jobs): Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0. Also, @antfu/eslint-config@6.7.3 (line 51) has peer eslint: ^9.10.0. Bump it to 10.0.0 (peer ^9.10.0 || ^10.0.0) in the same change, then regenerate the lock file with npm install.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness (still present from last review): package.json:60 now asks for eslint 10.15.0, but package-lock.json at this head still resolves node_modules/eslint to 9.39.5 (line 5407), and the root entry at line 40 still says "eslint": "9.39.5". CI at this head (test, wolves-movie-flow, head_sha 2401180) fails in npm ci: Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0. Fix: regenerate the lockfile with npm install together with the @antfu/eslint-config bump described in the summary.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness (in-scope, high): This bumps eslint to 10.15.0, but package-lock.json was not regenerated. At this head the lockfile still has root devDependency "eslint": "9.39.5" (package-lock.json:40), and node_modules/eslint is 9.39.5. CI npm ci fails at this head (job 135985517298): npm error Invalid: lock file's eslint@9.39.5 does not satisfy eslint@10.15.0.

A plain lockfile refresh is also likely to hit a peer conflict. @antfu/eslint-config@6.7.3 (package.json:51), which eslint.config.js:1,13 builds the whole lint config from, declares peer "eslint": "^9.10.0" (package-lock.json:108). npm install would raise ERESOLVE without --legacy-peer-deps.

Fix on main: bump @antfu/eslint-config to a release whose peer range includes ^10, together with this ESLint bump. Then regenerate package-lock.json with npm install and confirm npm run lint passes. If no such release exists, hold ESLint at 9.x, for example with a Renovate packageRules entry: {"matchPackageNames":["eslint"],"allowedVersions":"<10"}. Renovate's next run will then rebase this PR.

"eslint-plugin-format": "2.0.1",
"happy-dom": "21.0.4",
"playwright": "1.65.1",
Expand Down
Loading