Repository navigation
chore(deps): update dependency eslint to v10 #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ | |
| "@vitest/coverage-v8": "5.1.0", | ||
| "@vue/test-utils": "2.6.0", | ||
| "@xmldom/xmldom": "0.9.12", | ||
| "eslint": "9.39.5", | ||
| "eslint": "10.15.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still present: package.json pins eslint 10.15.0, but package-lock.json:40 and node_modules/eslint in the lock are still 9.39.5.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correctness (still present from last review):
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correctness (in-scope, high): This bumps A plain lockfile refresh is also likely to hit a peer conflict. Fix on |
||
| "eslint-plugin-format": "2.0.1", | ||
| "happy-dom": "21.0.4", | ||
| "playwright": "1.65.1", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correctness (still present): The lock file was not regenerated. At this head
package-lock.jsonstill pinsnode_modules/eslintto9.39.5, and its rootdevDependencies.eslintis9.39.5.npm ciaborts withEUSAGE:lock file's eslint@9.39.5 does not satisfy eslint@10.15.0(CItestjob 134137314961 on8e375b9e). Every job that runsnpm cifails. Fix: runnpm installand commit the regeneratedpackage-lock.jsontogether with the bump. That only works once the peer conflict on line 51 is resolved.