Skip to content

chore(deps): update dependency @antfu/eslint-config to v10 - #1023

Closed
mergeraptor[bot] wants to merge 1 commit into
mainfrom
renovate/antfu-eslint-config-10.x
Closed

mergeraptor[bot] wants to merge 1 commit into
mainfrom
renovate/antfu-eslint-config-10.x

Conversation

@mergeraptor

@mergeraptor mergeraptor Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
@antfu/eslint-config 6.7.3 → 10.0.0 age confidence

Release Notes

antfu/eslint-config (@​antfu/eslint-config)

v10.0.0

Compare Source

   🚨 Breaking Changes
  • Upgrade deps, enable antfu/reasonable-newline and stabilize consistent-list-newline  -  by @​antfu and Claude Sonnet 5.5 (55ed6)
    View changes on GitHub

v9.5.1

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v9.5.0

Compare Source

   🚀 Features
    View changes on GitHub

v9.4.1

Compare Source

   🚀 Features
  • pnpm: Enforce new-line style for pnpm-workspace.yaml  -  by @​antfu (ab400)
    View changes on GitHub

v9.4.0

Compare Source

   🚀 Features
    View changes on GitHub

v9.3.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v9.2.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v9.1.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v9.0.0

Compare Source

   🚨 Breaking Changes
    View changes on GitHub

v8.3.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
  • markdown: Scope user rule overrides away from md files  -  by @​antfu and Claude Opus 4.7 (1M context) in #​844 (8d25a)
    View changes on GitHub

v8.2.0

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v8.1.1

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v8.1.0

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v8.0.0

Compare Source

   🚨 Breaking Changes
   🚀 Features
    View changes on GitHub

v7.7.3

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v7.7.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v7.7.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v7.6.1

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v7.6.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v7.5.0

Compare Source

   🚀 Features
    View changes on GitHub

v7.4.3

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v7.4.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v7.4.1

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v7.4.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v7.3.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v7.2.0

Compare Source

   🚀 Features
    View changes on GitHub

v7.1.0

Compare Source

   🚀 Features
    View changes on GitHub

v7.0.1

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v7.0.0

Compare Source

   🚨 Breaking Changes
   🚀 Features
    View changes on GitHub

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@hivecommons-hive hivecommons-hive Bot added no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

🐝 Superseded regeneration series

mergeraptor[bot] has 2 open PRs regenerating the same file(s). This one is the newest, so the 1 older one(s) are superseded by construction:

Posted once on the newest PR rather than on each of them, so a daily regeneration does not produce a daily comment on every PR in the series.

Evidence — identical changed-file set (2 file(s)):

  • package-lock.json
  • package.json

This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides.

It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting.

@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor
a491a75

ℹ️ Sentinel notice — informational; author is trusted (allow-listed bot), merge is not blocked

Hive flagged this PR (author @mergeraptor[bot], head a491a7533d60) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 2 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • package-lock.json
    • package.json

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot added the stage/stalled No activity (head, comment, review, CI, label) longer than the stage expects; nobody is working it label Nov 16, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not mergeable as is. The bump works, but the new config fails lint on existing code. This PR and #1024 also depend on each other, so the order matters.

Why test is red (job 133393350624):

  • @antfu/eslint-config@10.0.0 turns on a new rule, antfu/reasonable-newline.
  • That rule fails existing sources, for example: Complex ternaries should have line breaks before '?' and Arrays with 4 or more items on a line longer than 40 should have line breaks between items.
  • The bump itself installs and runs. eslint stays at 9.39.5, and v10's peer range ^9.10.0 || ^10.0.0 accepts that.

Also: v10 pulls in eslint-plugin-unicorn@78.0.0, which needs peer eslint@">=10.4". npm only warns (ERESOLVE overriding peer dependency). With eslint 9 this plugin runs outside its supported range until #1024 lands.

Link to #1024: #1024 (eslint 9 to 10) cannot build its lock file on main. The cause is that @antfu/eslint-config@6.7.3 only accepts peer eslint@^9.10.0. That is why #1024 fails renovate/artifacts and npm ci (lock file's eslint@9.39.5 does not satisfy eslint@10.15.0).

Suggested order:

  1. Add a commit here running npm run lint:fix, or turn off antfu/reasonable-newline in the eslint config if the team prefers that.
  2. Land this PR.
  3. Let Renovate rebase #1024 so it can regenerate its lock file.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

@Danathar

Copy link
Copy Markdown
Contributor

Not approving. v10 installs fine, but lint fails with 1201 errors on existing code (https://github.com/projectbluefin/website/actions/runs/43894242029/job/133393350624).

  • 1143 come from v10's new antfu/reasonable-newline rule (its only listed breaking change). Nearly all of them can be fixed automatically.
  • 55 are unused-imports/no-unused-vars on parameter names inside type signatures (for example (e: 'previous'): void in WolvesControlBar.vue's defineEmits). These need a rule option or _ prefixes; --fix won't handle them.
  • 1 is a skipped heading level in src/data/lore/chris-aniszczyk.md.

This PR also needs #1024: v10 brings eslint-plugin-unicorn 78, which requires eslint >=10.4. I'd do both in one PR: bump both packages, run npm run lint:fix (or turn off antfu/reasonable-newline if we don't want the reformat), fix the remaining 56 by hand, then close this PR and #1024.

@Danathar

Copy link
Copy Markdown
Contributor

The fix on main is tracked in #1033.

@mergeraptor
mergeraptor Bot force-pushed the renovate/antfu-eslint-config-10.x branch from 11f96a2 to f37c5cd Compare November 17, 2026 15:10

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This automated update moves the website's code-style checker to a new major version. It still cannot merge: the new version adds stricter formatting rules, and the site's existing code breaks about 1,200 of them, so the automatic checks fail. It also installs a helper that needs a newer checker than the site uses. Since the last review, the branch only picked up other updates that already landed on the main branch; this change itself is the same.

What I need from you: Choose a fix on the main branch: reformat the code and upgrade the checker, or turn off the new rule. Until then, hold this update.


Re-reviewed at head f37c5cdb. The delta since 11f96a24 is a rebase onto main: the workflow, renovate.json and other dependency changes come from already-merged PRs (#1002, #1021, #1022, #1026, #1027, #1028). The PR's own change is still package.json:51 plus the lockfile.

Previous findings:

  • New antfu/reasonable-newline rule fails lint on existing code: still present. CI job 134137155324 ran on f37c5cdb. Its npm run lint step fails with ✖ 1226 problems (1201 errors, 25 warnings), and 1143 of those lines are antfu/reasonable-newline. There are also new unused-imports/no-unused-vars errors for unused args ('e' is defined but never used. Allowed unused args must match /^_/u). Typecheck, tests and build were skipped.
  • eslint-plugin-unicorn@78 peer requires eslint >=10.4: still present. See the inline note on the lockfile.

The bot regenerates this branch, so the fix belongs on main. Either (a) run npm run lint:fix with this version, review the reformat, and bump eslint to ^10.4 in the same change, or (b) add 'antfu/reasonable-newline': 'off' to the rules block in eslint.config.js. Option (b) does not fix the eslint peer mismatch. After either fix lands, the bot's next run brings it into this PR.

No findings from: security, intent-alignment, style, docs-currency.

Findings not on a changed line

  • package-lock.json:493: correctness (still present from the previous review): @antfu/eslint-config@10.0.0 installs a nested eslint-plugin-unicorn@78.0.0, which declares peer eslint: ">=10.4" and needs Node >=22. package.json still pins eslint to 9.39.5, and npm ci at this head logs npm warn peer eslint@">=10.4" from eslint-plugin-unicorn@78.0.0. Running unicorn rules on an eslint version they were not built for can crash or misbehave. Fix on main: bump eslint to ^10.4.0 along with this upgrade.

Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

Comment thread package.json
},
"devDependencies": {
"@antfu/eslint-config": "6.7.3",
"@antfu/eslint-config": "10.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness (still present from the previous review): v10 turns on antfu/reasonable-newline by default. CI lint at f37c5cdb (job 134137155324) fails with ✖ 1226 problems (1201 errors, 25 warnings). 1143 of them are this rule, and the rest include new unused-imports/no-unused-vars arg errors. The test job stops at lint. Fix on main: run npm run lint:fix with v10 and commit the reformat, or set 'antfu/reasonable-newline': 'off' in eslint.config.js rules.

@Danathar

Copy link
Copy Markdown
Contributor

Correction: this PR isn't superseded. It updates @antfu/eslint-config to v10, which no other open PR updates. It only shares package.json / package-lock.json with the other Renovate PRs. Ignore the hive's "Superseded regeneration series" note above: it treated every bot PR that touches the same files as one series. That's fixed in hivecommons/hive#18837.

@mergeraptor
mergeraptor Bot force-pushed the renovate/antfu-eslint-config-10.x branch from f37c5cd to d59a9ff Compare November 18, 2026 00:22

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This automated update moves the website's code-style checker to a new major version. The new version still cannot merge as it is. It adds stricter formatting rules that the site's existing code breaks, so the automatic checks fail. It also pulls in a plugin that needs a newer version of the checker than this project uses. The latest push only picked up changes already on the main branch. It fixes neither problem.

What I need from you: Decide where the fix lands: reformat the code and adjust the rules on the main branch, or hold this update.


correctness

Previous findings at this head (d59a9ff):

  • New antfu/reasonable-newline rule fails lint on existing code: still present. The test job at this head (job 134476473779, head_sha d59a9ff5) fails at npm run lint with ✖ 1226 problems (1201 errors, 25 warnings). Hits include vite.config.ts:99, src/utils/feedParser.ts:44, and src/tests/wolvesTrailerPlates.test.ts:214. The same run also shows unused-imports/no-unused-vars errors for unused args in src/utils/feedParser.ts:11-27 ("Allowed unused args must match /^_/u"). These are part of the same lint break. Typecheck, tests and build are skipped after lint fails.
  • eslint-plugin-unicorn@78 peer requires eslint>=10.4: still present. package-lock.json:493 declares "eslint": ">=10.4" for the nested @antfu/eslint-config/node_modules/eslint-plugin-unicorn (version 78.0.0, line 457). package.json:60 still pins "eslint": "9.39.5". The bot cannot fix either one. Fix on main:
    1. Bump eslint in package.json to a ^10.4 release, or add an override that pins eslint-plugin-unicorn to a release that supports eslint 9.
    2. Run npx eslint --fix with config v10. It reports that 1145 of the 1201 errors are auto-fixable. Prefix the unused args in src/utils/feedParser.ts with _.
    3. Alternatively, turn off antfu/reasonable-newline in eslint.config until the code is reformatted.

The new delta (f37c5cd...d59a9ff) is a rebase. The playwright change from 1.65.0 to 1.65.1 at package.json:63 already exists on main. It is not scope creep.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding

— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325

Comment thread package.json
},
"devDependencies": {
"@antfu/eslint-config": "6.7.3",
"@antfu/eslint-config": "10.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still present at d59a9ff. Config v10 turns on antfu/reasonable-newline. At this head, npm run lint fails with 1201 errors (CI job 134476473779), for example at vite.config.ts:99 and src/utils/feedParser.ts:44. Its nested eslint-plugin-unicorn@78 also needs eslint>=10.4 (package-lock.json:493), but package.json:60 pins eslint 9.39.5. Fix on main: bump eslint to ^10.4, run eslint --fix (1145 errors are auto-fixable), and prefix the unused args in src/utils/feedParser.ts with _. The alternative is to turn off the rule in the eslint config.

@hivecommons-hive hivecommons-hive Bot removed the stage/stalled No activity (head, comment, review, CI, label) longer than the stage expects; nobody is working it label Nov 18, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/antfu-eslint-config-10.x branch from d59a9ff to 447e145 Compare November 18, 2026 03:13
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 19, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/antfu-eslint-config-10.x branch from 3e19646 to 8a132bc Compare November 20, 2026 00:20
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head hive:unauthorized stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed hive:unauthorized stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 20, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This automated update moves the website's code-style checker to a new major version. The new version adds stricter formatting rules, and the site's existing code does not follow them. As a result, the automated code check fails on this update, while it passes on the main branch. It should not be merged until the code (or the checker's settings) is brought in line.

What I need from you: Pick how to absorb the new style rules on the main branch (reformat the code, or turn the new rule off), then let the bot rebase.


correctness

  • Lint gate fails at this head (blocking). CI job test (job 135985412758, head 8a132bc) fails at npm run lint: ✖ 1226 problems (1201 errors, 25 warnings). The same CI workflow is green on main at 974cc1d. Breakdown from the log: 1143 × antfu/reasonable-newline (new rule, enabled by v10 per its release notes), 55 × unused-imports/no-unused-vars (e.g. src/components/wolves/WolvesControlBar.vue:39-41, unused e args), plus a few e18e/* and markdown/heading-increment. Typecheck, tests and build were skipped, so they are unverified for this head. The log reports 1145 errors fixable with --fix. Since the bot cannot push fixes, this has to land on main first. Option A: run npm run lint:fix after the bump and rename the unused args to _e. Option B: switch off the new rule in eslint.config.js:
       'node/prefer-global/process': ['error', 'always'],
    +  'antfu/reasonable-newline': 'off',
    Option B still leaves about 58 non-newline errors to fix by hand.
  • Peer mismatch with pinned ESLint. The lockfile pulls in eslint-plugin-unicorn@78.0.0 (package-lock.json:462), which declares peer "eslint": ">=10.4" (package-lock.json:499). The project pins "eslint": "9.39.5" (package.json:60). npm ci warns about this in the CI log. @antfu/eslint-config@10 itself accepts ^9.10.0 || ^10.0.0, so the mismatch is only in the transitive plugin. Unicorn rules may misbehave under ESLint 9. Consider moving ESLint to v10 in the same change.

No findings from: security, intent-alignment, style, docs-currency.

Findings not on a changed line

  • package-lock.json:499: Transitive eslint-plugin-unicorn@78.0.0 requires peer eslint >=10.4, but package.json:60 pins eslint 9.39.5. npm ci warns about this. Consider bumping ESLint to v10 alongside this update.

Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding

-- hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327

Comment thread package.json
},
"devDependencies": {
"@antfu/eslint-config": "6.7.3",
"@antfu/eslint-config": "10.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping to @antfu/eslint-config@10.0.0 turns on antfu/reasonable-newline and other new rules. At this head, npm run lint fails with 1201 errors (CI job 135985412758), while main is green. Before this can merge, reformat the code on main (npm run lint:fix, then rename the unused e args to _e) or add 'antfu/reasonable-newline': 'off' to eslint.config.js.

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 20, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/antfu-eslint-config-10.x branch from 8a132bc to a491a75 Compare November 20, 2026 03:03
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed hive:unauthorized stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Nov 20, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @Danathar should decide whether to close this Renovate PR in favour of #1038, which carries the same eslint v10 pins together with the required config and reformat.

Duplicate, superseded by #1038. Recommend closing this one once #1038 lands. I have not closed anything.

What I verified:

  • #1038 changes package.json with @antfu/eslint-config 6.7.3 to 10.0.0 and eslint 9.39.5 to 10.15.0, the same pins as this PR and #1024, plus the lockfile, eslint.config.js and the lint:fix reformat.
  • Base main still pins @antfu/eslint-config 6.7.3 and eslint 9.39.5 (package.json:51, package.json:60), so neither bump has landed yet.
  • This PR moves only @antfu/eslint-config while eslint stays at 9.39.5; its test check fails.
  • The two bumps must move together: config 10.x needs eslint 10, and config 6.x accepts only eslint 9. Merging this PR alone cannot go green.

Caveat: #1038 is currently mergeable_state=dirty (needs a rebase on main). Keep this PR open until #1038 merges; then it is a no-op and can be closed. If Renovate reopens the split pair afterwards, grouping eslint with @antfu/eslint-config in the Renovate config would stop that.

Confidence: 3/5 (needs attention) — 2 medium findings

-- hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327

@castrojo

Copy link
Copy Markdown
Contributor

Closed as superseded by #1038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hive:unauthorized no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants