Repository navigation
fix(deps): update dependency js-yaml to v5 - #1037
Conversation
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. ℹ️ Sentinel: informational, author is trusted (allow-listed bot), merge is not blocked. Head
No stage 060-reviewed → 050-review-pending: repo-auto-merge-disabled |
There was a problem hiding this comment.
I checked the js-yaml v5 breaking changes against every call site in this repo. This looks correct to me; CI test (with coverage) is green on 02ca53b.
load()now throws on empty input. All four runtime callers already handle a throw.SectionPicker.vue:52runs insidetry/catch.update-image-versions.js:67goes throughreadGenerated, which catches and returnsundefined(:48-55).wolves-projects.ts:41andwolves-lore-records.ts:186already throw on anything that is not a mapping.loaddefaults toCORE_SCHEMA, so no!!mergeor timestamps. No YAML undersrc/or.github/uses<<:merge keys. No caller checks forDate.public/stream-versions.ymlquotescheckedAt, so it stays a string.- Removed dump options (
forceQuotes,noArrayIndent,quotingType,condenseFlow,styles,replacer). None are used. The only option passed islineWidth: -1(scripts/lib/image-version-audit.js:347-348), and v5 keeps it. - Removed
safeLoad/safeDump/DEFAULT_SCHEMA. Not imported anywhere. Every import is a namedloadordump.
One optional cleanup: js-yaml v5 is written in TypeScript and ships its own types, so @types/js-yaml (package.json:37, still ^4.0.9) is now redundant. It does not break anything, because TypeScript prefers the package's bundled types. Remove it in a follow-up if you like.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
🐝 Superseded regeneration series
Posted once on the newest PR rather than on each of them, so a daily regeneration does not produce a daily comment on every PR in the series. Evidence — identical changed-file set (2 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
Danathar
left a comment
There was a problem hiding this comment.
Approving. Major bump of js-yaml ^4.3.1 → ^5.0.0. Every use in the repo is a named load or dump import (src/data/wolves-projects.ts, src/data/wolves-lore-records.ts, SectionPicker.vue, scripts/update-image-versions.js, scripts/lib/image-version-audit.js and the workflow tests). Both functions still exist in v5. CI passed at this head: typecheck, the full test suite including update-image-versions*.test.ts (which goes through the dump path) and the build. @eslint/eslintrc keeps its own nested js-yaml 4.3.2, which is expected.
The 5.4.0 changelog says scalar style selection changed (for example, whitespace-only strings are now double-quoted). That can change the formatting of YAML that update-image-versions writes, but not the values. Worth knowing if a later content-update PR shows quoting-only diffs.
|
Ready for a human merge: verdict approved @8d219ad, 5/5 checks green, soak 30m0s elapsed. Auto-merge is off for this repo, so a person merges. The hive never approves on your behalf: approve and merge it on GitHub if you accept it. Updated 2026-11-18 16:06 UTC. |
|
Correction: this PR isn't superseded. It updates js-yaml to v5, which no other open PR updates. It only shares |
02ca53b to
dea5239
Compare
Review follow-ups (below
|
dea5239 to
4bfc88b
Compare
Danathar
left a comment
There was a problem hiding this comment.
Re-approving at the rebased head. The change is the same as the one I approved before: js-yaml ^4.3.1 → ^5.0.0, plus @eslint/eslintrc keeping its own nested js-yaml 4.3.2. The code only uses the named load and dump imports, which v5 still has. test, Audit GitHub Actions and wolves-movie-flow pass on this head.
4bfc88b to
8d219ad
Compare
Danathar
left a comment
There was a problem hiding this comment.
Re-approving after Renovate's rebase. The diff is still only js-yaml 4 → 5 in package.json and the lockfile; @eslint/eslintrc keeps its own nested js-yaml 4.3.2. All checks pass on this head.
This PR contains the following updates:
^4.3.1→^5.0.0Release Notes
nodeca/js-yaml (js-yaml)
v5.5.0Compare Source
Changed
argparseto v3.Fixed
,,], and}at the start of block plain scalars, #801.v5.4.3Compare Source
Fixed
line, #802.
v5.4.2Compare Source
Fixed
forceQuotesno longer quotes non-string scalars, #798.v5.4.1Compare Source
Changed
Security
maxTotalMergeKeysto limitCPU usage, #797.
v5.4.0Compare Source
Added
scalarStyleRulesdumper option to customize string formatting.See Scalar styling for details.
Changed
and collection nodes now use
SCALAR_STYLEandCOLLECTION_STYLEvalues;explicit tags use the separate
taggedproperty. Alias nodes now containonly
kindandanchor. This only affects code that directly constructs oredits AST nodes.
sortKeysoption was rewritten using AST mutation to avoidside effects.
loaded values; in particular, whitespace-only strings are now double-quoted.
Fixed
quoteFlowKeysandflowSkipColonSpace,including alias and property-only keys, #786.
1024-character simple-key limit.
needed to preserve trailing newlines.
v5.3.0Compare Source
This release focuses on reworking the documentation and making small
architectural improvements before moving forward.
Added
DUMP_SCHEMA, the default schema used by the dumper.YAMLException.throwAt()for throwing an error at a source position.Changed
EVENT_ID,SCALAR_STYLE,COLLECTION_STYLE, andCHOMPING_MODE, along with their value types. The oldexports are still preserved, but deprecated.
identifymandatory for custom tag definitions. Useidentify: () => falsefor load-only tags.Deprecated
Removed
MERGE_KEYexport (not used anymore after last fixes).Fixed
<<sequence items at merge time, so aliased merge sources arechecked too.
<<outside of a mapping key as the plain string'<<', matchingv4, instead of leaking an internal symbol into the result.
v5.2.3Compare Source
Fixed
!!timestampyears 0000-0099 correctly, #775.unpaired mapping event streams, #784.
parsed AST through
present();dump()and loading are unaffected, #780.v5.2.2Compare Source
Fixed
Security
v5.2.1Compare Source
Fixed
Mapsupport to !!omap (should work whenrealMapTagused)Security
addItem. Regression from v5(usually not critical, because YAML11_SCHEMA is not default anymore).
v5.2.0Compare Source
Added
maxTotalMergeKeys(10000) loader option to limit the total number ofkeys processed by YAML merge (
<<) across oneload()/loadAll()call.maxAliases(-1) loader option to limit the number of YAML aliases perdocument.
Removed
maxMergeSeqLengthreplaced withmaxTotalMergeKeysfor limiting YAML mergeprocessing.
Fixed
1e21)v5.1.0Compare Source
Added
different result value.
Changed
quoteStylenow selects the preferred quote style; use therestored
forceQuotesoption to force quoting non-key strings.v5.0.0Compare Source
Added
JSON_SCHEMAandCORE_SCHEMAwith spec-compliant scalar resolutionrules, and added
YAML11_SCHEMA.realMapTagfor lossless mappings with non-string and complex keys.Object-based mappings now reject complex keys instead of stringifying them.
dump()transformoption for changing the generated AST beforerendering.
dump()optionsseqInlineFirst,flowBracketPadding,flowSkipCommaSpace,flowSkipColonSpace,quoteFlowKeys,quoteStyleandtagBeforeAnchor.test set.
Changed
exports.
CORE_SCHEMA(loader default),JSON_SCHEMA,FAILSAFE_SCHEMA.YAML11_SCHEMA, a combination of all YAML 1.1 tags (YAML 1.1 does notspecify a schema, only "types").
load/dumpdefault behaviour is now specified exactly via schemas:loadusesCORE_SCHEMA, without!!mergeby default.dumpusesYAML11_SCHEMA+CORE_SCHEMAfor the quoting check, toguarantee backward compatibility by default.
!!setis now loaded as a JavaScriptSet.TypeAPI with a tags API. Similar, but more precise andsimpler. See examples for details. Tags can be defined via
defineScalarTag(),defineSequenceTag()anddefineMappingTag(), or as aspread + override of an existing tag.
Schema.extend()toSchema.withTags().markers, block keys, multiline scalars, tag syntax and other things.
load()now throws on empty input instead of returningundefined.js-yaml/browserexport.loadAllsignature with an iterator (still works, but is acandidate for removal).
Removed
safeLoad(),safeLoadAll()andsafeDump()exports.DEFAULT_SCHEMAand the nestedtypesexport.onWarning,legacyandlistener.styles,replacer,noCompatMode,condenseFlow,quotingTypeandforceQuotes. RenamednoArrayIndenttoseqNoIndent.Formatting and representation are now configured through presenter options,
schemas and tag definitions. See migration guide on how to replace.
lib/.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.