Repository navigation
chore(deps): update dependency typescript to v7 - #1029
mergeraptor[bot] wants to merge 1 commit into
Conversation
0b111d3
ℹ️ Sentinel notice — informational; author is trusted (allow-listed bot), merge is not blockedHive flagged this PR (author @mergeraptor[bot], head
Hive did not add the |
There was a problem hiding this comment.
Summary: This automated update moves the website's TypeScript tool (the program that checks the site's code for type mistakes) from version 5.9 to 7.0. Version 7 is a rewrite that no longer offers the programming interface that the site's code-quality checker and Vue page compiler rely on, so this update breaks both. The project's own checks already fail on this exact version of the change. It should not be merged until those tools support TypeScript 7.
What I need from you: Don't merge this yet — close it or tell the update bot to hold TypeScript below 7 for now.
correctness
-
High — code-quality check (lint) crashes under TypeScript 7.
package.json:65pinstypescriptto7.0.2, but@typescript-eslint/typescript-estree8.56.1 declares a peer range of>=4.8.4 <6.0.0(package-lock.json:4036; the copies nested under@antfu/eslint-configallow only<6.1.0). Thetestjob at this head (job 133615319098, head0b111d38) fails innpm run lintwithTypeError: Cannot read properties of undefined (reading 'Cjs')at@typescript-eslint/typescript-estree/dist/create-program/shared.js:59. TypeScript 7's npm package ships a nativetscbinary (thebinblock now lists onlytsc, andtsserveris gone) and none of the JS compiler API that typescript-eslint loads. -
High — Vue type-resolving compile and the build step break. The
wolves-movie-flowjob at this head (job 133615318791) fails with[@vue/compiler-sfc] No fs option provided to compileScript … File system access is required for resolving imported types. The Vue compiler can't load the TypeScript API it needs to resolve imported prop types.npm run buildandnpm run typecheck(package.json:8,package.json:18) also runvue-tsc3.1.3 (package.json:68), which drives the same JS API. Its>=5.0.0peer range (package-lock.json:10598) doesn't exclude 7, so npm won't warn about this. I did not run the build myself, but it runs into the same missing API.
Requested fix (on the base branch, since the bot regenerates this PR): keep TypeScript on the 5.x/6.x line until typescript-eslint, @vue/compiler-sfc and vue-tsc support TypeScript 7. For example, add this rule to the Renovate config:
{ "matchPackageNames": ["typescript"], "allowedVersions": "<7" }Then close this PR.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 1/5 (needs attention) — 2 high findings
— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
🐝 Superseded regeneration series
Posted once on the newest PR rather than on each of them, so a daily regeneration does not produce a daily comment on every PR in the series. Evidence — identical changed-file set (2 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
Danathar
left a comment
There was a problem hiding this comment.
Requesting changes: TypeScript 7 breaks this site's tooling, and the fix has to come from upstream, not from us.
- Lint crashes on load with
TypeError: Cannot read properties of undefined (reading 'Cjs')in @typescript-eslint/typescript-estree (https://github.com/projectbluefin/website/actions/runs/43957356687/job/133615319098). typescript-eslint supports only TypeScript below 6. - The Vue compiler can't build the components:
[@vue/compiler-sfc] No fs option provided to compileScript in non-Node environment(https://github.com/projectbluefin/website/actions/runs/43957356687/job/133615318791). The wolves flow then times out.
Main is green on TypeScript 5.9.3. I suggest closing this PR so Renovate stops proposing 7.x, and revisiting once typescript-eslint and the Vue toolchain support TypeScript 7.
|
Closing, as suggested in my review. TypeScript 7 breaks typescript-eslint (it supports TypeScript below 6.1) and the Vue SFC compiler, and the fix has to come from upstream. Closing this tells Renovate to stop proposing 7.x. We'll revisit once both toolchains support TypeScript 7. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
5.9.3→7.0.2Release Notes
microsoft/TypeScript (typescript)
v7.0.2: TypeScript 7.0.2Compare Source
https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/
This tag was originally released at: https://github.com/microsoft/typescript-go/releases/tag/typescript%2Fv7.0.2
v6.0.3: TypeScript 6.0.3Compare Source
For release notes, check out the release announcement blog post.
Downloads are available on:
v6.0.2: TypeScript 6.0Compare Source
For release notes, check out the release announcement blog post.
Downloads are available on:
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.