Repository navigation
chore(deps): update dependency vue-tsc to v3.3.14 - #1019
Conversation
db7c9f6
ℹ️ Sentinel notice — informational; author is trusted (allow-listed bot), merge is not blockedHive flagged this PR (author @mergeraptor[bot], head
Hive did not add the |
9ab5376 to
431be08
Compare
There was a problem hiding this comment.
The test failure is real and this bump causes it, but the fix is one line in our code. The dependency update itself is fine.
What fails (run 43893726019):
src/components/wolves/WolvesComicReader.vue(1439,7): error TS6133: 'flipViewport' is declared but its value is never read.
main passes CI with vue-tsc 3.1.3 (package.json:68). 3.3.14 is stricter here.
Why it's a valid complaint: on main, flipViewport shows up in exactly two places:
WolvesComicReader.vue:1439:const flipViewport = ref<HTMLElement | null>(null)WolvesComicReader.vue:1508:ref="flipViewport"in the template
Nothing reads flipViewport.value, so the binding exists only to receive the template ref and is never used. The newer vue-tsc no longer counts a string ref="…" as a read of the setup variable.
Suggested fix (in this branch, or in a small PR that lands first):
- delete line 1439, since nothing reads the element. A string
refwith no matching binding just lands in$refs. - or, if the element will be needed later, switch to
const flipViewport = useTemplateRef<HTMLElement>('flipViewport')(Vue ≥ 3.5).
After that, the lockfile change (vue-tsc 3.1.3 → 3.3.14, @volar/* 2.4.23 → 2.4.30, all from registry.npmjs.org with integrity hashes) looks fine to merge.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
|
Not approving yet. The bump is fine, but the newer vue-tsc finds a real unused variable:
|
|
The fix on main is tracked in #1032. |
431be08 to
d90aa35
Compare
There was a problem hiding this comment.
Summary: This automated update moves the website's type-checking tool to a newer version. The newer version is stricter and now rejects one leftover, unused variable in the comic-reader page, so the site's automated checks fail and the update cannot merge yet. The fix is a two-line cleanup on the main branch; the bot will pick it up on its next run.
What I need from you: Apply the two-line cleanup below on the main branch.
Re-review at head d90aa353 (previous review at 431be08f). The delta since then is only the bot rebasing onto main (workflow, renovate.json, other dependency bumps already merged as #1021, #1022, #1026, #1027, #1028, #1002). The PR's own change is still just vue-tsc 3.1.3 → 3.3.14 in package.json / package-lock.json.
correctness
Previous finding is still present: src/components/wolves/WolvesComicReader.vue:1439 declares const flipViewport = ref<HTMLElement | null>(null), and nothing reads it apart from the template ref="flipViewport" at line 1508. vue-tsc 3.3.14 reports 'flipViewport' is declared but its value is never read. Both check runs on this head fail on that one annotation: test → "Run npm run typecheck" (job 134136900167) and copilot-setup-steps → "Verify build" (job 134136861773).
The code is unchanged from main, so the fix belongs on main:
--- a/src/components/wolves/WolvesComicReader.vue
+++ b/src/components/wolves/WolvesComicReader.vue
@@
-// Template refs ────────────────────────────────────────────────────────────
-const flipViewport = ref<HTMLElement | null>(null)
-
@@
<div
- ref="flipViewport"
class="comic-viewport"(If the element ref will be needed later, keep it and use useTemplateRef('flipViewport') at the point it is actually read.)
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.325
d90aa35 to
e85f1ad
Compare
7b90ad2 to
993ac29
Compare
There was a problem hiding this comment.
Summary: This update moves the website's type-checking tool to a newer version. The newer version is stricter and still rejects one existing page component, so the site's automated checks fail and the update cannot merge yet. The rest of the change since our last look is only the lockfile catching up with an unrelated, already-merged test-library update.
What I need from you: Apply the two-line fix below on the main branch; the bot's next run will pick it up.
correctness
- Prior finding: still present at
993ac292. CI jobtest(job 134940171069, head993ac292) fails atnpm run typecheck:src/components/wolves/WolvesComicReader.vue:1439 'flipViewport' is declared but its value is never read.flipViewportappears only at:1439(declaration) and:1508(ref="flipViewport"); no script code reads it (code search finds no other use). vue-tsc 3.3.x no longer counts the templateref=string as a read. The defect is in code this PR carries over frommain, so fix it there. Fix (drop the unused template ref):
-const flipViewport = ref<HTMLElement | null>(null) <div
- ref="flipViewport"
class="comic-viewport"Delta since 7b90ad20: rebase onto dcc63207 (@vue/test-utils 2.5.1 → 2.6.0, already on base) plus the same vue-tsc 3.3.14 lockfile tree (@volar/* 2.4.30, new vscode-languageserver-* dev deps, alien-signals 3.2.1). All entries resolve to registry.npmjs.org and are dev-only. No new issues.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326
993ac29 to
db7c9f6
Compare
There was a problem hiding this comment.
Summary: This update moves the site's Vue type-checking tool to a newer version. The newer tool is stricter, and it still rejects one unused variable in the comic reader component, so the site's automated checks fail and the update cannot merge as it is. The change since the last review only rebased the update onto newer main; it did not touch that problem.
What I need from you: Apply the two-line fix below on main; the bot's next run will then pick it up.
correctness
Previous finding (vue-tsc 3.3.14 fails typecheck on unused flipViewport): still present at db7c9f64.
- Delta since
993ac292is onlypackage.json/package-lock.json(rebase onto the js-yaml v5 bump, #1037).src/components/wolves/WolvesComicReader.vueis unchanged (last touchede5e159cf). - CI job
test(job 135022233630, head_shadb7c9f648c1b3e8bd5aafd65282a39abece82616) fails atnpm run typecheck:
src/components/wolves/WolvesComicReader.vue(1439,7): error TS6133: 'flipViewport' is declared but its value is never read. flipViewportappears only atWolvesComicReader.vue:1439(declaration) and:1508(ref="flipViewport"). No script code reads it, so it is dead.
Fix belongs on main, because this PR copies the file unchanged:
--- a/src/components/wolves/WolvesComicReader.vue
+++ b/src/components/wolves/WolvesComicReader.vue
@@ -1439 @@
-const flipViewport = ref<HTMLElement | null>(null)
@@ -1508 @@
<div
- ref="flipViewport"
class="comic-viewport"Lockfile changes (@volar/* 2.4.23 to 2.4.30, @vue/language-core 3.3.14, new @volar/language-service) all come from registry.npmjs.org with integrity hashes. Nothing suspicious there.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 high finding
— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326
db7c9f6 to
408099c
Compare
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Ready for a human merge: verdict approved The hive never approves on your behalf: approve and merge it on GitHub if you accept it. |
Danathar
left a comment
There was a problem hiding this comment.
Approving at 408099c. This is a Renovate bump of vue-tsc from 3.1.3 to 3.3.14. Only package.json (one line) and package-lock.json change, all 5 checks pass, and the hive's review approved this head. vue-tsc is a dev-only type checker, so it does not ship in the built site.
Note
This PR body was truncated due to platform limits.
This PR contains the following updates:
3.1.3→3.3.14Release Notes
vuejs/language-tools (vue-tsc)
v3.3.14Compare Source
language-core
__VLS_unwrapto keep literal bindings on TS 7.1 (ce6c1de)neverslot props for dynamic slot names in generic components (7957e7f)$eventparameter of inline handlers explicitly (d3b42a1)@ts-nocheckand/// <reference>effective in script setup (c2e2e6f)language-service
html.customDataconfiguration (3961653)typescript-plugin
Contributors: @johnsoncodehk, @lazerg, @ValentinYoushkevich, @so1ve, @WangKepeople
v3.3.13Compare Source
language-core
vscode
registerHookson buggy Node versions (7e0d6c4)Contributors: @KazariEX, @serkodev
v3.3.12Compare Source
language-core
defineModel(1be73b8).value(7ad4a94)vueCompilerOptions.pluginsnow overrides the inherited list instead of being deduplicated on resolve (4fa9e97) (c0e5d2e)component-meta
typescript-plugin
tsc
vscode
Contributors: @johnsoncodehk, @serkodev, @KazariEX, @00200200, @camonunez, @Cherry, @hungateJoseph, @uturnr, @ValentinYoushkevich, @xia-chao
v3.3.11Compare Source
language-core
language-service
component-meta
tsc
vscode
Contributors: @serkodev, @pierreedbrg
v3.3.10Compare Source
language-core
v-foritem type over generic sources (8e78c5d)language-service
typescript-plugin
tsc
vscode
typescript.jsvia--requireto support read-only file systems (0c47258)Contributors: @serkodev, @KazariEX, @lazerg
v3.3.9Compare Source
language-core
language-service
component-meta
getProgramAndFilefree of side effects (c99eb00)workspace
typescript-native-bridge(c4e58ea)Contributors: @KazariEX, @johnsoncodehk, @lazerg, @seanogdev, @valentinpalkovic
v3.3.8Compare Source
language-core
Boundary.startand drop the unmapped string literal key generation branch (894a2aa) (4e343d4)workspace
@typescript/typescript6(1ef7ecb)Contributors: @KazariEX, @liangmiQwQ, @WaldemarEnns
v3.3.7Compare Source
language-core
return(b1a8452)__VLS_StyleScopedClassesto generated types (8023ac4)typescript-plugin
Contributors: @KazariEX, @johnsoncodehk
v3.3.6Compare Source
language-core
.d.tsboundary (bff182a)v-bindparsing behavior (5b450ce)WeakMap(f69712f) (c82592d)allCodeFeatures(5cdf4da)Contributors: @KazariEX, @Holiden
v3.3.5Compare Source
language-core
Contributors: @KazariEX
v3.3.4Compare Source
language-core
htmlAttributesoption (3adbe2c)checkRequiredFallthroughAttributesis enabled (9bc36fc)language-service
typescript-plugin
classandstyleas a boolean property (f80e063)Contributors: @KazariEX, @whysopaul
v3.3.3Compare Source
vscode
workspace
auto-versionworkflow to prevent injection (b51c92d)Contributors: @KazariEX, @arpitjain099
v3.3.2Compare Source
language-core
v-forsources (11b390c)v-bindshorthand identifier skipping with interpolation (4f50ebe)vscode
Contributors: @KazariEX, @kkesidis, @suisanka
v3.3.1Compare Source
language-core
__VLS_unwrapto keep literal bindings on TS 7.1 (ce6c1de)neverslot props for dynamic slot names in generic components (7957e7f)$eventparameter of inline handlers explicitly (d3b42a1)@ts-nocheckand/// <reference>effective in script setup (c2e2e6f)language-service
html.customDataconfiguration (3961653)typescript-plugin
Contributors: @johnsoncodehk, @lazerg, @ValentinYoushkevich, @so1ve, @WangKepeople
v3.3.0Compare Source
language-core
v-ifbranch fragments when collecting single root nodes (6c13831)SfcAPIs toIR(dc941c7)language-service
html.customData(94da05a)=""only for plain boolean props completion edits, and reset to the default data provider after running with the Vue data provider (c224e6a) (55af099)typescript-plugin
vscode
extraFileExtensionsin the tsserverconfigurerequest payload (818226a)Contributors: @KazariEX, @Bomberus
v3.2.9Compare Source
language-core
vscode
workspace
Contributors: @KazariEX, @TRIS-H
v3.2.8Compare Source
language-core
GlobalComponents(e3298b6)language-service
@importnavigation (d1b01ec)typescript-plugin
Contributors: @KazariEX, @Gehbt
v3.2.7Compare Source
component-meta
workspace
Contributors: @ef81sp, @KazariEX
v3.2.6Compare Source
language-core
$slotstype in template correctly withdefineSlots(b04ff1a)v-for(ada2857)language-service
vscode
Contributors: @KazariEX, @ascott18, @ebiryu
v3.2.5Compare Source
language-core
language-service
language-plugin-pug
workspace
pluginsoption (0c4c509) (3ffeab3)Contributors: @baptistejamin, @Dsaquel, @johnsoncodehk, @KazariEX, @liangmiQwQ
v3.2.4Compare Source
language-core
ctx.configand support type annotation via generics (b2d5e31)workspace
Contributors: @ghiscoding, @KazariEX
v3.2.3Compare Source
language-core
defineModelbreaking the AST inlang="js"(a522afa)yield*on strings, and use the builtin method from@vue/sharedto check builtin directives (0aa74d1) (e40f116)typescript-plugin
vscode
<style>and<script>tags (e76cf2e)Contributors: @KazariEX, @serkodev
v3.2.2Compare Source
language-core
v-bindshorthands of special attributes (a5b6635)language-service
=""for boolean props completion edits (f1314ef)typescript-plugin
language-plugin-pug
Contributors: @KazariEX, @johnsoncodehk
v3.2.1Compare Source
language-core
v-for(ad127fc)__VLS_InternalProps(2e0e5e0)language-service
component-meta
optionisfalse(719f1bc)component-type-helpers
Contributors: @johnsoncodehk, @KazariEX, @serkodev
v3.2.0Compare Source
language-core
v-fortype inference (e0fb9e8)v-forkey type withObject.keys(1159f1e)<!-- @strictTemplates -->magic comment (4277ab6)<script src="">(145ee73)createIfBranch(35e2c5a)language-service
component-meta
tagsto slots and exposed (a144b6b)exposed(232665d)component-type-helpers
ComponentTypehelper (19a81d4)typescript-plugin
ts.CompletionEntryData(e768518)vscode
fast-diffwith custom character-by-character alignment algorithm (704b30a)workspace
Contributors: @johnsoncodehk, @serkodev, @aj-dev, @KazariEX
v3.1.8Compare Source
language-core
language-service
typescript-plugin
preferencesandformatOptionsin tsserver (8b9d74c)vscode
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.