Repository navigation
Conversation
vue-tsc 3.3.14 no longer treats a string template ref as a read, so the never-read flipViewport ref fails typecheck with TS6133. Nothing in the script reads it; drop the declaration and the ref attribute. Hive-Run: #1032 Hive-Plan: issue-1032 Hive-Spec: issue-1032#acceptance Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Contributor
Author
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: |
Contributor
|
Ready for a human merge: verdict approved @b581338, 4/4 checks green, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
Contributor
Author
|
Closing as superseded by #1047, which makes the same code change (removes the unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The website's automatic code checks will start failing once a pending tool upgrade lands (#1019, an update to the tool that checks the site's code for type errors). The newer checker flags a leftover, unused piece of code in the Wolves comic reader page. This removes that leftover so the upgrade can go through. Nothing visitors see changes.
Why
vue-tsc 3.3.14 no longer counts a template string
ref="flipViewport"as a read of the script'sconst flipViewport = ref(...), so typecheck fails withTS6133: 'flipViewport' is declared but its value is never read(failing run). No script code reads the ref, so both the declaration and the attribute go. The element, its classes and its styles are untouched, so rendering and behaviour do not change.git grep flipViewportis empty after this change.The validation skill gains one row recording this vue-tsc behaviour, per the repository's self-improvement rule.
After merge
Tick the rebase box on #1019; its typecheck should then pass.
Fixes #1032
— hive: agent=scanner backend=claude model=claude-opus-5-5
🐝 Hive Agent:
contributor| SHA:b581338f