Skip to content

fix(wolves): remove leftover unused code so the code checker upgrade passes - #1039

Closed
Danathar wants to merge 1 commit into
mainfrom
fix/remove-unused-flipviewport-ref
Closed

Danathar wants to merge 1 commit into
mainfrom
fix/remove-unused-flipviewport-ref

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary: The website's automatic code checks will start failing once a pending tool upgrade lands (#1019, an update to the tool that checks the site's code for type errors). The newer checker flags a leftover, unused piece of code in the Wolves comic reader page. This removes that leftover so the upgrade can go through. Nothing visitors see changes.


Why

vue-tsc 3.3.14 no longer counts a template string ref="flipViewport" as a read of the script's const flipViewport = ref(...), so typecheck fails with TS6133: 'flipViewport' is declared but its value is never read (failing run). No script code reads the ref, so both the declaration and the attribute go. The element, its classes and its styles are untouched, so rendering and behaviour do not change.

git grep flipViewport is empty after this change.

The validation skill gains one row recording this vue-tsc behaviour, per the repository's self-improvement rule.

After merge

Tick the rebase box on #1019; its typecheck should then pass.

Fixes #1032

— hive: agent=scanner backend=claude model=claude-opus-5-5


🐝 Hive Agent: contributor | SHA: b581338f

vue-tsc 3.3.14 no longer treats a string template ref as a read, so the
never-read flipViewport ref fails typecheck with TS6133. Nothing in the
script reads it; drop the declaration and the ref attribute.

Hive-Run: #1032
Hive-Plan: issue-1032
Hive-Spec: issue-1032#acceptance
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@Danathar

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Nov 17, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @b581338, 4/4 checks green, soak 30m0s elapsed. Blocked only by role/trusted.

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@Danathar

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #1047, which makes the same code change (removes the unused flipViewport declaration and ref attribute). #1047 is approved and in the merge queue as of 3:30 PM EST. This one carried one extra docs line about template refs and vue-tsc 3.3.14; if it's still wanted, it can go in a small docs-only follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: remove unused flipViewport ref so vue-tsc 3.3.14 passes

1 participant