Repository navigation
fix(wolves): remove unused flipViewport template ref - #1047
Conversation
The `flipViewport` ref in WolvesComicReader.vue is declared and bound to a template element but never read in the script. It is the single shared cause of the `test` check failing across the tracked pull requests: - projectbluefin#1019 (vue-tsc 3.3.14) reports TS6133 "'flipViewport' is declared but its value is never read" during typecheck. - projectbluefin#1023 / projectbluefin#1024 (eslint-config / eslint v10) report the same variable as unused during lint. The ref is dead: it appears only at its declaration and its template binding, and no script logic or test reads it. Removing both is a pure dead-code cleanup with no layout, behaviour, or style change. Verified: `npm run typecheck` (including with vue-tsc 3.3.14), `npm run lint`, and `npm run build` all pass on this branch. Hive-Run: projectbluefin#1046 Hive-Plan: Fix the shared `test`-check failure by removing the dead `flipViewport` template ref in src/components/wolves/WolvesComicReader.vue, which is the one code defect surfaced by the vue-tsc 3.3.14 typecheck (projectbluefin#1019) and the eslint v10 lint (projectbluefin#1023, projectbluefin#1024). Base branch: main. Hive-Spec: typecheck, lint, and build all pass locally; the removed ref must not be read anywhere in the component or its tests. Closes projectbluefin#1046 Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
There was a problem hiding this comment.
Decision needed: @castrojo should decide whether to close website#1047 as a duplicate of website#1039 (same flipViewport removal; #1039 is earlier and also documents the vue-tsc change).
This duplicates #1039, which makes the same code change to src/components/wolves/WolvesComicReader.vue. I recommend closing this one in favour of #1039. I have not closed anything.
What I compared (both diffs read in full, and main at cb393e2):
- Both PRs delete the same two things: the
// Template refscomment withconst flipViewport = ref<HTMLElement | null>(null)(currentlyWolvesComicReader.vue:1438-1439onmain), and theref="flipViewport"attribute on the.comic-viewportdiv (currently:1508). The hunks match line for line. Only the offsets differ, because the two branches are based on differentmaincommits. grep -rn flipViewport src/onmainfinds only those two lines. Removing both is correct, and both PRs do that.- #1039 also adds one row to
docs/skills/validation/SKILL.mdrecording the vue-tsc 3.3.14 TS6133 behaviour. This PR has nothing beyond the code change.
Why #1039 should be the one that lands: it was opened earlier (2026-11-17), it is a superset of this PR, and it already has a hive review on its current head. The two PRs do not conflict in intent, but they do conflict textually. Whichever merges second will either fail to apply or turn into an empty change.
There is one gap between this PR's description and the queue. The body says this "repairs the one shared code defect that no existing pull request fixes". #1039 was already open and fixes exactly that. (I checked the other part of that claim: #1038's diff does not touch flipViewport, so that part is accurate.)
If this one is closed, #1046 (which this PR Closes) should be closed as a duplicate of #1032. #1039 fixes #1032.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requires a human decision
— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326
|
Needs a decision, not a merge:
Head: verdict requires_human @e950882, 4/4 checks green, soak 3m0s of 30m0s. What to do: a trusted merger approves this head ( Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Danathar
left a comment
There was a problem hiding this comment.
Approving. It removes the unused flipViewport declaration and its ref attribute, and nothing else in the file reads it. That fixes vue-tsc 3.3.14's TS6133 failure. Checks pass on this head. It replaces #1039, which makes the same code change; I'm closing that one.
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Ready for a human merge: verdict requires_human The hive never approves on your behalf: approve and merge it on GitHub if you accept it. |
Summary
The
testcheck is failing on four open pull requests at once: #1009 (tailwindcss), #1019 (vue-tsc), #1023 (eslint-config), and #1024 (eslint). When one check fails on this many pull requests, the cause is usually shared — the base branch, a workflow, a pinned action, or the tooling versions — not any single change.Investigation shows the tracked pull requests fail for three independent reasons:
npm cibecause their branch'spackage.jsonwas bumped butpackage-lock.jsonwas not. That is a lock-file maintenance issue on those branches, not a repo defect.antfu/reasonable-newlineformatting rules. PR chore(deps): update the code-style checker to version 10 and apply its formatting #1038 already reformats the code for the eslint v10 upgrade.src/components/wolves/WolvesComicReader.vue.This pull request repairs the one shared code defect that no existing pull request fixes: the unused
flipViewporttemplate ref. It is the cause of the typecheck failure on #1019 and of the unused-variable lint error on every eslint v10 upgrade (#1023, #1024, and #1038, which bumps eslint to v10 but does not touch this ref). Removing the dead ref makes those checks pass under the newer tooling.What I need from you
main.package-lock.jsonmatchespackage.json(or let Renovate regenerate the lock) before thetestcheck can pass on them.What changed
flipViewportref declaration and its template binding inWolvesComicReader.vue. The ref was never read in the script or the tests, so this is dead-code cleanup with no layout, behaviour, or style change.How I tested this
npm run typecheckpasses, including with vue-tsc 3.3.14 (the version chore(deps): update dependency vue-tsc to v3.3.14 #1019 bumps to).npm run lintpasses with 0 errors.npm run buildsucceeds.Related
— hive: backend=pi model=lemonade/ornith-1.5-35b-a3b-gguf-q6_k
🐝 Hive Agent:
contributor| SHA:e9508824