Skip to content

fix(wolves): remove unused flipViewport template ref - #1047

Merged
Danathar merged 1 commit into
projectbluefin:mainfrom
kylerankin:fix/unused-flipviewport-ref
Nov 18, 2026
Merged

Danathar merged 1 commit into
projectbluefin:mainfrom
kylerankin:fix/unused-flipviewport-ref

Conversation

@kylerankin

Copy link
Copy Markdown
Contributor

Summary

The test check is failing on four open pull requests at once: #1009 (tailwindcss), #1019 (vue-tsc), #1023 (eslint-config), and #1024 (eslint). When one check fails on this many pull requests, the cause is usually shared — the base branch, a workflow, a pinned action, or the tooling versions — not any single change.

Investigation shows the tracked pull requests fail for three independent reasons:

This pull request repairs the one shared code defect that no existing pull request fixes: the unused flipViewport template ref. It is the cause of the typecheck failure on #1019 and of the unused-variable lint error on every eslint v10 upgrade (#1023, #1024, and #1038, which bumps eslint to v10 but does not touch this ref). Removing the dead ref makes those checks pass under the newer tooling.

What I need from you


What changed

  • Removed the flipViewport ref declaration and its template binding in WolvesComicReader.vue. The ref was never read in the script or the tests, so this is dead-code cleanup with no layout, behaviour, or style change.

How I tested this

Related

— hive: backend=pi model=lemonade/ornith-1.5-35b-a3b-gguf-q6_k


🐝 Hive Agent: contributor | SHA: e9508824

The `flipViewport` ref in WolvesComicReader.vue is declared and bound to a
template element but never read in the script. It is the single shared cause
of the `test` check failing across the tracked pull requests:

- projectbluefin#1019 (vue-tsc 3.3.14) reports TS6133 "'flipViewport' is declared but its
  value is never read" during typecheck.
- projectbluefin#1023 / projectbluefin#1024 (eslint-config / eslint v10) report the same variable as
  unused during lint.

The ref is dead: it appears only at its declaration and its template binding,
and no script logic or test reads it. Removing both is a pure dead-code
cleanup with no layout, behaviour, or style change.

Verified: `npm run typecheck` (including with vue-tsc 3.3.14), `npm run lint`,
and `npm run build` all pass on this branch.

Hive-Run: projectbluefin#1046
Hive-Plan: Fix the shared `test`-check failure by removing the dead
`flipViewport` template ref in src/components/wolves/WolvesComicReader.vue,
which is the one code defect surfaced by the vue-tsc 3.3.14 typecheck (projectbluefin#1019)
and the eslint v10 lint (projectbluefin#1023, projectbluefin#1024). Base branch: main.
Hive-Spec: typecheck, lint, and build all pass locally; the removed ref must
not be read anywhere in the component or its tests.
Closes projectbluefin#1046

Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @castrojo should decide whether to close website#1047 as a duplicate of website#1039 (same flipViewport removal; #1039 is earlier and also documents the vue-tsc change).

This duplicates #1039, which makes the same code change to src/components/wolves/WolvesComicReader.vue. I recommend closing this one in favour of #1039. I have not closed anything.

What I compared (both diffs read in full, and main at cb393e2):

  • Both PRs delete the same two things: the // Template refs comment with const flipViewport = ref<HTMLElement | null>(null) (currently WolvesComicReader.vue:1438-1439 on main), and the ref="flipViewport" attribute on the .comic-viewport div (currently :1508). The hunks match line for line. Only the offsets differ, because the two branches are based on different main commits.
  • grep -rn flipViewport src/ on main finds only those two lines. Removing both is correct, and both PRs do that.
  • #1039 also adds one row to docs/skills/validation/SKILL.md recording the vue-tsc 3.3.14 TS6133 behaviour. This PR has nothing beyond the code change.

Why #1039 should be the one that lands: it was opened earlier (2026-11-17), it is a superset of this PR, and it already has a hive review on its current head. The two PRs do not conflict in intent, but they do conflict textually. Whichever merges second will either fail to apply or turn into an empty change.

There is one gap between this PR's description and the queue. The body says this "repairs the one shared code defect that no existing pull request fixes". #1039 was already open and fixes exactly that. (I checked the other part of that claim: #1038's diff does not touch flipViewport, so that part is accurate.)

If this one is closed, #1046 (which this PR Closes) should be closed as a duplicate of #1032. #1039 fixes #1032.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requires a human decision

— hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.326

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @e950882
  • the review found: the security review withheld approval: Dead-code removal in a Vue component; no trust surface touched.
  • reviewer question: @castrojo should decide whether to close website#1047 as a duplicate of website#1039 (same flipViewport removal; fix(wolves): remove leftover unused code so the code checker upgrade passes #1039 is earlier and also documents the vue-tsc change).
  • the automerge lane will not merge this unattended

Head: verdict requires_human @e950882, 4/4 checks green, soak 3m0s of 30m0s.

What to do: a trusted merger approves this head (e950882) — a GitHub Approve review, or a /hive approve reply posted after the verdict — and the hive re-evaluates on its next pass; the PR author cannot release their own PR, and the hive does not push to a PR it did not open.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. It removes the unused flipViewport declaration and its ref attribute, and nothing else in the file reads it. That fixes vue-tsc 3.3.14's TS6133 failure. Checks pass on this head. It replaces #1039, which makes the same code change; I'm closing that one.

@Danathar
Danathar added this pull request to the merge queue Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Ready for a human merge: verdict requires_human e950882, approved by Danathar, 4/4 checks green, soak 30m0s elapsed. A reviewer asked for a person to merge this one.

The hive never approves on your behalf: approve and merge it on GitHub if you accept it.

Merged via the queue into projectbluefin:main with commit 83b70b3 Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shared-ci] test failing across projectbluefin/website

2 participants