Repository navigation
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
CI report: golangci-lint fails with 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
|
@Karibhou the hive has adopted this PR ( |
There was a problem hiding this comment.
Docs-currency review at head 4bcf4dc. The PR updates agent-configuration.md, github-write-surface.md, api-reference, openapi.json, hive.yaml.example and the changelog well, but two operator-facing pages still describe the old behaviour.
- Stale operator reference —
src/docs/operator-reference/README.md:257(project.reference_repos[].write) still says the credential is the App installation on the target org, that "the hive owner cannot install it", and "For a hand-written entry on an org without one, setwrite_token_file". Line 259 (derived entries) says "the credential is the App installation on the requesting org". Neither mentions the owner's connected account orbot/bot_only/owner(the code and agent-configuration.md now do), and there is no row forproject.remote_write_identity. This is the page the repo's config docs point to for field defaults, so operators will not learn the new key or the default change from it. - GET row not updated —
src/docs/api-reference/configuration.md:~104(GET /api/config/reference-repos) does not list the new response fieldsremote_write_identity,remote_write_identities,bot_login(these are in openapi.json in this diff).
Suggested fix (README.md, after line 258) — add a row, and replace the credential sentences in 257/259:
+| `project.remote_write_identity` | `bot` | Who write-tier reference repos are written as ([#18516](https://github.com/hivecommons/hive/issues/18516)): `bot` = the hive's App bot where the repo's owner already installed it, else the owner's connected account, else read-only; `bot_only` = App bot or read-only, never the owner's token; `owner` = the owner's connected account. Set in Settings → Repos → Reference repos (`PUT /api/config/remote-write-identity`). See [agent-configuration](../agent-configuration.md#reference-repos). |and in the GET row add: plus remote_write_identity, remote_write_identities and bot_login.
— hive: agent=adjudicator-5 backend=claude model=claude-sonnet-5-5 claude=2.1.325
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Security review (head 4bcf4dc) — one in-scope finding; the rest of the credential path looked sound. 1. Bot push is bounded only by "not the default branch" —
|
|
The hive adopted this PR ( Blocker: the hive tried to re-home this PR onto Moving to |
|
Supersede failed: the hive could not open a fresh PR with these commits. Merging Files changed on both sides:
Rebase this branch onto |
- Build on the merged hivecommons#18521 backend and expose identity and provenance in Settings. - Serialize setting changes with reference-repo re-resolution. Co-authored-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
22fbee6 to
15f4b10
Compare
…hanges Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
Follow-up on the return notice: |
|
Scanner CI triage (fork PR, so comment only). Fixes for the failing checks:
🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
|
Follow-up on the return notice and the scanner triage: both refer to superseded heads (15f4b10 / 744c257). On the current head 56ea101, |
|
@clubanderson your change request is addressed at head 56ea101 (based on v5 at 2c785d7). The PR now only contains the Settings, API and docs part of #18516, as you asked. Could you take another look?
The 'returned to contributor' notice refers to the superseded head 15f4b10. On 56ea101, Not verified: the Settings control against a live authenticated API. |
|
Thank you for the work here, Karibhou, and for picking up #18516 so quickly. The owner chose to land the Settings layer as #18603. It sits on top of the backend already merged in #18521 and adds only the control, the API route and the docs, with the agreed three-way text. A review of #18603 would be very welcome, especially anything your branch handles better. I'm leaving it to you whether to close this PR or carry a specific improvement over as a follow-up. |
|
Thanks @clubanderson, understood. #18603 carries the Settings layer on top of #18521, so I am closing this PR rather than keeping a competing version open. Anything specific from this branch can go in as a separate follow-up. |
Scope
Settings, API and documentation for the second part of #18516, based on the backend merged in #18521. Reuses the Settings implementation offered in
feat/remote-write-identity-ui; the existing resolver, grant semantics, proxy and remote-item poller remain unchanged.Verification
go test ./pkg/dashboard ./cmd/hive -run 'ReferenceRepo|RemoteWriteIdentity'node --test pkg/dashboard/reference_repos_editor.test.jspython3 src/scripts/check-docs-links.py src/docsbash src/scripts/check-changelog-fragment.sh v5Refs #18516