Repository navigation
✨ Show why a calendar-email proof failed on its Settings row - #18584
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 2 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
5 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
ℹ️ 11 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first
Verdict: |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Record a failure summary on the entry (reason code, time, SPF, DKIM, alignment and domains, never message content), expose it as last_failure in the calendar-emails API with a plain-language message and remedy, and render it on the row with a Check again button. Expired codes are now recognized and reported as expired. Unknown-code proof attempts are kept, masked, for the owner as recent_proof_attempts. Fixes #18579 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
… UI test Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
18fe01e to
448fe2d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #18579
What
A calendar email whose proof mail was refused used to show only "pending". Now its row says why.
Store.ProveAuth(code, wire.Auth)stores aLastFailuresummary on the entry: the reason code (not_aligned,from_mismatch,expired), the attempt time, and the SPF result and domain, the DKIM results (capped at 5), the DMARC result, the aligned flags and the From domain. It never stores message content.Provebecomes a thin wrapper. An expired code is now recognized and recorded asexpired; before this change it was reported as an unknown code. A code that matches no entry is kept, with the sender masked (a***@example.com), in a bounded in-memory list (RecentAttempts, 20 entries) with the reason "code not recognized". Re-adding an address or a successful proof clears the summary.GET /api/meetings/calendar-emailsreturnslast_failureon unproven rows: the summary plusmessage, the plain-language reason with the remedy text from the issue. A verified owner also getsrecent_proof_attempts. The proof handler logs the reason code.src/docs/meetings.md(reason table, what is kept, recent attempts),src/docs/api-reference/knowledge.md,dashboard/openapi.json, and a changelog fragment.No
src/pkg/mailinfiles changed:wire.Authalready carries everything the summary needs.Tests
mailallow: each reason (not aligned, from mismatch, expired), the auth summary fields, the DKIM cap, persistence, clearing on success and on re-add, the bounded and newest-first recent attempts, andMaskEmail.dashboard: each reason through the relayed proof endpoint and onto the list API, plus the JSON field names. Unknown-code attempts are visible to the owner only. Also covers theproofFailureMessagefallbacks.meeting_attendee_ui_test.go): the reason, the auth summary, Check again, the owner's recent attempts and the fallbacks.🤖 Generated with Claude Code