Repository navigation
π hive never applies hold itself: gates use ready-for-review / decision-needed - #18542
Conversation
β¦on-needed (#18468) A hold placed by a person still means hands-off: the hive never implements, decomposes, relays or merges a held item and never removes the label. The hive's own gates no longer overload hold: - ACMM level gate (and cross-repo outreach) -> ready-for-review - #5117 self-authorization, #9665 reporter trust, holdguard re-hold, owner-only delegated decision -> decision-needed - SHA-hold sweep -> needs-sha for every reporter Both gate labels block merges exactly like hold (exact-match members of the hold set), are created with descriptions saying who acts next, are reserved from agents, and are renameable via governor.labels.ready_for_review / decision_needed. A boot migration swaps hold for the gate label only when the newest hold event is the App's and an App-authored gate notice is on the thread; every other hold is left alone. Fixes #18468 Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
@nate-double-u FYI, this addresses #18468 (hold label overloaded): hive no longer applies |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testingβ±οΈ The 900s mutation budget ran out, so 3 package(s) were not fully mutated and the results below do not cover them:
1 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Evidence bundle `#1854222c2d04` sha256:0a5c8ded62955ec83da256ae94e2e6304e1e009996710bfa851283ce0c358902 β download from the dashboard or `hivectl review evidence #18542`.Review findings from This changes merge-gating label policy, which is a trust surface, so I am routing rather than approving. What I read in the diff:
I did not verify the migration's "newest The change itself looks consistent with the stated intent and ships tests and docs. |
7a0e13d
βΉοΈ Sentinel notice β informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 22c2d04. |
There was a problem hiding this comment.
Decision needed: @clubanderson please confirm, on this exact head, that ready-for-review and decision-needed should block merging exactly like hold across the automerge sweeps, holdguard and the migration.
This changes which labels block merges (merge policy, a trust surface), so I am routing it rather than approving.
What I read and found consistent:
src/pkg/github/hive_gate_label_migration.go: the boot migration relabels aholdonly when the latest label event is by the App and a gate notice exists; a person'sholdis skipped, and the write goes throughWritebackAllowed. A failure leaves the oldholdin place, which still blocks.src/cmd/hive/merge_eligibility.go:778: the newIsHiveGateLabelcase reportslabel:hold. The existingContains(lower, "hold")case runs first and does not match either new label, so there is no shadowing. The look-alikenot-ready-for-reviewis covered byhive_gate_labels_18468_test.go.
Not verified: the other ~65 files (delegatedecision, the stagelabels and dashboard bands, the eight policy templates). The scope matches #18468, so this is a confirmation request, not a defect report.
β hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325
β¦8563) * π needs-sha keeps hive off an issue until the reporter adds a SHA After #18542 the SHA-hold sweep only applies needs-sha, which did not block agent work, so with reporter trust disabled those issues became workable. needs-sha (configured name or default) now sidelines the issue in enumeration and webhook classification until the sweep removes it. Signed-off-by: Andy Anderson <andy@clubanderson.com> * π refresh scale-envelope citation after client.go shift Signed-off-by: Andy Anderson <andy@clubanderson.com>
Fixes #18468
Why
holdmeans "do not merge / do not act" in most projects, but the hive also applied it whenever one of its own gates needed a person, so a hive-labeledholdPR did not say whether the hive was still working, waiting on review, or waiting on a decision. Aholda person adds keeps its meaning exactly: hands-off, the hive never implements, decomposes, relays or merges a held item, and never removes the label.What changes
The hive no longer applies
holdanywhere. Its gates use two self-explanatory labels instead, each blocking merges exactly likehold:ready-for-reviewdecision-neededneeds-human), holdguard re-hold, owner-only delegated decision (withneeds-owner)The SHA-hold sweep now gives every reporter
needs-sha(it already did for trusted reporters) instead ofhold; an untrusted reporter's issue stays out of automatic work through the reporter-trust gate.Write sites changed (previously literal
hold):pkg/github/pr_request_watcher.go(level gate, π bug: an agent files an issue proposing a direction, then implements it with no human sign-offΒ #5117, reporter trust viareporterTrustHoldLabels)cmd/hive/main_helpers.go+pkg/holdguard(ReHoldLabel)pkg/delegatedecision(owner-only decision, LLM addable labels)pkg/github/client.go(SHA-hold sweep;hold()removed)Release paths now act only on the gate label, never on
hold: level-hold release (ReleaseLevelHoldsOnce/PendingLevelHolds), #5117 disabled-policy release, self-imposed reporter-trust release.Merge-gate semantics: the gate labels are exact-match members of the hold set (
HasHoldLabelWith, soisHeld, enumeration, every automerge sweep, holdguard lift detection),automergeBlockLabelReasonreports them aslabel:hold,stagelabels.HoldLabelsroutes them as gates, the dashboard bands count them as held, the delegate's hold rail readsdecision-needed, and the agent label relay reserves both.Comments: each gate already posts its notice; the notices now name the gate label. No new per-item comments except the one-time migration note below.
Migration
On boot, per active repo (bounded to 50 items per repo per boot, off the boot path): create both labels with their descriptions, then for each open item carrying literal
hold, swap it for the gate label only when the newestholdevent is alabeledby the Hive App and an App-authored gate notice is on the thread (level notice ->ready-for-review; reporter-trust / #5117 / holdguard / owner-only notice ->decision-needed). The gate label is added beforeholdis removed, and one<!-- hive:hold-relabel-18468 -->comment explains the swap. A human-applied or human-re-appliedhold, or aholdthe hive cannot attribute, is never touched.Config
governor.labels.ready_for_review(defaultready-for-review) andgovernor.labels.decision_needed(defaultdecision-needed); blank orholdkeeps the default. Allowlisted as yaml-only in the settings parity list; documented inhive.yaml.example.Docs
src/docs/labels-and-control-signals/{reference,glossary-and-operations}.md,src/docs/hive-open-pr.md, hold-gated policy templates (source and embedded copies), changelog fragment.Tests
pkg/github/hive_gate_labels_test.go: gate labels block likeholdwith exact matching;holdcan never be configured as a gate label; agents cannot set them; descriptions name the next actor; a person'sholdis never a pending level hold; migration relabels only App-provenance + notice holds and leaves human, unattributed and forged-notice holds untouched.pkg/delegatedecision/hold_label_18468_test.go: owner-only addsdecision-needed, neverhold; the hold rail still refuses all action onhold; the delegate never lifts either.cmd/hive/hive_gate_labels_18468_test.go,pkg/config/hive_gate_labels_18468_test.go, and updated watcher / level-hold / reporter-trust / self-authorization / SHA-hold fixtures (watcher test now fails ifholdis ever applied).π€ Generated with Claude Code