Skip to content

πŸ› Meetings: consent posted only on a confirmed delivery; speak it or leave - #18594

Merged
kubestellar-prow[bot] merged 2 commits into
v5from
fix/18590-consent-confirmed
Nov 17, 2026
Merged

kubestellar-prow[bot] merged 2 commits into
v5from
fix/18590-consent-confirmed

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Part of #18590 (finding 11).

Problem

In the live Teams test the bot could not open the meeting chat (chat_send_failed reason=no_composer, chat closed to anonymous guests), yet hive set consent_posted_at and kept listening. Quorum's chat.post answered as soon as Vexa accepted the line, and hive took a nil error as "posted".

Change

  • meetings.Client.ChatPostConfirmed calls chat.post {confirm:true} (πŸ› chat.post confirm: report whether the line reached the meeting (0.2.2)Β quorum#30, v0.2.2) and reports delivery == "confirmed". A Quorum that answers no delivery (older than 0.2.2) is not confirmed.
  • Manager.ensureConsent:
    • chat confirmed: consent_posted_at set, consent_via: "chat".
    • chat failed (platform_unavailable, e.g. no_composer) or unconfirmed: if the meeting has voice (voice_capable && voice_enabled), Betty speaks the notice via say; on success consent_via: "voice".
    • neither works: hive leaves at once (meeting.leave), state ended, reason consent_undelivered, consent_error says why (e.g. chat unavailable (...), voice off). If the leave call itself fails the meeting is still marked ended so nothing else is said.
    • transient failures (not_live while the bot is being admitted, rate_limited, a dropped call) are retried on later events, at most ConsentAttempts (default 3) times, then handled as undeliverable.
    • In-process fakes that do not implement the confirming call keep the old behaviour, so unrelated tests are unchanged.
  • Meetings panel: an ended meeting with consent_undelivered reads "Left: the consent notice could not be delivered (chat unavailable (...), voice off)."; a notice delivered by voice shows "consent notice spoken: the meeting chat could not deliver it". The "consent notice not posted yet" line only shows while the meeting is active.
  • Image: QUORUM_VERSION v0.2.1 -> v0.2.2, QUORUM_SHA256 from the release's quorum.mjs.sha256 (davey unchanged at 0.1.12).

Tests (CI is the verdict; only gofmt run locally)

  • consent_test.go: chat confirmed; chat fails + voice ok (spoken, no leave, later Say allowed); chat unconfirmed + voice off (leave, reason, error text, nothing spoken); chat fails + voice fails (leave, both reasons); voice capable but turned off before live (leave, nothing spoken); transient failures bounded at 3 attempts then leave; transient then confirmed.
  • client_test.go: ChatPostConfirmed sends confirm:true; confirmed / unconfirmed / legacy (no delivery) / failed send.

πŸ€– Generated with Claude Code

…eak it or leave

In a live Teams test the bot could not open the meeting chat
(chat_send_failed reason=no_composer) yet hive set consent_posted_at, because
Quorum's chat.post answered as soon as Vexa accepted the line.

The consent notice is now posted with chat.post confirm:true (quorum
v0.2.2, bumped in the image) and counts as posted only on delivery
confirmed; an older Quorum that cannot say is treated as not posted. When
chat cannot deliver it and the meeting has voice on, Betty speaks the notice
(consent_via=voice); when neither works she leaves at once with state reason
consent_undelivered and the Meetings panel says why. Transient failures
(not admitted yet, rate limit, dropped call) are retried up to three times.

Part of #18590 (finding 11).

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18576 ✨ Owner-only Send to on model-owned stage-tracker rows same files src/pkg/dashboard/static/index.html
#18603 ✨ Settings: "Post on other projects as" control for remote write identity same files src/pkg/dashboard/static/index.html
#18615 ✨ Meetings: delete finished meetings and stale join requests same files src/pkg/dashboard/static-src/js/meetings.js
src/pkg/dashboard/static/index.html
#18600 πŸ› meetings: log every failed meetings call and keep a failed approval's reason same files src/pkg/dashboard/static-src/js/meetings.js
src/pkg/dashboard/static/index.html
src/pkg/meetings/requests_test.go
#18592 πŸ› Betty closes the loop on deep dives; research agents survive config reloads same files src/pkg/dashboard/static/index.html
#18611 ✨ meetings: desktop companion meetings (/api/companion/*) CONFLICT src/pkg/meetings/client.go
src/pkg/meetings/manager.go
src/pkg/meetings/meeting.go (conflict)

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 2 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/meetings/manager.go 596 CONDITIONALS_BOUNDARY
src/pkg/meetings/manager.go 635 CONDITIONALS_NEGATION

Verdict: lived (#17349).

@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

ℹ️ Sentinel: informational, author is trusted (owner), merge is not blocked. Head 5b5cad6dc237 matched:

  • sensitive_path: changes 1 sensitive path(s) (src/Dockerfile)

No sentinel-alert label was added. The finding is recorded in the dashboard Security tab and /api/sentinel; set sentinel.trusted_authors_block: true to block trusted authors too.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (rest 1/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

TestConsentErrorRecordedAndThrottled encoded the old behaviour (chat
platform_unavailable, no voice: stay and keep listening). The throttle is
now exercised with a transient rate limit, and a new test pins the leave.

Part of #18590 (finding 11).

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 17, 2026
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security perspective, head cce4e84. The change is fail-closed on consent (chat confirmed, else voice, else leave) and the production Client implements ConfirmingChat, so the legacy nil-error path is test-fakes only. One in-scope gap remains. I could not verify the new QUORUM_SHA256 pin against the quorum v0.2.2 release because gh release download is blocked here, so a human should compare it with quorum.mjs.sha256.

β€” hive: agent=adjudicator-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325

lctx, cancel := context.WithTimeout(m.ctx, m.opts.CallTimeout)
defer cancel()
if _, err := m.Leave(lctx, mt.ID, ReasonConsentUndelivered); err != nil {
// The bot may still be in the meeting: record the end anyway so

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Leave fails here (e.g. Quorum unreachable), the bot may still be in the meeting and transcribing, but hive calls stopWatch and finish(... Ended ...). Nothing retries the leave, and the meeting is shown as 'Left', so the participants were never told and the bot keeps listening. Suggest retrying the leave a bounded number of times and recording the failure in ConsentError:

Suggested change
// The bot may still be in the meeting: record the end anyway so
var lerr error
for i := 0; i < 3; i++ {
if _, lerr = m.Leave(lctx, mt.ID, ReasonConsentUndelivered); lerr == nil {
break
}
time.Sleep(time.Second)
}
if lerr != nil {
err := lerr

Then also set x.ConsentError += "; leave failed: " + err.Error() so the panel does not claim a clean departure.

@kubestellar-prow
kubestellar-prow Bot merged commit 43d463e into v5 Nov 17, 2026
103 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/18590-consent-confirmed branch November 17, 2026 03:18
clubanderson added a commit that referenced this pull request Nov 17, 2026
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure
logging and Discord wording, #18595, #18593, #18599, #18591) alongside
meeting delete. Clears consentTries on delete, adds the delete helpers
to the meetings/calendar role-race test harness (server-tests failed
with meetingsFinished is not defined), and refreshes docs citations.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant