Repository navigation
π Meetings: consent posted only on a confirmed delivery; speak it or leave - #18594
Conversation
β¦eak it or leave In a live Teams test the bot could not open the meeting chat (chat_send_failed reason=no_composer) yet hive set consent_posted_at, because Quorum's chat.post answered as soon as Vexa accepted the line. The consent notice is now posted with chat.post confirm:true (quorum v0.2.2, bumped in the image) and counts as posted only on delivery confirmed; an older Quorum that cannot say is treated as not posted. When chat cannot deliver it and the meeting has voice on, Betty speaks the notice (consent_via=voice); when neither works she leaves at once with state reason consent_undelivered and the Meetings panel says why. Transient failures (not admitted yet, rate limit, dropped call) are retried up to three times. Part of #18590 (finding 11). Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 2 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
Verdict: |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. βΉοΈ Sentinel: informational, author is trusted (owner), merge is not blocked. Head
No @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
TestConsentErrorRecordedAndThrottled encoded the old behaviour (chat platform_unavailable, no voice: stay and keep listening). The throttle is now exercised with a transient rate limit, and a new test pins the leave. Part of #18590 (finding 11). Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Security perspective, head cce4e84. The change is fail-closed on consent (chat confirmed, else voice, else leave) and the production Client implements ConfirmingChat, so the legacy nil-error path is test-fakes only. One in-scope gap remains. I could not verify the new QUORUM_SHA256 pin against the quorum v0.2.2 release because gh release download is blocked here, so a human should compare it with quorum.mjs.sha256.
β hive: agent=adjudicator-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325
| lctx, cancel := context.WithTimeout(m.ctx, m.opts.CallTimeout) | ||
| defer cancel() | ||
| if _, err := m.Leave(lctx, mt.ID, ReasonConsentUndelivered); err != nil { | ||
| // The bot may still be in the meeting: record the end anyway so |
There was a problem hiding this comment.
If Leave fails here (e.g. Quorum unreachable), the bot may still be in the meeting and transcribing, but hive calls stopWatch and finish(... Ended ...). Nothing retries the leave, and the meeting is shown as 'Left', so the participants were never told and the bot keeps listening. Suggest retrying the leave a bounded number of times and recording the failure in ConsentError:
| // The bot may still be in the meeting: record the end anyway so | |
| var lerr error | |
| for i := 0; i < 3; i++ { | |
| if _, lerr = m.Leave(lctx, mt.ID, ReasonConsentUndelivered); lerr == nil { | |
| break | |
| } | |
| time.Sleep(time.Second) | |
| } | |
| if lerr != nil { | |
| err := lerr |
Then also set x.ConsentError += "; leave failed: " + err.Error() so the panel does not claim a clean departure.
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure logging and Discord wording, #18595, #18593, #18599, #18591) alongside meeting delete. Clears consentTries on delete, adds the delete helpers to the meetings/calendar role-race test harness (server-tests failed with meetingsFinished is not defined), and refreshes docs citations. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Part of #18590 (finding 11).
Problem
In the live Teams test the bot could not open the meeting chat (
chat_send_failed reason=no_composer, chat closed to anonymous guests), yet hive setconsent_posted_atand kept listening. Quorum'schat.postanswered as soon as Vexa accepted the line, and hive took a nil error as "posted".Change
meetings.Client.ChatPostConfirmedcallschat.post {confirm:true}(π chat.post confirm: report whether the line reached the meeting (0.2.2)Β quorum#30, v0.2.2) and reportsdelivery == "confirmed". A Quorum that answers nodelivery(older than 0.2.2) is not confirmed.Manager.ensureConsent:consent_posted_atset,consent_via: "chat".platform_unavailable, e.g.no_composer) or unconfirmed: if the meeting has voice (voice_capable && voice_enabled), Betty speaks the notice viasay; on successconsent_via: "voice".meeting.leave), stateended, reasonconsent_undelivered,consent_errorsays why (e.g.chat unavailable (...), voice off). If the leave call itself fails the meeting is still marked ended so nothing else is said.not_livewhile the bot is being admitted,rate_limited, a dropped call) are retried on later events, at mostConsentAttempts(default 3) times, then handled as undeliverable.consent_undeliveredreads "Left: the consent notice could not be delivered (chat unavailable (...), voice off)."; a notice delivered by voice shows "consent notice spoken: the meeting chat could not deliver it". The "consent notice not posted yet" line only shows while the meeting is active.QUORUM_VERSIONv0.2.1 -> v0.2.2,QUORUM_SHA256from the release'squorum.mjs.sha256(davey unchanged at 0.1.12).Tests (CI is the verdict; only gofmt run locally)
consent_test.go: chat confirmed; chat fails + voice ok (spoken, no leave, laterSayallowed); chat unconfirmed + voice off (leave, reason, error text, nothing spoken); chat fails + voice fails (leave, both reasons); voice capable but turned off before live (leave, nothing spoken); transient failures bounded at 3 attempts then leave; transient then confirmed.client_test.go:ChatPostConfirmedsendsconfirm:true; confirmed / unconfirmed / legacy (no delivery) / failed send.π€ Generated with Claude Code