Repository navigation
✨ Inbox: delete hive recordings - #18504
Conversation
DELETE /api/inbox/hive-recording/{id} removes a finished recording's
stored audio and chunks, its Knowledge fact (machine transcript), its
transcript record and the Inbox item state. Owners delete any recording,
read-write members only their own, read never; 409 while in progress or
being transcribed. Shared copies are not touched. Audited as
inbox_recording_delete. The Inbox shows 🗑 Delete with an in-page confirm.
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testing1 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…, inbox-item test loads inboxCanDeleteRecording Signed-off-by: Andy Anderson <andy@clubanderson.com>
…ore.Forget and TranscriptStore.Delete Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Adds a way to delete a recording made with ● Record (found missing while live-testing).
Server.
DELETE /api/inbox/hive-recording/{id}(handleInboxRecordingDelete->Service.DeleteRecording):Store.Forget);shares_kept;recorded_by), read never (403); 404 unknown; 409 while in progress (discard from the recorder) or while its transcription is queued/running (checked undertxMuso no job is queued during the delete);inbox_recording_delete(recording, recorded_by, bytes, fact_removed, shares_kept).UI.
🗑 Deleteonhive-recordingitems for owners and the recorder (disabled while transcribing). Confirm uses the in-pagehiveConfirm(no window.confirm): "Delete this recording?" / "This deletes the audio stored on this hive, this Inbox item and its transcript in Knowledge. It cannot be undone." plus, when share history exists, "What was already shared from it (N shares: RFCs, issues, DIBS ideas, spek seeds) stays where it is."Tests.
api_inbox_recordings_delete_test.go: role matrix (anonymous, read, read as the recorder, read-write non-creator -> 403; read-write creator and owner -> 200), audit entry, item gone from the listing, audio dir + fact + transcript record + item state gone, 409 while transcribing leaves everything, 404/409 unknown/in progress.inbox_recording_delete.test.js: visibility and confirm text.Docs: openapi.json, api-reference/knowledge.md, inbox-recording.md.
Companion to #18500 (display fixes); both touch
inbox.js/index.html, whichever lands second gets rebased and regenerated.🤖 Generated with Claude Code