Skip to content

✨ Inbox: delete hive recordings - #18504

Merged
kubestellar-prow[bot] merged 3 commits into
v5from
feat/recording-delete
Nov 16, 2026
Merged

kubestellar-prow[bot] merged 3 commits into
v5from
feat/recording-delete

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Adds a way to delete a recording made with ● Record (found missing while live-testing).

Server. DELETE /api/inbox/hive-recording/{id} (handleInboxRecordingDelete -> Service.DeleteRecording):

  • removes the recording directory (stored audio, leftover chunks, meta.json), its Knowledge fact (the personal-layer fact holding the machine transcript), its transcript record, and the Inbox item state (Store.Forget);
  • does not touch what was already shared from it (RFC, issues, DIBS, spek seeds); the response reports shares_kept;
  • roles: owner deletes any recording, read-write only its own (recorded_by), read never (403); 404 unknown; 409 while in progress (discard from the recorder) or while its transcription is queued/running (checked under txMu so no job is queued during the delete);
  • audited as inbox_recording_delete (recording, recorded_by, bytes, fact_removed, shares_kept).

UI. 🗑 Delete on hive-recording items for owners and the recorder (disabled while transcribing). Confirm uses the in-page hiveConfirm (no window.confirm): "Delete this recording?" / "This deletes the audio stored on this hive, this Inbox item and its transcript in Knowledge. It cannot be undone." plus, when share history exists, "What was already shared from it (N shares: RFCs, issues, DIBS ideas, spek seeds) stays where it is."

Tests. api_inbox_recordings_delete_test.go: role matrix (anonymous, read, read as the recorder, read-write non-creator -> 403; read-write creator and owner -> 200), audit entry, item gone from the listing, audio dir + fact + transcript record + item state gone, 409 while transcribing leaves everything, 404/409 unknown/in progress. inbox_recording_delete.test.js: visibility and confirm text.

Docs: openapi.json, api-reference/knowledge.md, inbox-recording.md.

Companion to #18500 (display fixes); both touch inbox.js/index.html, whichever lands second gets rebased and regenerated.

🤖 Generated with Claude Code

DELETE /api/inbox/hive-recording/{id} removes a finished recording's
stored audio and chunks, its Knowledge fact (machine transcript), its
transcript record and the Inbox item state. Owners delete any recording,
read-write members only their own, read never; 409 while in progress or
being transcribed. Shared copies are not touched. Audited as
inbox_recording_delete. The Inbox shows 🗑 Delete with an in-page confirm.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18523 ✨ Dashboard: Collaborate sidebar group (Inbox, Calendar, Meetings, Sessions) same files src/pkg/dashboard/static/index.html
#18456 ✨ Sentinel: fold informational notices on trusted authors' PRs into the status card same files changelog.d/added-inbox-recording-delete.md
dashboard/openapi.json
dashboard/test/inbox-item.test.js
src/docs/api-reference/knowledge.md
src/docs/inbox-recording.md
src/pkg/dashboard/api_inbox_recordings.go
src/pkg/dashboard/api_inbox_recordings_delete_test.go
src/pkg/dashboard/inbox_recording_delete.test.js
src/pkg/dashboard/static-src/js/inbox.js
src/pkg/dashboard/static/index.html
src/pkg/inbox/recordings.go
src/pkg/inbox/recordings_delete_test.go
src/pkg/inbox/recordingsource.go
src/pkg/inbox/store.go
src/pkg/inbox/transcripts.go
#18527 🐛 dashboard: Meetings and Calendar wait for the role, sit in the layout, and read cleanly same files src/pkg/dashboard/static/index.html
#18528 ✨ meetings: agent-backend model mode with a warm tool-less Claude Code CLI and Settings picker (part 1 of #18517) same files dashboard/openapi.json
src/docs/api-reference/knowledge.md
src/pkg/dashboard/static/index.html
#18536 ✨ feature: choose remote repository write identity same files dashboard/openapi.json
src/pkg/dashboard/static/index.html
#18540 🐛 inference: refresh rotated gateway keys and refuse ignored api_key_file paths same files src/pkg/dashboard/static/index.html
#18505 ✨ Discover agents declared in a managed repo's .hive/agents/ behind owner approval same files dashboard/openapi.json
src/pkg/dashboard/static/index.html

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing

1 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/inbox/recordingsource.go 419 CONDITIONALS_NEGATION

Verdict: uncovered (#17349).

@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • overlayfs-exec-guard

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

…, inbox-item test loads inboxCanDeleteRecording

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…ore.Forget and TranscriptStore.Delete

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 536c91b into v5 Nov 16, 2026
97 of 99 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/recording-delete branch November 16, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant