Repository navigation
π dashboard: Meetings and Calendar wait for the role, sit in the layout, and read cleanly - #18527
Conversation
β¦ut, and read cleanly - Meetings and Calendar rendered their not-allowed notice before /api/role resolved and never re-rendered; they now show a loading state and subscribe to the role listeners gh-auth.js notifies (same contract as the Inbox fix, #18442). A network failure says the hive is unreachable instead of leaving "Loading meetingsβ¦". - Both sections were missing from DASHBOARD_LAYOUT_TEMPLATE. The generated page parses every section outside #hive-dashboard-root and layout.js moves only template sections back, so these two stayed outside the root where --dash-card-padding is undefined: their cards had zero padding. Add them after the Inbox, matching the sidebar order. - Meetings form: link and title fields, then the Voice toggle beside its checkbox and the primary button; Discord disclosure aligned with the form. Meeting rows: title, kc-pill state, platform and time, a plain-language error with the raw error under details. Empty states use empty-dashed. Calendar sub-sections get spacing. Existing tokens and classes only. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
β¦; 24 layout sections Now that both are layout sections, the collapse-defaults classification requires every non-critical section in DASHBOARD_DEFAULT_COLLAPSED_SECTIONS (only for new browsers; existing ones keep their state, and the sidebar expands the section it opens). The stale-layout normalize test counts 24 sections. Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
overlayfs-exec-guard was cancelled mid-build (runner cancel, not a failure); the re-run on the same head a5e7614 passed. All checks are green now. |
β¦shboard (#18562) * π Dashboard: keep the Collaborate sidebar group and place it after Dashboard dashboardSortSidebar re-homed every nav link whose section is in DASHBOARD_LAYOUT_TEMPLATE into #dashboard-section-nav-group. #18527 added calendar-section and meetings-section to the template (inbox-section and sessions-section were already there), so every Collaborate link moved into the Dashboard group and the emptied Collaborate group was hidden. Only links authored in the Dashboard group are now sorted, dragged and re-homed; links in any other named group stay in place. Sidebar reorders only swap the Dashboard sections' slots in the main-page layout, so other sections keep their saved positions. Collaborate now sits between Dashboard and Agents. Adds a node test that renders the real sidebar and layout functions with a saved layout putting the Collaborate sections first. Signed-off-by: Andy Anderson <andy@clubanderson.com> * π Dashboard: assert sidebar reorder against the normalized layout in the Collaborate test Signed-off-by: Andy Anderson <andy@clubanderson.com> --------- Signed-off-by: Andy Anderson <andy@clubanderson.com>
Problems (from the owner's live test of Betty)
GET /api/meetingsanswered 200 for the same session. Both panels ran their first fetch before/api/roleresolved, took the unknown role as not allowed, and never re-rendered. A failed fetch also returned silently, leaving "Loading meetingsβ¦" on screen.Root causes and fixes
meetings.jsandcalendar.jsnow hold a loading state until the role is settled (window._hiveRoleSettledor a known_hiveRole) and register onwindow._hiveRoleListeners, so they fetch and render as soon as gh-auth.js settles the role. A network failure now shows "unreachable right now; retrying" instead of a stuck loading line.calendar-sectionandmeetings-sectionwere missing fromDASHBOARD_LAYOUT_TEMPLATE. The generated page parses every section outside#hive-dashboard-root, and layout.js moves only the template sections back in, so these two stayed outside the root where--dash-card-paddingis undefined: their.dash-cardhad 0 padding (verified in a browser: 0px before, 16px after). They are now in the template after the Inbox, matching the sidebar order. The pinned order tests (dashboard_section_reorder_9062_test.go,webstatic/static_index_test.go) are updated.kc-pillstate (live green, joining blue, failed red), platform and time, a plain-language error, and the raw error under a "details" disclosure. Empty states useempty-dashed. Calendar sub-sections are spaced, and schedule and draft statuses usekc-pill. Only existing tokens and classes are used, with no inline styles or hex values.Tests
dashboard/test/meetings-calendar-role-race.test.js(node:test, runs on the generated page) covers: both sections are in the layout template; nothing is fetched and no not-allowed notice is shown while the role is unknown; an owner role arriving later fetches and renders the join form, calendar and drafts; a read role gets the notices; a network failure does not stay on loading; and the failed Zoom row renders a pill, a friendly line and the raw error under details.The Zoom join failure is fixed separately in hivecommons/quorum#27 (v0.2.1) and the pin bump in #18526.
π€ Generated with Claude Code