Skip to content

πŸ› dashboard: Meetings and Calendar wait for the role, sit in the layout, and read cleanly - #18527

Merged
kubestellar-prow[bot] merged 2 commits into
v5from
fix/meetings-zoom-role-padding
Nov 16, 2026
Merged

kubestellar-prow[bot] merged 2 commits into
v5from
fix/meetings-zoom-role-padding

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Problems (from the owner's live test of Betty)

  1. Role race. For the owner, Meetings showed "Meetings are visible to the hive owner only." and Calendar "The calendar is visible to the hive owner and read-write users." with no join form, while GET /api/meetings answered 200 for the same session. Both panels ran their first fetch before /api/role resolved, took the unknown role as not allowed, and never re-rendered. A failed fetch also returned silently, leaving "Loading meetings…" on screen.
  2. Formatting. Card body flush against the left border; the join form crammed into one row with the Voice label stacked under its checkbox; failed meeting rows showing the raw error as one long line.

Root causes and fixes

  • Role: same class as the Inbox fix (πŸ› dashboard: render the Inbox once the viewer's role is knownΒ #18442). meetings.js and calendar.js now hold a loading state until the role is settled (window._hiveRoleSettled or a known _hiveRole) and register on window._hiveRoleListeners, so they fetch and render as soon as gh-auth.js settles the role. A network failure now shows "unreachable right now; retrying" instead of a stuck loading line.
  • Padding: calendar-section and meetings-section were missing from DASHBOARD_LAYOUT_TEMPLATE. The generated page parses every section outside #hive-dashboard-root, and layout.js moves only the template sections back in, so these two stayed outside the root where --dash-card-padding is undefined: their .dash-card had 0 padding (verified in a browser: 0px before, 16px after). They are now in the template after the Inbox, matching the sidebar order. The pinned order tests (dashboard_section_reorder_9062_test.go, webstatic/static_index_test.go) are updated.
  • Layout: join form = link and title fields, then a row with the Voice toggle (label beside the checkbox) and the primary button, which wraps on narrow widths; the Discord disclosure lines up with the form. Meeting rows = title, kc-pill state (live green, joining blue, failed red), platform and time, a plain-language error, and the raw error under a "details" disclosure. Empty states use empty-dashed. Calendar sub-sections are spaced, and schedule and draft statuses use kc-pill. Only existing tokens and classes are used, with no inline styles or hex values.

Tests

dashboard/test/meetings-calendar-role-race.test.js (node:test, runs on the generated page) covers: both sections are in the layout template; nothing is fetched and no not-allowed notice is shown while the role is unknown; an owner role arriving later fetches and renders the join form, calendar and drafts; a read role gets the notices; a network failure does not stay on loading; and the failed Zoom row renders a pill, a friendly line and the raw error under details.

The Zoom join failure is fixed separately in hivecommons/quorum#27 (v0.2.1) and the pin bump in #18526.

πŸ€– Generated with Claude Code

…ut, and read cleanly

- Meetings and Calendar rendered their not-allowed notice before /api/role
  resolved and never re-rendered; they now show a loading state and
  subscribe to the role listeners gh-auth.js notifies (same contract as the
  Inbox fix, #18442). A network failure says the hive is unreachable instead
  of leaving "Loading meetings…".
- Both sections were missing from DASHBOARD_LAYOUT_TEMPLATE. The generated
  page parses every section outside #hive-dashboard-root and layout.js moves
  only template sections back, so these two stayed outside the root where
  --dash-card-padding is undefined: their cards had zero padding. Add them
  after the Inbox, matching the sidebar order.
- Meetings form: link and title fields, then the Voice toggle beside its
  checkbox and the primary button; Discord disclosure aligned with the form.
  Meeting rows: title, kc-pill state, platform and time, a plain-language
  error with the raw error under details. Empty states use empty-dashed.
  Calendar sub-sections get spacing. Existing tokens and classes only.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18505 ✨ Discover agents declared in a managed repo's .hive/agents/ behind owner approval same files src/pkg/dashboard/static/index.html
#18540 πŸ› inference: refresh rotated gateway keys and refuse ignored api_key_file paths same files src/pkg/dashboard/static/index.html
#18528 ✨ meetings: agent-backend model mode with a warm tool-less Claude Code CLI and Settings picker (part 1 of #18517) same files src/pkg/dashboard/static/index.html
#18536 ✨ feature: choose remote repository write identity same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • overlayfs-exec-guard

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

…; 24 layout sections

Now that both are layout sections, the collapse-defaults classification
requires every non-critical section in DASHBOARD_DEFAULT_COLLAPSED_SECTIONS
(only for new browsers; existing ones keep their state, and the sidebar
expands the section it opens). The stale-layout normalize test counts 24
sections.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2026
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clubanderson

Copy link
Copy Markdown
Member Author

overlayfs-exec-guard was cancelled mid-build (runner cancel, not a failure); the re-run on the same head a5e7614 passed. All checks are green now.

@kubestellar-prow
kubestellar-prow Bot merged commit 6d2a787 into v5 Nov 16, 2026
112 of 120 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/meetings-zoom-role-padding branch November 16, 2026 22:55
kubestellar-prow Bot pushed a commit that referenced this pull request Nov 17, 2026
…shboard (#18562)

* πŸ› Dashboard: keep the Collaborate sidebar group and place it after Dashboard

dashboardSortSidebar re-homed every nav link whose section is in
DASHBOARD_LAYOUT_TEMPLATE into #dashboard-section-nav-group. #18527 added
calendar-section and meetings-section to the template (inbox-section and
sessions-section were already there), so every Collaborate link moved into
the Dashboard group and the emptied Collaborate group was hidden.

Only links authored in the Dashboard group are now sorted, dragged and
re-homed; links in any other named group stay in place. Sidebar reorders
only swap the Dashboard sections' slots in the main-page layout, so other
sections keep their saved positions. Collaborate now sits between Dashboard
and Agents.

Adds a node test that renders the real sidebar and layout functions with a
saved layout putting the Collaborate sections first.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* πŸ› Dashboard: assert sidebar reorder against the normalized layout in the Collaborate test

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant