Repository navigation
⚠️ Retire /api/campaigns, campaign Jam and Recheck - #18407
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testing3 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
a2ca7ac to
254e478
Compare
254e478
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
Remove the campaign API (list/get/resume/release/revise/delete/recheck and every /jam route), campaign Jam, campaign recheck and outward discovery, the spektacular adapter's recheck tick, the recheck delta import and spec-title evidence in stage leases, the Jam evidence in achievements, and the Spek recheck settings. Before anything is gone, boot writes a one-time read-only export of /data/inception/campaigns and campaign-jam.json to /data/exports/campaigns-<date>.tar.gz (0600) and logs its path once; the originals stay in place. runs.spektacular.recheck is still accepted on load, never fails validation, has no effect and logs a deprecation warning once. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
254e478 to
fa079f4
Compare
|
hive/scanner: coverage is red and the branch is 2 commits behind v5 (baseline triage: MERGE_BASE, not a shared incident). This is a human-authored branch so I am not pushing; please merge v5 in (signed off) and re-run. hive/awaiting-ci: held until then. 🐝 Hive Agent: — hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325 |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…the rewrite window The run-detail panel (toggleCampaignRunDetail, renderRunDetailPanel and its source badge) lived only in campaigns.js and was reached only from Campaigns rows, which v5 retired (#18400, #18407). Drop the two static guards that pinned it. The Dockerfile metacopy rewrite list is re-wrapped so hivectl stays inside the window test_hivectl_extraction_contract.sh reads. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Second of three PRs that retire inception Campaigns in favour of Inception (spek) sessions. The first one (#18400) removed the Campaigns tab.
One-time export (runs before anything is gone)
On startup, Hive checks for
/data/inception/campaigns/orcampaign-jam.json. The Jam file lives indata.metrics_dir, falling back todata.logs_dir, thendata.agents_dir, matching the old Jam store. If either exists, Hive writes one read-only tarball:/data/exports/campaigns-<YYYY-MM-DD>.tar.gz0600, directory0700when createdinception/campaigns/<id>/...: each archive'sstate.jsonandwiki/snapshotinception/state.json, when presentcampaign-jam.json: threads, suggestions, polls, decisions, spec revisions and project-sync stateHive logs the path once, at WARN, as
retired campaigns exported. Once anycampaigns-*.tar.gzexists, no new export is written, so restarts stay quiet. A failed export is logged and never blocks boot.The original files are only read. They stay in place for one release, and nothing deletes them. Knowledge facts from past inception runs (the
inception-wikivault and the knowledge store) are separate and untouched.The code is in the new
pkg/campaignexportpackage, with tests. The boot hook is incmd/hive/boot_knowledge_deps.go. The export is documented insrc/docs/inception.md#retired-campaigns-export.Removed
api_campaigns*.go(list, get, resume, release, revise, delete, Jam, Jam live, Jam agents, Jam GitHub Projects sync),campaign_recheck.go,campaign_discovery.go,recheck_discovery.go, and their tests./api/campaignsroutes inapi.go. They are also removed fromdashboard/openapi.json, along with the now-emptyCampaignstag, and fromdocs/api-reference/health-status-events.md.pkg/spektacular/adapter.go.stage_leases.go: the recheck delta import inImportRunPlanand the recheck evidence appended to spec-stage titles.achievements2.go. Jam was the only source of the review role, so Full SDLC Fireteam now needs spec, plan and implement coverage by three distinct actors. Without this change the badge could never be earned.Config: accepted, ignored, never fails
The whole
runs.spektacular.recheckblock existed only for recheck.hive.yamlkeeps loading.WarnDeprecatedSpektacularRechecklogs a one-line deprecation once per process.TestSpektacularRecheckBlockIsAcceptedAndIgnored, pins this with sources the old validator rejected.The
HIVE_JAM_PROJECT_SYNC_URLandHIVE_JAM_PROJECT_SYNC_TOKENenv vars are now unused.Docs
inception.mdgains a "Retired campaigns export" section.spektacular.md: the Jam and Continuous convergence sections are replaced with retirement notes.runs.md,integrations/spektacular.mdanddesign/achievements-2.mdare updated.Next
PR 3 retires the inception API, its watcher and the brainstorm inception mode.
v6
The v5 to v6 top-up carries this change to v6. The v6-only transcript fact-confirmation panel from the old wizard was already removed by an earlier top-up.
🤖 Generated with Claude Code