Skip to content

✨ Inbox: record meeting tab audio with the mic - #18475

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
feat/inbox-recording-tab
Nov 16, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
feat/inbox-recording-tab

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fourth of the "record a meeting directly in hive" PRs (backend #18408, recorder #18422, auto-transcribe #18432). It adds a meeting tab's audio, recorded together with the microphone.

What it adds

  • Microphone and a meeting tab's audio: a new choice in the ● Record dialog.
    • Calls getDisplayMedia({audio: true, video: true}). The user picks the meeting tab and ticks "Share tab audio".
    • The video track is stopped and removed at once.
    • The tab audio is mixed with the microphone through Web Audio (MediaStreamAudioDestinationNode), and MediaRecorder records the mix.
    • The recorder panel shows two level meters, microphone and tab.
  • Chromium only, on a computer: Chrome, Edge, Brave and others. Elsewhere (Safari, Firefox, phones and tablets) the option is hidden and the dialog says why.
  • Missing audio track: when the user shares a window or screen, or does not tick "Share tab audio", the recorder warns and records the microphone only. The same happens when the tab picker is cancelled.
  • Tab sharing stopped: stopping the share from the browser bar keeps the recording going with the microphone only, and shows a warning.
  • Consent: choosing tab audio re-renders the notice so it says that remote participants are captured too and must have been told. It also unticks the acknowledgement, so it must be given again for the new notice. includes_tab_audio is stored with the recording (backend).
  • Permissions-Policy: display-capture=(self) is added only to the dashboard document in src/deploy/nginx.conf. /terminal/ and /api/ get display-capture=(). The existing Permissions-Policy test now pins those values, forbids a wildcard, and checks that display-capture=(self) appears exactly once.
  • Docs (src/docs/inbox-recording.md): "Recording a meeting tab", a browser support matrix, and phone and tablet limits. security-model.md notes the new directive.

Tests

  • JS node:
    • tab-audio support matrix: desktop Chrome and Edge brands yes; Safari, Firefox and Android no, each with a reason; no getDisplayMedia
    • the tab option is hidden where unsupported
    • mic + tab with a fake getDisplayMedia and AudioContext: audio and video requested, the video track stopped and removed, the recorder records the mix, both streams feed it, includes_tab_audio is true, two meters show, and the capture is released on stop
    • missing audio track warning, mic only
    • cancelled picker, mic only
  • Go: Permissions-Policy scope for display-capture.

🤖 Generated with Claude Code

Chromium only: getDisplayMedia({audio, video}) for a tab, video track
dropped, tab audio mixed with the mic through a
MediaStreamAudioDestinationNode, two level meters. The option is hidden
with the reason where tab audio is unsupported; a share without an audio
track warns and records the mic only. The consent notice names remote
participants when tab audio is included. Permissions-Policy gains
display-capture=(self) for the dashboard document only; the test pins
/terminal/ and /api/ closed.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18471 ✨ inbox: mail-in files as email items with an owner approval queue (Betty C2 part 5) same files src/pkg/dashboard/static/index.html

@hivecommons-hive
hivecommons-hive Bot merged commit 4544a43 into v5 Nov 16, 2026
96 of 101 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/inbox-recording-tab branch November 16, 2026 20:05
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#184758d20e5b` sha256:8670ee1ef80f4b44761d6e8d856005266f499770b14a30f4511d36e6709e9de2 — download from the dashboard or `hivectl review evidence #18475`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8d20e5b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant