Repository navigation
✨ Inbox: record meeting tab audio with the mic - #18475
Merged
Merged
Conversation
Chromium only: getDisplayMedia({audio, video}) for a tab, video track
dropped, tab audio mixed with the mic through a
MediaStreamAudioDestinationNode, two level meters. The option is hidden
with the reason where tab audio is unsupported; a share without an audio
track warns and records the mic only. The consent notice names remote
participants when tab audio is included. Permissions-Policy gains
display-capture=(self) for the dashboard document only; the test pins
/terminal/ and /api/ closed.
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Contributor
Contributor
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8d20e5b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of the "record a meeting directly in hive" PRs (backend #18408, recorder #18422, auto-transcribe #18432). It adds a meeting tab's audio, recorded together with the microphone.
What it adds
getDisplayMedia({audio: true, video: true}). The user picks the meeting tab and ticks "Share tab audio".MediaStreamAudioDestinationNode), andMediaRecorderrecords the mix.includes_tab_audiois stored with the recording (backend).display-capture=(self)is added only to the dashboard document insrc/deploy/nginx.conf./terminal/and/api/getdisplay-capture=(). The existing Permissions-Policy test now pins those values, forbids a wildcard, and checks thatdisplay-capture=(self)appears exactly once.src/docs/inbox-recording.md): "Recording a meeting tab", a browser support matrix, and phone and tablet limits.security-model.mdnotes the new directive.Tests
getDisplayMediagetDisplayMediaandAudioContext: audio and video requested, the video track stopped and removed, the recorder records the mix, both streams feed it,includes_tab_audiois true, two meters show, and the capture is released on stopdisplay-capture.🤖 Generated with Claude Code