Repository navigation
✨ Inbox: transcribe first, then share audio-only items - #18401
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Security review (head 1fefa64)
Not verified: the Review findings from Correctness review at head 1fefa64 (src/pkg/inbox/shareintent.go, store.go, transcription.go). 1. A share can run twice when a Sweep lands during the transcription tail (medium, in-scope)
// store.go
func (s *Store) ClaimIntent(key, dest string) bool {
s.mu.Lock(); defer s.mu.Unlock(); s.load()
e := s.entries[key]
if e == nil || e.Intents[dest] == nil || e.Intents[dest].Status != IntentWaiting { return false }
e.Intents[dest].Status = IntentRunning // new const; IntentKeys must still treat it as in flight
_ = s.save()
return true
}In
2. A stale Failed/Skipped record can fail a fresh intent, so the share is lost (medium, in-scope)
- case ok && (rec.Status == TranscriptionFailed || rec.Status == TranscriptionSkipped):
- s.finishIntents(it, rec)
+ case ok && (rec.Status == TranscriptionFailed || rec.Status == TranscriptionSkipped) && !rec.UpdatedAt.Before(oldestWaitingIntent(s.Store.Intents(key))):
+ s.finishIntents(it, rec)
3. Dismiss response over-reports and the share runs on the transcription worker (low, in-scope)
Not verified: whether |
Mutation testing13 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
ℹ️ 1 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first
Verdict: |
6609ae0 to
ff516a3
Compare
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
ff516a3 to
1fefa64
Compare
There was a problem hiding this comment.
HUMAN DECISION NEEDED — Confirm that widening inbox share/dismiss from owner-only to read-write sessions belongs in a "transcribe first, then share" PR. @clubanderson
Reviewed at head 1fefa64 against the PR title and diff, since no linked issue was found. The transcribe-then-share core is in scope and matches the description: shareintent.go implements ShareWhenReady, finishIntents and ResumeIntents, and DIBS still routes directly.
-
Authorization widening (in-scope, needs a human).
src/pkg/dashboard/api_inbox.goreplacesrequireOwnerRolewithrequireInboxShareRoleonhandleInboxRouteandhandleInboxDismiss. Read-write sessions can now push items, including private audio transcripts, to the RFC repo. Before this PR only owners could. The title doesn't mention it, though the PR body does ("Roles:"). The transcribe-first feature doesn't need it. Either confirm the policy change explicitly, or split it into its own PR. -
Bulk dismiss behavior change (in-scope, low).
handleInboxDismissnow callsShareWhenReady, which callsRoute(DestDismiss)for items that have text.Routerunss.handOff(...)in addition toStore.Dismiss(src/pkg/inbox/service.go:277-281). The old bulk path only calledDismiss. Bulk "knowledge only" now triggers a hand-off it never triggered before. Also, aShareWhenReadyerror that isn'tErrTranscribeUnavailablenow aborts the whole batch with a 500 (api_inbox.go, dismiss loop). -
Inconsistent handling when transcription is unavailable (in-scope, low). The PR body says Knowledge is disabled in the UI when transcription is unavailable. The bulk dismiss API instead silently falls back to an immediate
svc.Dismissfor audio-only items. That is the dead-end-free behavior the PR removes elsewhere, and it marks the item knowledge-only without a transcript.
I did not run the tests or the JS/UI changes. My review of inbox.js and index.html was limited to the diff.
— hive: agent=adjudicator-3 backend=claude model=claude-sonnet-5-5 claude=2.1.325
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Choosing RFC…, Knowledge (or, later, spek) from the Inbox 🔗 Share → Hive menu on an item that has audio but no text now transcribes it first and shares when the transcript completes. Audio-only items no longer dead-end on "use 🎧 Transcribe first".
ShareWhenReadystores aShareIntent(destination, actor, repo, short dialog params; never item text or secrets) with the item state, calls the existingTranscribepath (consent, budget, caps honoured) and runs the share fromrunTranscription. Failure or skip marks the intent failed with the reason and sends nothing.ResumeIntents(called fromSweep) resumes intents after a restart. DIBS still routes straight away; items with text share immediately.Service.RegisterIntentRunner("spek", func(ctx, it, ShareIntent) error); the dialog choices travel inShareIntent.Params(the route API acceptsparams). On the UI side add one entry toinboxShareHiveActions. The spek seed endpoint is not on v5 yet, so only RFC and Knowledge are wired.POST /api/inbox/routeand/api/inbox/dismissnow admit owner and read-write (read stays 403); the Hive group and selection are shown to read-write. Settings (auto-routing, dibs URL/token, RFC repo) stay owner-only. Each share is audited with the acting user.🤖 Generated with Claude Code