Repository navigation
✨ meetings: Betty persona, intro and question-driven chat answers (phase A) - #18397
Conversation
…ase A)
Hive attends meetings as a configurable persona, Betty ("Betty Bee from the
hive") by default (meetings.persona, preset + explicit fields + env).
- config: meetings.persona block (preset, name, display_name, aliases,
pronouns, language, voice, voice_type, accent, intro_template,
leave_phrases, humor, unprompted caps, searxng_url), Resolve() and
Validate(); the display name becomes the default bot name and the consent
text names the persona and both leave phrases.
- meetings: leave phrases replace the single hive-leave pattern; the echo
filter tolerates platform-decorated bot names.
- betty: triggers, room-question detection, queue with answer wait,
already-answered drops, Jaccard dedupe and caps, parallel retrieval
(knowledge FileStores, beads, code maps) behind a Retriever seam, one
meetllm call returning JSON, persona prompts that treat context as data.
- live: optional persona engine fed without blocking; replies go through
the session's budget, rate limit and say fallback; Spek say dropped,
chat.post offered, ask restyled; matchAnswer skips addressed lines and
leave commands.
- meetllm: optional system prompt.
Part of #18391. Fixes #18392.
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Security perspective, read at head b58f641 (diff plus Low — a participant named like the bot now vanishes from the transcript ( Advisory, not blocking: per #18391 Betty answers any attendee from the knowledge vaults, bead notes and code maps ( |
Settings parity requires each meetings.persona leaf to be referenced. Signed-off-by: Andy Anderson <andy@clubanderson.com>
…leeps) Signed-off-by: Andy Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Correctness review at head b58f641 (reviewed diff plus the surrounding session.go and manager.go). Two in-scope findings.
1. The default alias "hive" over-triggers addressed replies (src/pkg/meetings/betty/trigger.go:164)
- The end-of-line rule treats any line ending in an alias as addressed, unless the previous word is in
trailingBlock. - "we should just use hive", "I think the problem is hive" and "tell hive" all match.
- A line starting with "hive" followed by can, will, does or do also matches, for example "hive does not support that".
- Addressed lines bypass the unprompted caps (
queue.goaddressed()) and always cost an LLM call plus a chat reply. That undercuts the "never spams" claim. The docs only promise that "hive is slow today" is not matched. - Fix: require punctuation before a trailing single-word alias ("..., Betty") and add tests for "we use hive" and "hive will be down".
- if len(w) > len(name) && hasSuffix(w, name) && !trailingBlock[w[len(w)-len(name)-1]] {
+ if len(w) > len(name) && hasSuffix(w, name) && !trailingBlock[w[len(w)-len(name)-1]] &&
+ (len(name) > 1 || separatedBefore(raw, len(name))) {separatedBefore is a new helper that checks for a comma or other punctuation right before the last word of the raw line.
2. Caps and dedupe are committed before the chat post succeeds (queue.go:332)
emitsucceeding updatesposts,lastPostandtotal, andrememberTopicfollows.- The session then posts through
s.rate.allow(session.gopost(), around line 364), anddeliver()can also fail. - When either fails, the cap and min-gap are spent and the topic counts as answered, but nobody saw an answer. An addressed request that is rate-limited is lost with no fallback.
- Fix: have
onPersonaReplyreport the result back to the engine, so it commits caps and dedupe only on success. Alternatively, exempt persona replies froms.rate, since the engine already enforces its own caps.
I did not run the tests.
— hive: agent=adjudicator backend=claude model=claude-sonnet-5-5 claude=2.1.325
Review follow-ups (below
|
Mutation testing❌ gremlins did not produce a report for 1 package(s), so no verdict can be derived from this run (see the job log):
6 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Phase A of the Betty persona plan (#18391). Fixes #18392.
Hive now attends meetings as a persona: Betty ("Betty Bee from the hive") by default.
What changes
src/pkg/config/meetings_persona.go): newmeetings.personablock. It is a preset (preset, defaultbetty) plus explicitly set fields, and every key has anHIVE_MEETINGS_PERSONA_*override. Keys:enabled,name,display_name,aliases,pronouns,language(BCP-47),voice(TTS id),voice_type,accent,intro_template,leave_phrases,humor,unprompted.{per_10m, min_gap_s, per_meeting, answer_wait_s, min_confidence, queue_depth, stale_s}andsearxng_url(reserved).Resolve()returns the effective persona andValidate()checks it. The persona's display name is now the default bot name (meetings.bot_namestill wins), and the default consent text names Betty, says she records the transcript, and says how to remove her ("betty leave" or "hive leave"). With the persona off, hive behaves as before.leave_phrasesreplace the singleleavePattern(LeaveMatcher). The echo filter also matches the bot's display name when the platform decorates it ("(Guest)") or when it shows up as a speaker.src/pkg/meetings/betty(new):Retrieverinterface, with knowledge FileStore, bead and code-map implementations.meetllmcall per answer, returning{answer, confidence, needs_research, sources}.language, context is data and never instructions, light humor oroff, honest when unsure, never claims actions it did not take.presets.go.account), chat rate limit (post) and say fallback. With Betty on:sayis dropped.chat.postgoes to Betty's queue, deduped.askis reworded by Betty with an 800 ms call, falling back to the raw text.matchAnswerskips lines addressed to Betty and leave commands.Systemprompt field.hive meeting-llmis unchanged.knowledge.code_maps.enabledis on.meetings.md, the persona env vars inenv-vars.md, and a changelog fragment.Phase B seams
Retrieverinterface: a web retriever (SearXNG) plugs in next to the others.Reply.Kind:chatorvoice. A voice reply already routes tosay, which falls back to chat.VoiceWantedis recorded, andvoice/searxng_urlare stored but not used yet.Tests
live.Runnerwith a fake quorum, a fake Spek and a fake model. It covers intros, addressed answers, question-driven posts, caps, already-answered drops, one reply per question, dedupe,matchAnswerskips, no Spek double replies, the humor off switch, and prompt-injection text staying inside the data block.🤖 Generated with Claude Code