Repository navigation
π Light the CI chevron while a part-filled ring is still running - #16632
Conversation
Check-run motion on the head (in_progress, or queued when nothing runs)
now leads every settled word in the required-check path, and the
no-required-set path reads motion too, so the CI chevron is active with
its count beside a running Review instead of an inactive part-green ring.
Red neighbours ride in the running caption ("Β· 1 failing"); icon-only
green is reserved for passed == total. The JS running predicate treats a
partial ring with no settled word as running, except on rows parked on a
person's decision.
Fixes #16631
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from Read Verified
Low β behaviour shift, not a bug
Looks correct to me otherwise. Not a duplicate of #16634 or #16636 β same file, disjoint hunks and different behaviours. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Read stage_tracker_activity.go and tracker-row-strip.js at a45f4a4 against v5. The Go half is sound; the JS inference has one case where it lights a finished ring as "running" indefinitely.
Medium β a head-wide ring with skipped checks reads as running forever (unprotected base).
stageTrackerCountHeadChecksputs every check-run name on the head intoChecksTotal(stage_tracker_activity.go:306) but only bucketsfailingandpassing(:309-316); a run that completedskipped/neutralis intotaland in neither count.- On that path the Go state stays
unknownunless something is actuallyin_progress/queued (stageTrackerHeadChecksMotion,:323-336returns early whenmoving == 0) β correct. - But the new client inference (
tracker-row-strip.js:237-239) decides motion frompassed + failed < totalwithunknownnot insettledWords, and the caption (:73) saysrunningon the same test. So a PR on an unprotected base with, say, 51 passed + 17 skipped matrix jobs β all completed β is lit "CI 51/68 Β· running" with no freshness window, and nothing ever un-lights it. The updated assertion instage_tracker_activity.test.js:782('CI 51/68 Β· running') encodes exactly this input, which has no evidence any check is still executing.
Two ways out, either fine: have Go carry a skipped count (or fold skipped/neutral into done) so the JS arithmetic matches the Go tally, or drop the client-side arithmetic and trust the backend β the Go side already turns the track running whenever a run on the head is genuinely in motion (:323), so the inference only adds the false-positive case. Note the function's own header comment (tracker-row-strip.js:219-223, #16540) says unknown evidence is not motion; this hunk reverses that for the CI track without updating the comment.
Everything else I checked holds up: the required-check path's running/queued override (:181-186) only triggers on an observed in_progress/queued required check, the Β· N failing suffix keeps red names visible, out.Active still respects the 2-minute fresh window, and the #16628-shape test covers the ring-not-full case the issue reports. CI is green on this head (tide pending).
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Fixes #16631
Post-roll screenshot (PR #16628 row): CI chevron inactive with a 13/19 part-green ring and no text while Review was active. A ring that is not full means checks are still running, so CI must be active with its count alongside Review; icon-only green only for a complete ring.
Go (
stage_tracker_activity.go)in_progresson the head forcesrunning(anyqueuedwith nothing running forcesqueued, naming the queued check) β motion leads red / missing / ambiguous neighbours. Running caption carries the red count:CI running Β· 2/3 checks done Β· 1 failing; Detail lists the red names.stageTrackerHeadChecksMotionreads check-run motion head-wide (CI running Β· 13/19 checks done).Active= state running and fresh.JS (
tracker-row-strip.js)stageTrackerTrackRunning: CI withpassed+failed < totaland no settled word (passing/failing/skipped/missing/human_decision) is running β except on rows parked on a person's decision (decision_needed/human_attention), where cached counts are not motion.stageTrackerTrackWord: anunknownpartial ring readsCI 13/19 Β· runningeven off the current column.Tests
TestStageTrackerActivityCIPartialRingIsRunning(13/19 β running/Active; 19/19 β passing/inactive; required-unknown variant); retry/mixed and head-wide count expectations updated.#16628 shapefixture β CI 13/19 (running/unknown/queued) + Review in progress β two active chevrons with words; CI 19/19 β CIdoneicon-only ring, Review the only lit one.make dashboard-gen-check,go vet,go test ./pkg/dashboard/green locally.