Skip to content

πŸ› Light the CI chevron while a part-filled ring is still running - #16632

Merged
clubanderson merged 1 commit into
v5from
fix/ci-ring-partial-running
Nov 4, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/ci-ring-partial-running

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16631

Post-roll screenshot (PR #16628 row): CI chevron inactive with a 13/19 part-green ring and no text while Review was active. A ring that is not full means checks are still running, so CI must be active with its count alongside Review; icon-only green only for a complete ring.

Go (stage_tracker_activity.go)

  • Required-check path: after ranking, any check in_progress on the head forces running (any queued with nothing running forces queued, naming the queued check) β€” motion leads red / missing / ambiguous neighbours. Running caption carries the red count: CI running Β· 2/3 checks done Β· 1 failing; Detail lists the red names.
  • No-required-set paths: new stageTrackerHeadChecksMotion reads check-run motion head-wide (CI running Β· 13/19 checks done).
  • Active = state running and fresh.

JS (tracker-row-strip.js)

  • stageTrackerTrackRunning: CI with passed+failed < total and no settled word (passing/failing/skipped/missing/human_decision) is running β€” except on rows parked on a person's decision (decision_needed / human_attention), where cached counts are not motion.
  • stageTrackerTrackWord: an unknown partial ring reads CI 13/19 Β· running even off the current column.

Tests

  • Go: motion table (red+running, missing+running, ambiguous+queued), TestStageTrackerActivityCIPartialRingIsRunning (13/19 β‡’ running/Active; 19/19 β‡’ passing/inactive; required-unknown variant); retry/mixed and head-wide count expectations updated.
  • Node: #16628 shape fixture β€” CI 13/19 (running/unknown/queued) + Review in progress β‡’ two active chevrons with words; CI 19/19 β‡’ CI done icon-only ring, Review the only lit one.

make dashboard-gen-check, go vet, go test ./pkg/dashboard/ green locally.

Check-run motion on the head (in_progress, or queued when nothing runs)
now leads every settled word in the required-check path, and the
no-required-set path reads motion too, so the CI chevron is active with
its count beside a running Review instead of an inactive part-green ring.
Red neighbours ride in the running caption ("Β· 1 failing"); icon-only
green is reserved for passed == total. The JS running predicate treats a
partial ring with no settled word as running, except on rows parked on a
person's decision.

Fixes #16631

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16621 πŸ› Activity Monitor: base-branch pill sits beside the repo chip same files src/pkg/dashboard/static/index.html
#16615 ✨ feat(ci): approve gated workflows for trusted PR heads same files src/pkg/dashboard/stage_tracker_activity.go
#16619 πŸ› fix(dashboard): preserve settled review verdicts and explain findings same files src/pkg/dashboard/stage_tracker_activity.go
src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/stage_tracker_activity_test.go
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • runtime-tests

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read stage_tracker_activity.go and the consumers of CIActivity.State against v5. The change does what #16631 asks and I found no defect; one knock-on worth knowing about.

Verified

  • Required-check path: the post-rank override (stage_tracker_activity.go:183–188) only fires when a required check is in_progress/queued on the head, so a complete ring still settles on failing/passing/missing as before; Active now follows State == "running" (line 253) rather than the old running flag, which is the same condition after the override.
  • stageTrackerHeadChecksMotion (lines 323–348) filters by check.Head like stageTrackerCountHeadChecks, so an older head's in-progress run cannot animate the current one.
  • JS stageTrackerTrackRunning (tracker-row-strip.js:227–239) bails on decision_needed.question/human_attention before inferring motion from counts, and the settled-word list matches the Go states.
  • stage_tracker_decision_pr.go:235 already checks ChecksFailed > 0 alongside State == "failing", so the decision-option gate is unaffected by a red check now reading running.

Low β€” behaviour shift, not a bug

  • stageTrackerRedSince (stage_tracker_remediation.go:61) keys only on a.State == "failing". With this PR a head that has one red required check while others still run reports running, so a 07x row's red-since word falls back from "CI failing" (with the check's Since) to the stage-entry word until the ring completes. Probably acceptable β€” motion leads by design here β€” but if the "red since" timestamp matters for the remediation lead, that line could also accept ChecksFailed > 0 as decision_pr.go does.

Looks correct to me otherwise. Not a duplicate of #16634 or #16636 β€” same file, disjoint hunks and different behaviours.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read stage_tracker_activity.go and tracker-row-strip.js at a45f4a4 against v5. The Go half is sound; the JS inference has one case where it lights a finished ring as "running" indefinitely.

Medium β€” a head-wide ring with skipped checks reads as running forever (unprotected base).

  • stageTrackerCountHeadChecks puts every check-run name on the head into ChecksTotal (stage_tracker_activity.go:306) but only buckets failing and passing (:309-316); a run that completed skipped/neutral is in total and in neither count.
  • On that path the Go state stays unknown unless something is actually in_progress/queued (stageTrackerHeadChecksMotion, :323-336 returns early when moving == 0) β€” correct.
  • But the new client inference (tracker-row-strip.js:237-239) decides motion from passed + failed < total with unknown not in settledWords, and the caption (:73) says running on the same test. So a PR on an unprotected base with, say, 51 passed + 17 skipped matrix jobs β€” all completed β€” is lit "CI 51/68 Β· running" with no freshness window, and nothing ever un-lights it. The updated assertion in stage_tracker_activity.test.js:782 ('CI 51/68 Β· running') encodes exactly this input, which has no evidence any check is still executing.

Two ways out, either fine: have Go carry a skipped count (or fold skipped/neutral into done) so the JS arithmetic matches the Go tally, or drop the client-side arithmetic and trust the backend β€” the Go side already turns the track running whenever a run on the head is genuinely in motion (:323), so the inference only adds the false-positive case. Note the function's own header comment (tracker-row-strip.js:219-223, #16540) says unknown evidence is not motion; this hunk reverses that for the CI track without updating the comment.

Everything else I checked holds up: the required-check path's running/queued override (:181-186) only triggers on an observed in_progress/queued required check, the Β· N failing suffix keeps red names visible, out.Active still respects the 2-minute fresh window, and the #16628-shape test covers the ring-not-full case the issue reports. CI is green on this head (tide pending).

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› CI chevron stays icon-only with a partly filled ring while checks are still running

1 participant