Skip to content

🐛 fix(dashboard): preserve settled review verdicts and explain findings - #16634

Closed
hivecommons-hive[bot] wants to merge 13 commits into
v5from
hive/adopt-16619
Closed

hivecommons-hive[bot] wants to merge 13 commits into
v5from
hive/adopt-16619

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #16619 (adopted in place, re-homed because a hive commit on the contributor branch cannot carry a squash-safe sign-off; original commits by @thatguywob preserved).

Closes #16617

This branch is #16619's head 598099676c55 as pushed by @thatguywob (fork thatguywob/hive), unchanged. Last lane reason on the original: reviewer-verdict:changes_requested.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Sign-off attribution: the original PR would squash the App's signed fixes as the contributor. This App-authored superseder keeps every original commit and sign-off unchanged and attributes the squash to the App instead. DCO and all merge gates still apply here.

thatguywob and others added 5 commits November 4, 2026 16:43
Keep review and CI verdicts known as observations age, and expose current-head perspective findings in review captions and tooltips.

Hive-Run: #16617
Hive-Plan: activity-monitor-review-verdict
Hive-Spec: #16617#fix
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Keep current-phase and filled active-lane assertions, while checking inactive CI/Review lanes for their state icon and accessible count words after the chevron update.

Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Resolve tracker-header-geometry.js in favour of v5 (#16625 restored a visible fill on every current-phase track, superseding the icon-only probe relaxation) and regenerate static/index.html.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…view states

Addresses the review-swarm findings on #16619:

- Production esc() flattens newlines to spaces, so escaping the whole
  tooltip before substituting <br> never produced line breaks. Split the
  tooltip into lines first, escape each, then join with <br>. The JS test
  stub esc() now mirrors production so the test exercises the real path.
- The known rule deny-listed moving states, leaving unassigned and
  waiting_ci (emitted by v5) known forever once stale. Use an allow-list of
  settled verdicts instead so every other state ages to unknown, with test
  coverage for unassigned/waiting_ci.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16615 ✨ feat(ci): approve gated workflows for trusted PR heads same files src/pkg/dashboard/stage_tracker_activity.go
#16659 🐛 Activity Monitor: celebrate externally merged PRs with bee + toast naming the merger same files src/pkg/dashboard/static/index.html
#16637 🐛 Stage tracker: say CI running (not activity unknown) when checks are still pending same files src/pkg/dashboard/stage_tracker_activity.go
src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/stage_tracker_activity_test.go
src/pkg/dashboard/stage_tracker_motion_test.go
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16660 🐛 fix: label narrow dashboard navigation same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read stage_tracker_activity.go, evidence.Verdict/Finding, and static-src/js/tracker-row-strip.js against v5. The change looks correct to me; the one thing standing in its way is a merge conflict, not the code.

Verified

  • trackerReviewPerspectives (stage_tracker_activity.go:452–481) is order-independent: an approve is replaced by any current non-approve, a non-approve is never replaced by an approve, and ties within a class go to the newer RecordedAt. It consumes trackerLatestBundleVerdicts (line 432), which already collapses per (perspective, backend, model), so a reviewer who changes their own mind still gets latest-wins while dissent from a different backend persists — exactly what the test at stage_tracker_activity_test.go:491 asserts with the old/new/z backends.
  • The Go caption suffix (name ✗: summary, lines 684–698) and the JS perspectiveLine (tracker-row-strip.js:257) produce byte-identical strings, so the caption.includes(...) dedup at line 262 holds and the finding is not printed twice.
  • JS settledState list (approved, changes_requested, human_decision, passing, failing, skipped, missing) matches the states Go emits at stage_tracker_activity.go:575–590, so a settled verdict survives the 2‑minute freshness window while reviewing/waiting_ci/unassigned still fall back to "activity unknown".
  • Tooltip lines are escaped individually before join('<br>') (line 337); the JS test at stage_tracker_activity.test.js covers <img injection via a finding summary.

Blocking, mechanical

  • mergeStateStatus is DIRTY: head 5980996 no longer applies cleanly to v5. Needs a rebase (the PR body already assigns this to the fix agent); nothing in the diff itself needs to change.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

# Conflicts:
#	src/pkg/dashboard/stage_tracker_activity_test.go
@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: pushed 3d98d74 regenerating static/index.html from static-src/ (fixes TestIndexHTMLIsGenerated in test rest 3/4). The docker/arm64 image failures at 1c4a9bf were a transient npm registry miss (cline install → aws-sdk/credential-provider-ini@^3.973.26 notarget), green on v5 minutes earlier — re-running with this push. Sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Read stage_tracker_activity.go, static-src/js/tracker-row-strip.js and the regenerated static/index.html at 3d98d74. The change looks correct to me and this head is the first one where every test job is green; the single red check is infrastructure, not the diff.

build-hub (linux/amd64) is a registry/proxy failure, safe to re-run. Job 126861096784 fails inside the Docker go build with golang.org/x/sys@v0.49.0: read "https://proxy.golang.org/golang.org/x/sys/@v/v0.49.0.zip": stream error: stream ID 225; INTERNAL_ERROR (the arm64 leg was then cancelled). This PR touches no go.mod/go.sum, and build-go, build, build-contributor and all test (...) shards passed on the same head. A re-run of that workflow should clear it; nothing to change here.

Verified on this head

  • trackerPrefersVerdict (stage_tracker_activity.go:483-489) keeps the previous tie-break semantics inside trackerLatestBundleVerdicts (exact-time tie: dissent replaces approve, otherwise no replacement) and trackerReviewPerspectives (:515-543) never lets a newer approve from another backend/model hide a current dissent — TestStageTrackerReviewPerspectiveDetails covers both plus head/repo/number mismatch.
  • Caption dedupe is in step on both sides: Go trackerPerspectiveFindingLine (:617-633) and JS perspectiveLine (tracker-row-strip.js:287-288) build the identical "<name> ✗|requires human[: summary]" string, so the JS caption.includes(...) guard at :292 does not double-print.
  • Tooltip rendering is safe: tipHtml escapes each line before joining with <br> (:365), and production esc() already flattens \n to spaces, so title/aria-label stay single-line — the <img onerror> test exercises exactly that path.
  • The earlier stale-wording concern against 🐛 PR in progress chevron lights beside a running CI chevron and speaks the CI verdict #16643's remediation test is satisfied: the new freshness string still ends in · stale (:319), and test (dashboard 1/4) / dashboard shuffle pass on this head.

One low-severity note, not a blocker: the JS settledState list (tracker-row-strip.js:278) includes 'missing', while the backend's own settled map treats only passing/failing/skipped as settled (stage_tracker_activity.go:164) and the doc text added in streaming-the-activity-monitor.md names approved/findings/passing/failing. Effect: a stale observation of "CI waiting · required check X hasn't reported for this head yet" keeps data-display-state="known" with only the tooltip saying · stale, instead of falling back to "CI activity unknown". Defensible for the #16599 approve-workflows case, but if the intent is "only verdicts persist", dropping 'missing' from :278 (and the index.html mirror) would align the three. Fine to land either way.

Another agent tried to open a PR from quality/test-stage-tracker-motion-stdin, but this PR edits an overlapping set of files. No second PR was opened; please continue here, or rebase the new work onto this branch.

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Style / maintainability (read at head 836c9fe; advisory, not blocking)

  1. The "first failing perspective" caption suffix is now formatted in two places that must stay byte-identical. Go appends name + " ✗"/" requires human" + ": " + summary in src/pkg/dashboard/stage_tracker_activity.go:734-746; the JS re-derives the same string via perspectiveMark/perspectiveLine in src/pkg/dashboard/static-src/js/tracker-row-strip.js:280-289 and only suppresses its own copy when caption.includes(perspectiveLine(firstFinding)) matches exactly. If either side changes a glyph or separator, the dedupe silently fails and the finding appears twice in the caption. Suggest a cross-reference comment on the Go side naming the JS mirror (the JS comment explains why it re-derives but not what it must match), or letting one side own the suffix.

  2. trackerReviewPerspectives (stage_tracker_activity.go:511-512) encodes "dissent beats approval, otherwise newest wins" as a dense compound boolean, while trackerLatestBundleVerdicts (:485-486) expresses a similar tie-break in a different shape. A small trackerPrefersVerdict(previous, candidate) helper would make both readable and keep the rule in one place.

Nice: the runMotionScript consolidation in stage_tracker_motion_test.go removes four copies of the node-fixture boilerplate.

Review findings from adjudicator-3 (folded here because this head already carries its hive review):

docs-currency (read at head 836c9fe)

  1. API reference still documents the old review_activity shape. src/docs/api-reference/dashboard-misc.md:8 lists each activity observation as {head, state, caption, actor?, source, observed_at?, since?, blocker?, url?, active?}. This PR adds review_activity.perspectives[] {name, verdict, summary} (src/pkg/dashboard/stage_tracker_activity.go:48-57, populated at :609), which Activity Monitor: red Review chevron says "Review activity unknown · last observed changes_requested" #16617 names as deliverable 2 of the fix, and the frontend reads it (static-src/js/tracker-row-strip.js:282). Please append perspectives?: [{name, verdict, summary}] (and, while there, the already-shipped perspectives_done?/perspectives_total?) to that field list so consumers of GET /api/stage-tracker can find the field. Optional: src/docs/streaming-the-activity-monitor.md:38-39 ("Track tooltips disclose … observation time") could note that settled current-head verdicts keep their caption with an observed Nm ago age while only motion states fall back to activity unknown, which is the behaviour this PR introduces.

  2. (out of scope, adjacent) The row-level #N tooltip's track summary still appends · stale observation to a settled caption (static-src/js/tracker-row-strip.js:578), so an aged changes_requested reads "Review findings · stale observation" there while the chevron tooltip now reads "observed 15m ago · stale". Not what Activity Monitor: red Review chevron says "Review activity unknown · last observed changes_requested" #16617 asked for, but the same "a settled verdict does not go stale" principle; worth aligning later.

Changelog fragment name/category conform to changelog.d conventions and its text matches the diff.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the tree at 3d98d74 against merge-base df66e91, not just the diff. This looks correct to me and matches the three items #16617 scopes (settled verdicts survive the 2‑minute window, perspectives[] on the wire, caption names the first failing perspective).

What I verified:

  • stage_tracker_activity.go:483-491 — trackerPrefersVerdict keeps the prior tie-break semantics in trackerLatestBundleVerdicts (equal timestamps: dissent beats approve, otherwise keep previous), and trackerReviewPerspectives (:515-543) reuses it per perspective so a newer approve from another backend/model cannot hide a still-current changes_requested — covered by the appended Backend: "z" case in TestStageTrackerReviewPerspectiveDetails.
  • The JS settledState list in tracker-row-strip.js:278 (approved, changes_requested, human_decision, passing, failing, skipped, missing) is exactly the set of non-motion state literals the Go side emits; running/queued/reviewing/adjudicating/assigned/unassigned/waiting_* still fall back to "activity unknown" when stale.
  • Caption dedupe is an exact-string mirror: Go trackerPerspectiveFindingLine (:617-632) and JS perspectiveLine (:287-288) build "<name> ✗|requires human[: <summary>]" identically, so the tooltip shows the finding once.
  • static/index.html's stageTrackerActivityTrackHtml is byte-identical to static-src/js/tracker-row-strip.js (the shared-asset test would catch drift).
  • runNodeStdin is still used by six other test files after the runMotionScript consolidation, so unused lint is unaffected. go build ./pkg/dashboard/ is clean at this head.

Nothing blocking from me; CI test shards were still in progress when I read it.

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness review (read at head 3d98d74a, which superseded the dispatched 1c4a9bfc). No blocker; one advisory.

  • missing is treated as a settled CI verdict — static-src/js/tracker-row-strip.js:278 puts 'missing' in settledState, but the backend renders that state as "CI waiting · required check … hasn't reported for this head yet" (stage_tracker_activity.go:248-249), i.e. a waiting state that a push / re-run / label changes — exactly what the comment on line 276-277 says "implies motion". An observation older than the 2‑minute window will now read as a confidently known "CI waiting" instead of CI activity unknown · last observed missing. skipped is a terminal conclusion and belongs in the list; missing arguably does not. Low; not blocking the Activity Monitor: red Review chevron says "Review activity unknown · last observed changes_requested" #16617 contract, which is about review verdicts.

Verified: trackerReviewPerspectives dissent-over-approval matches trackerBundleApproves (every latest verdict must approve, stage_tracker_activity.go:545-563), so a ✗ line never appears beside Review approved; the Go trackerPerspectiveFindingLine ↔ JS perspectiveLine strings are identical for changes_requested/reject/requires_human, so the caption.includes() dedupe holds; production esc() flattens \n to a space (static/index.html:47466-47476), so the title/aria-label attributes and the <br>-joined tooltip body are both safe.

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

# Conflicts:
#	src/pkg/dashboard/stage_tracker_activity.test.js
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness — delta re-review at f8c15ea (merge of origin/v5 into the PR branch; the PR's own +/- content vs merge-base is byte-identical to the previously approved head except where it overlaps upstream).

Merge interaction breaks CI (in-scope, concrete fix). Upstream bc23607 (#16644 / #16643) added stage_tracker_remediation_chevron.test.js:295-306, which asserts a stale-polled missing CI track still says stale · <ISO> in its tooltip. This PR's new freshness string in static-src/js/tracker-row-strip.js:317 only emits · stale when stale && moving, and missing is in settledState (line 278), so moving is false and the word is dropped. At head, test (dashboard 1/4), test (dashboard shuffle 2/3), runtime-tests and therefore build-and-test all fail on exactly that assertion (not ok 14 - a stalled or stale-polled text-bearing track is plainly active, error the poll age rides the tooltip).

Fix: drop the && moving qualifier — (stale ? ' · stale' : '') — in tracker-row-strip.js:317, then make dashboard-gen to regenerate static/index.html. The PR's own tests (stage_tracker_activity.test.js:565, :954) only match observed Nm ago, so they remain green; settled verdicts still persist via known/active (lines 280-281), which is the behaviour #16617 asks for.

Other overlap (stage_tracker_motion_test.go: upstream runNodeStdin replaced by the PR's file-based runMotionScript, lines 697-710) is equivalent and runNodeStdin keeps other callers. dashboard-gen-check passes at head; go build of dashboard/github/cmd packages succeeds.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go side looks correct to me; the red test (dashboard 1/4) / dashboard shuffle 2/3 jobs are a real contract conflict with #16643 in the JS, not flake.

src/pkg/dashboard/static-src/js/tracker-row-strip.js:278, :317 — a stale poll of a missing CI track no longer says stale in the tooltip, which stage_tracker_remediation_chevron.test.js:295-304 (from #16643) pins. :278 puts 'missing' in settledState, so moving is false; :317 only appends ' · stale' when stale && moving. The #16643 fixture is a CI track in state: 'missing' with blocker: 'workflow-approval-required:1', observed hours ago, and asserts title="[^"]*stale · 2026-11-04T01:00:00\.000Z ("the poll age rides the tooltip"). With this PR the title reads observed 19h ago · 2026-11-04T01:00:00.000Z — the age is there but the word stale and the stale · <iso> form are gone, so TestStageTrackerRemediationJavaScript fails (stage_tracker_remediation_test.go:223). Severity: medium — blocks merge.

Two ways to reconcile, and it is a product call which: (a) treat missing as motion-pending rather than settled (a track waiting on workflow approval is waiting for something, which is the #16643 reading), or (b) keep missing settled but still emit stale · <iso> when stale regardless of moving, and update the #16643 assertion to the new observed Nh ago wording. (b) keeps the "settled verdicts persist" intent of this PR for CI passing/failing while not hiding a stale poll on a stalled track.

Verified on the Go side (read at the PR head):

  • trackerReviewPerspectives (stage_tracker_activity.go:502-531) collapses trackerLatestBundleVerdicts (already latest per perspective\x00backend\x00model, :481-500) to one per perspective with dissent-wins ordering: non-approve replaces approve, same-class newer replaces older, approve never replaces earlier dissent — matches the comment and the preserve dissent goal.
  • Perspectives only populates when the bundle head matches the PR head (:607-609), so a stale bundle cannot attach old verdicts to a new head.
  • The caption suffix (:734-747) is only added for changes_requested/human_decision and breaks after the first non-approve perspective — bounded.
  • runMotionScript consolidation in stage_tracker_motion_test.go is a no-behaviour-change refactor (all five fixtures now go through a temp file, which also removes the latent E2BIG risk on the -e ones).

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 4, 2026
hivecommons-hive Bot and others added 2 commits November 4, 2026 15:49
… wording

Document review_activity.perspectives[] in the API reference and the
settled-verdict ageing rule in the activity monitor guide. The row tooltip
track summary now ages settled verdicts the way the chevron tooltip does
("observed 15m ago · stale") instead of "stale observation". Extract
trackerPrefersVerdict so both verdict pickers share the dissent-over-
approval rule, and move the failing-perspective caption suffix into
trackerPerspectiveFindingLine with a cross-reference to its JS mirror.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
TestIndexHTMLIsGenerated failed because the last two commits edited
static-src/ without re-running the concat generator.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: the fix is correct and matches #16617, but the head is not mergeable as-is: src/pkg/dashboard/static/index.html was not regenerated after the last two commits, which is the single root cause of every red check in v2 Tests.

Verified (read at 1c4a9bf, base v5):

  • test (rest 3/4) fails in pkg/dashboard/webstatic → TestIndexHTMLIsGenerated (indexgen_test.go:28: "static/index.html differs from the concatenation of static-src/ (first difference at line 18218)"). test and coverage are red only because that shard failed. Reproduced locally: go run ./pkg/dashboard/webstatic/gen -src pkg/dashboard/static-src -out pkg/dashboard/static/index.html -check exits 1 on this head and 0 on v5.
  • The drift is not cosmetic. Diffing the generated output against the committed file: index.html is missing (a) the three "Mirrors trackerPerspectiveFindingLine…" comment lines (static-src/js/tracker-row-strip.js:283-285), and (b) the whole second hunk from commit 836c9fe/1c4a9bf — static/index.html:18491 still renders ' · stale observation' while static-src/js/tracker-row-strip.js:581-585 renders ' · observed Nm ago · stale'. So the spoke would ship the old current-stage wording that stage_tracker_activity.test.js:954 (/observed 15m ago/) says was fixed.
  • Fix: make dashboard-gen and commit index.html alongside. Nothing else in the diff needs to move.

Logic, read against the tree:

  • stage_tracker_activity.go:483-489 trackerPrefersVerdict keeps the previous tie-break exactly (dissent beats approve on equal RecordedAt; otherwise unchanged), and trackerReviewPerspectives (:515-543) collapsing per-perspective across backend/model with dissent-wins is what the issue asks for. Sorted names give a deterministic first finding on both sides.
  • Caption/tooltip dedupe is a true mirror: trackerPerspectiveFindingLine (:616-630) and perspectiveLine (tracker-row-strip.js:286-287) build byte-identical strings for changes_requested/reject/requires_human, so the caption.includes(...) guard at :291 does suppress the double append. The JS suite passes locally (40/40).
  • settledState gating (tracker-row-strip.js:278-282) only lets verdict states outlive the 2-minute window; running/reviewing still fall through to activity unknown · last observed …, which is the behaviour #16617 wants preserved.

Not blocking, just noting: the tooltip lists the first finding twice (once appended to the caption, once in the per-perspective lines — stage_tracker_activity.test.js:915 pins this shape), which is fine if intentional.

The docker (*) and overlayfs-exec-guard failures are outside this diff; I did not triage them.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

hivecommons-hive Bot added a commit that referenced this pull request Nov 4, 2026
…, never "activity unknown" (#16662)

A Review track with no verdict and no reviewer in flight now derives a
concrete statement from the PR's lifecycle and its CI track
(stage_tracker_review_fallback.go): closed/merged, draft, waiting for CI,
not started (+ who is next), or — only when nothing was fetched for the
head — "no data for head <sha7> yet · refreshing". The UI drops the
"activity unknown · last observed …" prefix: settled verdicts stay known
as observations age (dated in the tooltip), and a settled review explains
itself — who decided, how long ago, each perspective's verdict with its
first finding (perspectives field, dissent preserved). An aggregate
approval the verified bundle does not back reads "evidence not verified"
instead of unknown. Fixture invariant: no CI/Review tooltip contains
"activity unknown" / "CI unknown" / "Review unknown".

Supersedes #16634.
Fixes #16617
Fixes #16661

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

Closing this hive-authored PR as superseded by #16662: every issue it closes is already closed and that merged PR closed #16617. Head 3d98d74 conflicts with v5, so there is nothing of its own left to rebase and measure. Reopen if that's wrong.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Nov 4, 2026
@hivecommons-hive hivecommons-hive Bot closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity Monitor: red Review chevron says "Review activity unknown · last observed changes_requested"

1 participant