Skip to content

🐛 Stage tracker: say CI running (not activity unknown) when checks are still pending - #16637

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
fix/ci-activity-unknown-caption
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
fix/ci-activity-unknown-caption

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Fixes #16630

Rebased onto v5 after #16636, #16632, #16644, #16662 and #16669 merged; the overlapping parts of this PR that those already cover were dropped. What remains, on top of #16662's semantics:

  • Go (stage_tracker_activity.go): running/queued captions name what is pending — CI running · 4 checks pending (or the one/two pending names) plus · N failing when a neighbour is red — instead of N/M checks done, which duplicated the chevron count in the tooltip; the unreported required check is one sentence in Detail (Required check 'test' has not reported for this head yet.) rather than the "missing" verdict while others still run; Since is the latest check-run timestamp on the head; ChecksPending is exposed; the head-wide (required-set-unknown) path reads motion in stageTrackerCountHeadChecks directly (replacing stageTrackerHeadChecksMotion). 🐛 Review and CI chevrons state what the head waits on, never "activity unknown" #16662's no-data captions and 🐛 PR in progress chevron lights beside a running CI chevron and speaks the CI verdict #16643's "running is active" rule are kept.
  • JS (tracker-row-strip.js): chevron suffix carries the pending count/names (CI 12/66 · 54 running, CI 7/11 · 'test' not reported), no verdict yet is gone; the tooltip is composed from deduplicated facts (count word → caption unless the detail already says it → detail → blocker → ask), keeping 🐛 Review and CI chevrons state what the head waits on, never "activity unknown" #16662's since-ago and perspective lines.
  • Check names embedded in captions, details and chevron text are single-quoted.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16660 🐛 fix: label narrow dashboard navigation same files src/pkg/dashboard/static/index.html
#16615 ✨ feat(ci): approve gated workflows for trusted PR heads same files src/pkg/dashboard/stage_tracker_activity.go

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@clubanderson
clubanderson force-pushed the fix/ci-activity-unknown-caption branch from 1f7e5b1 to 7f7b41a Compare November 4, 2026 18:26
@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 1/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness re-review at 2ac426b (delta since 43f6f31 is the v5 merge plus the quoting commit; PR surface vs base is 8 files).

Previous findings: test-vs-code "stale running is not Active" — fixed (stage_tracker_activity_test.go:54-59 now asserts running is active regardless of poll age, matching out.Active = out.State == "running" at stage_tracker_activity.go:88,124). Remediation-chevron JS test expecting an unquoted name — fixed (stage_tracker_remediation_chevron.test.js:171,183 expect 'test' not reported). Skipped/neutral → pending on the head-wide path — still present, details below.

1. Head-wide path: a completed/skipped (or neutral) check run is "pending" forever → CI running + active chevron that never settles

stage_tracker_activity.go:349-353: the tally only sets t.passing for Conclusion == "success"; t.failing only for the red conclusions. A completed run with conclusion skipped/neutral (path-filtered jobs, if: guards — very common) sets neither, so at :364-366 it falls into default → out.ChecksPending. Then :376-379 makes State = "running" whenever ChecksPending is non-empty, Caption = "CI running · 'docs' pending", and the caller (:88, :124) sets Active = true.

Consequence: on any PR where the required set is unknown (no branch protection, or protection not fetched yet) and one job was skipped, the CI track reads "CI running · 'docs' pending" with an animated chevron indefinitely, even after every other check is green. That is a regression against the code this PR deletes — stageTrackerHeadChecksMotion only counted in_progress/queued/waiting/pending/requested as motion — and inconsistent with the required-set path, which treats neutral/skipped as settled (:160-161, :168, :224). No test covers a skipped run on the head-wide path (stage_tracker_activity_test.go:26,370 both exercise the required-set path).

Fix — treat a skipped latest run as settled and leave it out of the ring count so passed + failed == total once the rest finish:

 	type tally struct {
-		passing, failing bool
-		since            time.Time
+		passing, failing, skipped bool
+		since                     time.Time
 	}
@@
 		if !at.Before(t.since) {
-			t.since, t.passing = at, check.State == "completed" && check.Conclusion == "success"
+			t.since = at
+			t.passing = check.State == "completed" && check.Conclusion == "success"
+			t.skipped = check.State == "completed" && (check.Conclusion == "skipped" || check.Conclusion == "neutral")
 		}
 	}
 	out.ChecksTotal = len(order)
 	for _, name := range order {
 		t := byName[name]
 		switch {
 		case t.failing:
 			out.ChecksFailed++
 			out.ChecksFailing = append(out.ChecksFailing, name)
 		case t.passing:
 			out.ChecksPassed++
+		case t.skipped:
+			// A skipped job is settled, not pending; it does not fill the ring.
+			out.ChecksTotal--
 		default:
 			out.ChecksPending = append(out.ChecksPending, name)
 		}
 	}

plus a head-wide case in TestStageTrackerActivityCIRunningWhileChecksPending with chk("docs", "completed", "skipped") beside two green runs asserting State != "running" and !Active.

2. (low) Tooltip drops the caption unconditionally, not "unless the detail already says it"

tracker-row-strip.js:350 — if (!(text && detail)) say(caption); omits the caption whenever both a chevron word and a detail exist, regardless of content; the comment at :347-349 and the PR body describe a containment check. For the CI track the chevron word carries the same counts so nothing is lost, but any track whose caption holds facts the detail does not (e.g. review perspective counts) will lose them from the tooltip. say(caption) already de-duplicates via facts.some(f => f.includes(...)), so the guard can simply go:

      say(caption);

Review findings from adjudicator-3 (folded here because this head already carries its hive review):

Intent-alignment re-review at 75f06f0 (delta since 12a8abb; the compare is mostly v5 rebase noise — the PR's own diff is still the 8 files).

Issue #16630 items 2 (tooltip says each fact once — tracker-row-strip.js:333-341) and 3 ("no verdict yet" gone, unfinished count/names in the chevron — tracker-row-strip.js:76-96, stage_tracker_activity.go:433-446) are done. Item 1 is still incomplete in one case:

Still present — completed skipped/neutral checks read as pending forever (required set unknown). stage_tracker_activity.go:341-346 only records passing (success) and failing; a check whose latest run is completed+skipped/neutral lands in default: at :358-359 → ChecksPending → State = "running" / CI running · 'docs' pending at :370-373, and Since keeps refreshing from stageTrackerLatestCheckTime. Path-filtered workflows report skipped on most heads, so a fully-finished head in an unprotected repo never leaves "running" — the opposite of the issue's "the caption must say so accurately". The required-known path already handles this (case "skipped": at :214); stage_tracker_activity_test.go has no skipped case for stageTrackerCountHeadChecks (only :366, which is the required-known path).

--- a/src/pkg/dashboard/stage_tracker_activity.go
+++ b/src/pkg/dashboard/stage_tracker_activity.go
@@ func stageTrackerCountHeadChecks(
 	type tally struct {
-		passing, failing bool
+		passing, failing, skipped bool
 		since            time.Time
 	}
@@
 		if !at.Before(t.since) {
-			t.since, t.passing = at, check.State == "completed" && check.Conclusion == "success"
+			t.since = at
+			t.passing = check.State == "completed" && check.Conclusion == "success"
+			t.skipped = check.State == "completed" && (check.Conclusion == "skipped" || check.Conclusion == "neutral")
 		}
@@
 		case t.passing:
 			out.ChecksPassed++
+		case t.skipped:
+			// finished without a verdict: not pending, not a pass
 		default:
 			out.ChecksPending = append(out.ChecksPending, name)

Still present — JS pending count includes skipped checks. tracker-row-strip.js:77 pendingCount = Math.max(total - passed - failed, pendingNames.length): with ≥3 pending plus one skipped required check the chevron says N+1 running; with zero pending and one skipped (state unknown, checks_pending omitted) line :95 prints CI 4/5 · 1 running under a Go caption of "all checks passed · required set unknown". The backend's checks_pending is the authoritative count whenever it reports motion:

        const pendingCount = pendingNames.length || ((state === 'running' || state === 'queued') && total ? Math.max(total - passed - failed, 0) : 0);

Please add a completed/skipped case to the unknown-set Go test and a ci('unknown', {checks_passed: 4, checks_total: 5}) JS assertion.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

The red test (dashboard …) / coverage checks on 75f06f0 are caused by this diff, not flake, and they will stay red until the fixture changes.

What fails: TestStageTrackerMotionRowStamp — stage_tracker_motion_test.go:501: fork/exec …/node: argument list too long. It fails on every dashboard shard and both shuffle runs of workflow run 41892990000, and the same test passes on the merge-base 655fa3f (v5 run 41894473673 green).

Mechanism: the test concatenates ~90 functions/consts sliced from index.html (including stageTrackerChipsHtml/stageTrackerTooltip, which this PR grows by +51 lines) and hands the whole thing to exec.Command(node, "-e", script) (stage_tracker_motion_test.go:499). Linux caps a single argv string at MAX_ARG_STRLEN = 128 KiB; a rough extraction of the listed functions already measures ~120 KiB on v5 and ~121 KiB on this head before the fixture preamble and the stageTrackerActedJS/stageTrackerTierJS blocks are added, so this PR tips it over. Any later growth of those functions would hit the same wall.

Suggested fix (in this PR, since it introduces the red): feed the script on stdin instead of argv, the way agent_channels_ui_test.go:100 and avatar_menu_markup_test.go:33 already do:

cmd := exec.Command(node, "-")
cmd.Stdin = strings.NewReader(script)

I did not review the caption/chevron logic itself beyond this; the conflicts-with-open-pr label (vs. #16644 touching the same row-strip files) is a sequencing call for you.

Review findings from reviewer (folded here because this head already carries its hive review):

Read the diff against v5 at merge-base bc23607 plus the callers in tracker-row-strip.js and the v2 Tests run on head 43f6f31. The caption/ChecksPending design is sound and the required-known path handles every state it enumerates, but the head is red for two reasons the PR itself introduced, and the head-wide path picks up a regression for skipped checks.

1. src/pkg/dashboard/stage_tracker_activity_test.go:671 contradicts the code it tests (CI red). The test asserts stale running head-wide should not pulse, but stage_tracker_activity.go:76 sets out.Active = out.State == "running" || out.State == "queued" unconditionally — which is also what v5 now does after #16643 ("Running is active, full stop", stage_tracker_activity.go:198-201 on v5). The log shows exactly this: Active:true with Caption:CI running · 54 checks pending. The code is right per #16643; the assertion predates it and should go (or flip to !got.Active → fail).

2. src/pkg/dashboard/stage_tracker_remediation_chevron.test.js:226 still expects unquoted names (CI red). The PR switches chevron text to single-quoted check names (stageTrackerCheckName, and q() in tracker-row-strip.js), so the rendered chevron is CI 4/11 · 6 running · 1 failing ('Sign-off survives'), but the regex is /1 failing \(Sign-off survives\)</ → TestStageTrackerRemediationJavaScript fails (not ok 10 - #16634 shape…) in every shard.

3. Regression, medium: a skipped/neutral check keeps the head-wide track "running" forever. In stageTrackerCountHeadChecks (stage_tracker_activity.go:339-357) a tally is failing only for the red conclusions and passing only for completed+success; anything else — including completed+skipped/neutral — falls into default: → ChecksPending, and the new case len(out.ChecksPending) > 0: then forces State = "running", Active = true. On v5 that state was driven by stageTrackerHeadChecksMotion, which counted only in_progress/queued/waiting/pending/requested runs, so a settled skipped check never animated the ring. Consequence: on any repo where the required set is unknown, a head whose checks have all finished but include e.g. copilot-dco / copilot-dco: SKIPPED (every PR in this repo has one) reads CI running · 'copilot-dco / copilot-dco' pending and pulses indefinitely. The required-known path already special-cases "skipped" (:213); the tally needs the same (t.skipped → neither counted nor pending), and the ChecksTotal denominator should probably exclude it the same way total does there.

Suggest fixing 1–2 (test updates) and 3 (one extra tally bit) together; the rest of the change — ChecksPending wiring, stageTrackerLatestCheckTime for Since, the workflow-approval hold in the motion switch — looks correct to me. Note also this overlaps #16662 on stage_tracker_activity.go / tracker-row-strip.js (different change, not a duplicate), so whichever lands second needs a rebase.

hive/awaiting-ci: rebased onto v5 after #16644 landed. Conflict resolution: kept #16644's rule that a running/queued CI track is active regardless of poll freshness (dropped the now-unused stageTrackerCIObservedFresh), and kept this PR's removal of stageTrackerHeadChecksMotion (motion now lives in stageTrackerCountHeadChecks). Author commits and sign-offs preserved. CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Evidence bundle `#166372ac426b` sha256:1b4a5c2c4696dab7bb81f8d74fed5797dce7532c70988e63c5b9e4fd4609368c — download from the dashboard or `hivectl review evidence #16637`.

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (read at head 7f7b41a; #16636 is merged, so only the one commit on top was judged).

1. Unknown required set: a finished skipped/neutral check is counted as pending and flips the head to CI running forever — src/pkg/dashboard/stage_tracker_activity.go:324-351

stageTrackerCountHeadChecks tallies only passing and failing; a check whose latest run is completed with conclusion skipped/neutral hits the new default: arm (line 346) and lands in ChecksPending. With no red check that selects case len(out.ChecksPending) > 0 (line 364): State = "running", caption CI running · "lint" pending, and out.Active pulses while the poll is fresh (line 76). Path-filtered workflows report skipped on most heads, so on an unprotected base (the v6 case the file comments call out) a fully finished head reads as running with no way to settle. The required-set path treats skipped as its own state (line 150-152, 196), so the two paths now disagree, and the issue's "running" is specifically "the rest are running or pending", not finished-as-skipped. Not covered: TestStageTrackerActivityCIRunningWhileChecksPending and the head-wide block in TestStageTrackerActivityCICounts... (stage_tracker_activity_test.go:414-431) use only success/failure/queued/in_progress.

Suggested fix — track skipped in the tally and keep it out of pending:

 	type tally struct {
-		passing, failing bool
+		passing, failing, skipped bool
 		since            time.Time
 	}
@@
 		if !at.Before(t.since) {
-			t.since, t.passing = at, check.State == "completed" && check.Conclusion == "success"
+			t.since = at
+			t.passing = check.State == "completed" && check.Conclusion == "success"
+			t.skipped = check.State == "completed" && (check.Conclusion == "skipped" || check.Conclusion == "neutral")
 		}
@@
 		case t.passing:
 			out.ChecksPassed++
+		case t.skipped:
 		default:
 			out.ChecksPending = append(out.ChecksPending, name)
 		}

and a case in TestStageTrackerActivityCIRunningWhileChecksPending with run("docs", "completed", "skipped", &t2) alongside the 12 green on rowB with the 54 in-progress removed, asserting State == "unknown" and len(ChecksPending) == 0.

Note the JS side computes pendingCount = total - passed - failed (tracker-row-strip.js:74), which would still count a skipped check; once the Go side excludes it, Math.max(..., pendingNames.length) keeps the chevron at the arithmetic count (CI 12/13 · 1 running). Consider deriving the count from checks_pending.length when the array is present so the chevron matches the caption.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson force-pushed the fix/ci-activity-unknown-caption branch from 12a8abb to 75f06f0 Compare November 4, 2026 19:02
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

CI triage (scanner): test, coverage, test (dashboard 1/4) and test (dashboard shuffle 2/3) on 75f06f0 all roll up to one failure — v5 is green, so this is PR-local:

stage_tracker_motion_test.go:501: node row stamp fixture failed: fork/exec .../node: argument list too long
--- FAIL: TestStageTrackerMotionRowStamp

TestStageTrackerMotionRowStamp still passes its lifted script to node -e <script> as a single argv. This PR grows the lifted strip (tracker-row-strip.js / stageTrackerActivity* helpers pulled in via jsFunc) past Linux's 128 KiB MAX_ARG_STRLEN, so exec fails before node starts. TestStageTrackerMotionPreviewSample in the same file already hit this and switched to a temp file (see the "lifted strip exceeds Linux's single-argument limit" comment around line 702). Same fix here:

	// The lifted strip exceeds Linux's single-argument limit, so the script
	// goes through a file rather than -e.
	path := filepath.Join(t.TempDir(), "motion_row_stamp.js")
	if err := os.WriteFile(path, []byte(script), 0o600); err != nil {
		t.Fatal(err)
	}
	cmd := exec.Command(node, path)
	if out, err := cmd.CombinedOutput(); err != nil {
		t.Fatalf("node row stamp fixture failed: %v\n%s", err, out)
	}

(replaces the cmd := exec.Command(node, "-e", script) block at src/pkg/dashboard/stage_tracker_motion_test.go:499-502). The other -e call sites at lines 220, 374 and 909 are one more lifted helper away from the same wall; worth converting them in the same push. Not pushing to your branch since the PR is human-authored.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Follow-up to the scanner triage above (quality): #16634 (green, waiting on tide) already converts all four -e sites in stage_tracker_motion_test.go to a temp-file runner (runMotionScript), so there is no need to hand-apply the suggestion here — once #16634 lands, merging v5 into this branch clears TestStageTrackerMotionRowStamp on its own. #16644 is red on the same line.


🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness — delta re-review at 75f06f0 (previous head 12a8abb). The rebase onto #16632/#16636 and the single-quote pass look right; the two findings from the previous round are still present.

1. Unknown required set: a completed skipped/neutral run is counted as pending → CI running forever (still present)

src/pkg/dashboard/stage_tracker_activity.go:341-359 — the per-name tally only knows failing (red conclusions, L341) and passing (completed+success, L346). A run that completed as skipped or neutral is neither, so the switch at L352-359 falls to default: and appends it to ChecksPending. Then L368 (case len(out.ChecksPending) > 0) sets State = "running" and the caption reads CI running · 'docs' pending indefinitely, with Active pulsing while the poll is fresh. The required-known path already handles this (case "skipped": at L214), so the two paths disagree on the same head. stage_tracker_activity_test.go has no skipped/neutral case on the unknown-required path (the only skipped fixtures, L26/L366, use RequiredKnown: true).

 	type tally struct {
-		passing, failing bool
+		passing, failing, settled bool
 		since            time.Time
 	}
@@
 		if !at.Before(t.since) {
-			t.since, t.passing = at, check.State == "completed" && check.Conclusion == "success"
+			t.since, t.passing, t.settled = at, check.State == "completed" && check.Conclusion == "success", check.State == "completed"
 		}
@@
 		case t.passing:
 			out.ChecksPassed++
+		case t.settled:
+			// skipped / neutral: finished, counts neither way (mirrors the
+			// required-known "skipped" case above).
 		default:
 			out.ChecksPending = append(out.ChecksPending, name)

Plus one table case: chk("docs","completed","skipped") beside a green run with RequiredKnown: false → expect state unknown, not running. (The default: caption at L380 then needs %d/%d observed checks passed instead of all … passed, since a skipped name is in ChecksTotal but not ChecksPassed.)

2. JS pendingCount still counts skipped checks as running (still present)

src/pkg/dashboard/static-src/js/tracker-row-strip.js:77 — Math.max(total - passed - failed, pendingNames.length): on the required-known path the backend now excludes skipped names from checks_pending but they remain in checks_total, so with ≥3 pending plus one skipped the chevron says e.g. CI 10/14 · 4 running for 3 running. Prefer the backend's list when it is present:

        const pendingCount = pendingNames.length || (total ? Math.max(total - passed - failed, 0) : 0);

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@clubanderson
clubanderson force-pushed the fix/ci-activity-unknown-caption branch from 75f06f0 to 420a88f Compare November 4, 2026 19:38
@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
@hivecommons-hive
hivecommons-hive Bot force-pushed the fix/ci-activity-unknown-caption branch from 420a88f to 43f6f31 Compare November 4, 2026 19:45
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is back in your court (stage/071-needs-author). Its commits are signed off as the hive App rather than as you, so a squash merge would misattribute them and the sign-off attribution check stays red. No hive agent can rewrite a contributor's commits — the fix is yours:

  • 3 commits are signed off as the hive App instead of you, so a squash merge would misattribute them — set git config user.email to your own address, then run git rebase --exec 'git commit --amend --no-edit --reset-author -s' HEAD~3 && git push --force-with-lease

Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path.

1 similar comment
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is back in your court (stage/071-needs-author). Its commits are signed off as the hive App rather than as you, so a squash merge would misattribute them and the sign-off attribution check stays red. No hive agent can rewrite a contributor's commits — the fix is yours:

  • 3 commits are signed off as the hive App instead of you, so a squash merge would misattribute them — set git config user.email to your own address, then run git rebase --exec 'git commit --amend --no-edit --reset-author -s' HEAD~3 && git push --force-with-lease

Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness re-review at 43f6f31 (delta since 75f06f0; the compare is dominated by the v5 rebase, the PR's own diff is the 10 dashboard files).

Prior findings:

  • stage_tracker_motion_test.go E2BIG from node -e — fixed: all four fixtures now feed the script on stdin (stage_tracker_motion_test.go:220-223, 377-380, 915-918, stage_tracker_repo_grouping_test.go:561-563); test (dashboard *) is green on this head.
  • Conflict with #16644 — no longer applies: #16644 merged, the PR is rebased and MERGEABLE.

Delta reads correctly: the empty case out.State == "missing" && a.WorkflowApproval… at stage_tracker_activity.go:189 keeps the approval-gated head out of the motion override (no fallthrough in Go), stageTrackerLatestCheckTime is only applied to running/queued (:225-229), and TestStageTrackerActivityCIRunningWhileChecksPending pins state, caption, pending count and Since per case.

One low advisory, not blocking:

Chevron count includes skipped required checks — static-src/js/tracker-row-strip.js:77: pendingCount = Math.max(total - passed - failed, pendingNames.length). In the required-known path Go leaves skipped/neutral names out of both ChecksPassed and ChecksPending (stage_tracker_activity.go:203-219), so with ≥3 pending names plus one skipped check the chevron reads N+1 running while the caption says N checks pending. Prefer the names when the backend sent them and fall back to arithmetic only for older payloads:

        const pendingCount = pendingNames.length || (total ? Math.max(total - passed - failed, 0) : 0);

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

CI diagnosis (from the hive; it can't push to a human-authored branch, so this needs to be applied by the author)

TestStageTrackerRemediationJavaScript (stage_tracker_remediation_chevron.test.js) fails on subtests 10 (#16634 shape…) and 14 (a stalled or stale-polled text-bearing track…). The failure comes from this PR's diff, not infra and not a rebase issue. tracker-row-strip.js now single-quotes check names (1 failing ('Sign-off survives')) and renders a pending count (CI 14/67 · 53 running). Two untouched assertions still expect the old text.

Fix in src/pkg/dashboard/stage_tracker_remediation_chevron.test.js:

@@ line 226 (test 10)
-  assert.match(a[4], /class="ham-seg ham-activity-track active"[^]*CI 4\/11 · [^<]*1 failing \(Sign-off survives\)</);
+  assert.match(a[4], /class="ham-seg ham-activity-track active"[^]*CI 4\/11 · [^<]*1 failing \('Sign-off survives'\)</);
@@ line 310 (test 14)
-  assert.match(old[4], /class="ham-seg ham-activity-track active ham-current"[^]*CI 14\/67 · running</, '...');
+  assert.match(old[4], /class="ham-seg ham-activity-track active ham-current"[^]*CI 14\/67 · 53 running</, '...');

Both strings match the actual: output in the CI log. The other red jobs (dashboard 3/4 and the shuffle shards) run the same test. I couldn't read logs for build-and-test or runtime-tests, so I haven't confirmed they fail for this reason.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Addendum to the scanner diagnosis above (quality): build-and-test and runtime-tests on 43f6f31 fail for the same two subtests (not ok 289 / not ok 293 in the runtime lane — runtime=failure is what fails build-and-test), so the two-line test fix is the whole repair.

One more line to touch while you are in stage_tracker_remediation_chevron.test.js: line 235

assert.doesNotMatch(b[4], /Sign-off survives\)</, 'the inactive red track is its icon alone');

still passes, but only because the strip now renders ('Sign-off survives') — survives')< can never match survives\)<, so the guard would also pass if the inactive track did render its words. Suggest /Sign-off survives'?\)</ (or /ham-chevron-copy/, as the sibling c[3] case does) so it keeps asserting icon-only.


🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Scanner (this kick): since the diagnoses above, #16637 has gone CONFLICTING against v5 — v5 moved on src/pkg/dashboard/stage_tracker_activity.go, stage_tracker_activity.test.js, stage_tracker_activity_test.go, stage_tracker_ui_rows_test.go, static-src/js/tracker-row-strip.js and static/index.html, all of which this PR also touches. Human-authored branch, so the hive will not rebase it; needs git rebase origin/v5 by the author alongside the test-harness fix already described. Deferred until then.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026
…e still pending

A head with 7/11 checks reported is mid-pipeline, not unknown: when
checks still run or queue, the CI state is running (or queued) and the
caption counts the unfinished checks; a required check with no run yet
is one sentence in Detail instead of the missing verdict, and head-wide
counts (required set unknown) follow the same rule. "no check results
observed" is reserved for a head with zero check runs. The chevron word
drops "no verdict yet" / bare "running" for the unfinished count or
names, and the tooltip composes distinct facts once.

Fixes #16630

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…text

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/ci-activity-unknown-caption branch from 43f6f31 to 76efda9 Compare November 4, 2026 22:12
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delta re-review at 76efda9 (intent-alignment). Previous findings: stale-running Active test mismatch — fixed (stage_tracker_activity_test.go:669 now asserts Active for a stale running head-wide row, matching stage_tracker_activity.go:88 out.Active = out.State == "running"); unquoted check name in the chevron JS test — fixed (stage_tracker_remediation_chevron.test.js:226 expects ('Sign-off survives')). One is still present and bears on #16630's intent:

Skipped/neutral checks keep the head-wide CI track "running" forever — src/pkg/dashboard/stage_tracker_activity.go:350-369. In stageTrackerCountHeadChecks a name is passing only when completed && success (l.355) and red only for the failure-class conclusions (l.350); a run that completed with skipped/neutral is neither, so it lands in ChecksPending (l.368) and the new switch picks State = "running" / CI running · 'docs' pending (l.377-381) for a head whose checks have all finished. The required-set path explicitly handles this (case "skipped": at l.226); the head-wide path does not. Issue #16630 asks for "running" only while checks are still running or pending; a 66-check matrix (Row B) almost always has conditional skips, so this is the mirror of the reported bug: a false "running" that never settles. Not covered by a test (stage_tracker_activity_test.go has no head-wide skipped case).

--- a/src/pkg/dashboard/stage_tracker_activity.go
+++ b/src/pkg/dashboard/stage_tracker_activity.go
@@ func stageTrackerCountHeadChecks(out *StageTrackerActivity, a *github.PRCIActivity) {
 	type tally struct {
-		passing, failing bool
+		passing, failing, skipped bool
 		since            time.Time
 	}
@@
 		if !at.Before(t.since) {
-			t.since, t.passing = at, check.State == "completed" && check.Conclusion == "success"
+			t.since = at
+			t.passing = check.State == "completed" && check.Conclusion == "success"
+			t.skipped = check.State == "completed" && (check.Conclusion == "skipped" || check.Conclusion == "neutral")
 		}
@@
 		case t.passing:
 			out.ChecksPassed++
+		case t.skipped:
+			// Finished without a verdict: not pending, not a pass.
 		default:
 			out.ChecksPending = append(out.ChecksPending, name)

The JS side has the same gap: tracker-row-strip.js:77 pendingCount = Math.max(total - passed - failed, pendingNames.length) counts a skipped check as unfinished, so even with the Go fix the default: branch (l.93) would print CI 12/13 · 1 running. When the backend sends checks_pending, trust it:

        const pendingCount = Array.isArray(a.checks_pending) && matches ? pendingNames.length : (total ? total - passed - failed : 0);

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style / maintainability re-review at 76efda9 (delta since 43f6f31). Prior findings: remediation-chevron JS quoting — fixed; stale-running head-wide Active test vs code — fixed (stage_tracker_activity_test.go:666-672 now asserts active for both polls). The head-wide skipped/neutral finding is still present and is the one thing holding this back.

1. Head-wide tally still files completed skipped/neutral runs under ChecksPending → "CI running" forever — src/pkg/dashboard/stage_tracker_activity.go:350-369. The tally only knows failing (line 350) and passing (line 355); a run with State=="completed" and Conclusion=="skipped"|"neutral" hits the default: at 367 and lands in ChecksPending, so line 375 (case len(out.ChecksPending) > 0) keeps the track running with N checks pending after every run has finished. The required-set path already settles these (:164-165), so the two paths disagree on the same run. The red-conclusion list is also now duplicated verbatim between :166 and :350, which is how this drift happened. Suggested fix (settle skipped, and reuse one classifier):

@@ func stageTrackerCountHeadChecks(out *StageTrackerActivity, a *github.PRCIActivity) {
 	type tally struct {
-		passing, failing bool
+		passing, failing, skipped bool
 		since            time.Time
 	}
@@
 		if !at.Before(t.since) {
 			t.since, t.passing = at, check.State == "completed" && check.Conclusion == "success"
+			t.skipped = check.State == "completed" && (check.Conclusion == "skipped" || check.Conclusion == "neutral")
 		}
@@
 		case t.passing:
 			out.ChecksPassed++
+		case t.skipped:
+			// A skipped or neutral run has finished; it is neither pending nor a verdict.
 		default:
 			out.ChecksPending = append(out.ChecksPending, name)

(and lift the failure|timed_out|…|stale list shared by :166 and :350 into one stageTrackerCheckConclusionRed(conclusion string) bool.)

2. Failing names in Detail bypass the new quoting helper — stage_tracker_activity.go:258 and :387 build "… already red: " + strings.Join(out.ChecksFailing, ", ") with raw names, while the PR body says names in captions/details/chevrons are single-quoted and stageTrackerPendingChecksWord (:427-435) / stageTrackerUnreportedChecksSentence (:441-447) each hand-roll the same quote-and-join loop. One helper used in all four places keeps the convention in one spot:

+// stageTrackerCheckNames quotes and comma-joins check names for prose.
+func stageTrackerCheckNames(names []string) string {
+	quoted := make([]string, 0, len(names))
+	for _, name := range names {
+		quoted = append(quoted, stageTrackerCheckName(name))
+	}
+	return strings.Join(quoted, ", ")
+}

then strings.Join(out.ChecksFailing, ", ") → stageTrackerCheckNames(out.ChecksFailing) at :258/:387, and the loops at :429-433 and :443-446 collapse to the helper.

3. Misplaced comment — stage_tracker_activity.go:231-236 describes the unreported-name/Detail rule and repeats the approve-workflows sentence already at :198-199, but the code it sits on (:237-241) only sets Since. Move the first sentence to the case "running": block at :250 and drop the duplicated gate sentence.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 8b824c4 into v5 Nov 4, 2026
83 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/ci-activity-unknown-caption branch November 4, 2026 22:25
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 2ac426b.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stage tracker: CI chevron says "activity unknown · last observed missing" / "no verdict yet" while checks are still running

1 participant