Skip to content

🐛 Activity Monitor: re-review waits on the hive reviewer; CI caption from a full check list - #16636

Merged
clubanderson merged 2 commits into
v5from
fix/rereview-pill-attribution
Nov 4, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/rereview-pill-attribution

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16635

What the operator saw (#16615, @thatguywob's clanker)

waiting on 🤖 @thatguywob · re-review pending · CI chevron ACTIVE CI 7/11 · test not reported · Review icon-only. Ground truth: head d88928e, every required check green (only prow tide pending), hive's reviewer last reviewed the previous head 6384f9b. Nothing was waiting on the author.

Root cause of the stale CI caption

graphQLPRBatchQuery asks statusCheckRollup { contexts(first: 50) } with no totalCount, and graphQLCheckRuns returned ok=true on a truncated page. d88928e had 71 check runs + 2 statuses (the test matrix alone is ~30 jobs), so the required aggregates test, golangci-lint, gosec, govulncheck fell past the page; enrichPRCI trusted the cache (source: github-graphql-cache+…) instead of its paginated REST fallback and counted them as never reported → 7/11, blocker test, state missing.

Changes

  1. Attribution (stage_tracker_rework.go, tracker-words.js): rework.owed_by is hive-reviewer on a pushed head unless the head itself asks the author for something (CI failing on it, changes requested on it, a conflict nobody in the hive is rebasing) → author. The pill reads waiting on 🐝 hive reviewer · re-review of d88928e with no author presence glyph; the author pill (with glyph) stays only when they owe. Older payloads without the field are read from the activities the same way.
  2. CI evidence (pr_batch_graphql.go): contexts(first: 100) { totalCount … }; a truncated rollup is "no listing" so enrichPRCI falls back to the paginated ListCheckRunsForRef. Prow tide is already a meta check (isMetaCheck) and never gates the verdict.
  3. Consistency (tracker-row-strip.js): a hive-owed re-review is a new-head wait, not a park on a person; with CI green the stalled-track rule lights Review (Review 0/5 · re-review of d88928e) and CI is the icon-only green ring; with CI still running, CI is lit and Review the glyph. Wording re-review pending (new head) → re-review of <sha7>.

Scoped to attribution + staleness; the CI running-vs-passing classification in stage_tracker_activity.go is untouched.

Tests

  • Go: TestStageTrackerReworkOwedBy16615, TestGraphQLCheckRunsTruncatedContextsReportsNotOK, TestStageTrackerReworkJS updated.
  • Node: #16615 cases in stage_tracker_presence.test.js (pill actor = hive reviewer, author keeps the pill only when owing) and stage_tracker_activity.test.js (Review active, CI icon-only green, exactly one active track).
  • node --test src/pkg/dashboard/*.test.js (313 pass), go test ./pkg/dashboard/ (full), go test ./pkg/github/ -run 'GraphQL|PRBatch', make dashboard-gen-check all green.

…ull check list

A pushed head whose checks are green and which carries no findings or
unrebased conflict owes nothing to its author: the re-review is the hive
reviewer's. The row says so (rework.owed_by = hive-reviewer / author),
the pill reads 'waiting on 🐝 hive reviewer · re-review of <sha7>', and the
Review chevron is the lit one with CI an icon-only green ring.

The stale 'CI 7/11 · test not reported' caption came from the GraphQL PR
batch: statusCheckRollup.contexts(first: 50) had no totalCount and a
truncated page was cached as the head's complete listing, so the required
aggregates past the page read as never reported. The query now asks for
100 with totalCount, and a truncated rollup is treated as no listing so
enrichPRCI falls back to the paginated REST check-runs.

Fixes #16635

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16637 🐛 Stage tracker: say CI running (not activity unknown) when checks are still pending same files changelog.d/fixed-rereview-pill-attribution.md
src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/stage_tracker_presence.test.js
src/pkg/dashboard/stage_tracker_rework.go
src/pkg/dashboard/stage_tracker_rework_test.go
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static-src/js/tracker-words.js
src/pkg/dashboard/static/index.html
src/pkg/github/pr_batch_graphql.go
src/pkg/github/pr_batch_graphql_status_test.go
#16634 🐛 fix(dashboard): preserve settled review verdicts and explain findings same files src/pkg/dashboard/stage_tracker_activity.test.js
src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16621 🐛 Activity Monitor: base-branch pill sits beside the repo chip same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
@clubanderson
clubanderson merged commit 73ccd4b into v5 Nov 4, 2026
81 of 82 checks passed

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read pr_batch_graphql.go, stage_tracker_rework.go, stage_tracker_build.go and the two JS files at 15e41e7 against v5, plus the cache consumer. This looks correct to me.

  • Truncation guard. graphQLContextsTruncated (pr_batch_graphql.go:374-380) compares totalCount to len(nodes); on truncation graphQLCheckRuns returns ok=false (:321) so storeGraphQLPRBatchNode never populates prBatchCheckRuns for that key (:277-289) and graphQLBatchCheckRunsObservation misses (:392), which is the REST fallback. No stale partial listing can linger: clearGraphQLPRBatchRepo runs before each repo batch (:166, :178). Fixtures without totalCount decode to 0 and stay ok=true, covered by the legacy case in TestGraphQLCheckRunsTruncatedContextsReportsNotOK.
  • Owed-by. stageTrackerReworkOwedBy (stage_tracker_rework.go:102-116) is applied after CI/review activity are derived (stage_tracker_build.go:559), so the fields it reads are populated. The JS fallback for older servers (tracker-words.js:347-355) implements the same three author-owes conditions in the same order, so a mixed-version hub/spoke renders the same pill.

CI on this head: all required checks green (only prow tide pending). Nothing blocking from my side.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow
kubestellar-prow Bot deleted the fix/rereview-pill-attribution branch November 4, 2026 18:37
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Activity Monitor: re-review pending is attributed to the PR author; CI caption stale on heads with >50 check contexts

1 participant