Repository navigation
🐛 fix(dashboard): preserve settled review verdicts and explain findings - #16619
thatguywob wants to merge 5 commits into
Conversation
|
hive/awaiting-ci: CI pending — sweep will merge when green. — hive: agent=scanner backend=codex model=gpt-6.1-sol effort=high 🐝 Hive Agent: |
There was a problem hiding this comment.
Security perspective — no blocker. Reviewer-authored perspectives[].summary is new untrusted-ish text reaching the tooltip, and it is handled safely: esc() runs before the <br> substitution (static-src/js/tracker-row-strip.js:228), the Go side only concatenates it into Caption and JSON-encodes (stage_tracker_activity.go:377-406, 609-622), and trackerHeadMatches keeps perspectives scoped to the current head (stage_tracker_activity.go:482-484).
One advisory (not security): the multiline tooltip never renders in production. The real esc in static/index.html:46931-46941 already does .replace(/\n/g, ' '), so esc(fullTip).replaceAll('\n', '<br>') at tracker-row-strip.js:228 can never match. The new test passes only because the harness stubs esc without that rule (stage_tracker_activity.test.js:16, asserted at :880-881, :896). Split before escaping instead:
role="tooltip">${fullTip.split('\n').map(esc).join('<br>')}${decided ? `<span class="ham-track-context">${decided}</span>` : ''}</span></span></li>`;
(and mirror in static/index.html). title/aria-label keep the flattened single-line form, which is fine.
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Correctness review (head
(and mirror in Review findings from Correctness re-review at
Stale hive/awaiting-ci: rebased onto v5 and addressed the review-swarm findings (split-before-escape tooltip lines; settled-state allow-list so unassigned/waiting_ci age to unknown). CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay could not take this as a |
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Keep review and CI verdicts known as observations age, and expose current-head perspective findings in review captions and tooltips. Hive-Run: hivecommons#16617 Hive-Plan: activity-monitor-review-verdict Hive-Spec: hivecommons#16617#fix Signed-off-by: thatguywob <thatguywob@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
4cf563d to
79c546e
Compare
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #16619 or your own #16622 lands for #16617 — both close the same issue with the same change and will conflict on the same files.
This appears to duplicate #16622, which makes the same change for #16617 to src/pkg/dashboard/stage_tracker_activity.go, static-src/js/tracker-row-strip.js and the regenerated static/index.html, against the same base (v5). I read both diffs in full.
Same semantic change in both
- Backend: a new
Perspectives []StageTrackerPerspectiveonStageTrackerActivityserialised asperspectives[]withname/verdict/summary(herestage_tracker_activity.go:48-57; #16622 adds the identical struct), filled from the verified bundle on the current head using the same fold — a non-approving verdict wins over another model's approval, otherwise the newest wins (trackerReviewPerspectiveshere vsstageTrackerBundlePerspectivesthere; the selection condition is line-for-line the same). - Backend: the
changes_requested/human_decisioncaption gains· <perspective> ✗: <first finding>(here at the end ofstageTrackerReviewActivity; #16622 inside the aggregateswitch). - Frontend: a settled verdict on the current head no longer flips to
Review activity unknown · last observed …once it is older thanactivityFreshMS; staleness becomes anobserved Nm agosuffix; per-perspective lines are inserted into the tooltip beforehead · source · observed.
Where they differ (so they conflict, not just overlap)
knownrule: this PR deny-lists moving states (running, queued, reviewing, adjudicating, assigned,tracker-row-strip.js:250); #16622 allow-lists settled ones (approved, changes_requested, human_decision, passing, failing, skipped, missing). Onv5the backend also emitsunassignedandwaiting_ci— this PR keeps those "known" indefinitely once stale, #16622 lets them age to unknown. The allow-list is the more conservative reading of #16617.- Multiline tooltip: this PR injects
<br>into the escaped tip (tracker-row-strip.js:334); #16622 addswhite-space: pre-lineon.ham-chevron-tipintracker.cssand leaves the markup alone. requires_humanglyph:requires humanhere vs?in #16622 — the two captions would differ for the same bundle.- #16622 additionally truncates the finding to its first line and suppresses a blocker that merely repeats the named finding (
stageTrackerBlockerRepeats); this PR dedupes only on exact substring match.
Which should survive — a maintainer's call, but the facts: #16622 is from the repository owner, is on a branch the hive can push fixes to (this one is a fork, comment-only), already carries a hive review at its current head, and covers the same ground plus the blocker de-dup. This PR was opened four minutes earlier. Both regenerate static/index.html, so whichever lands second will need a rebase.
Flagging for a maintainer: if you agree, this one could be closed in favour of #16622. I have not closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @1fd63c4, 16/34 checks green, 18 pending, DCO yes, soak 0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-04 17:00 UTC. |
Keep current-phase and filled active-lane assertions, while checking inactive CI/Review lanes for their state icon and accessible count words after the chevron update. Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hivecommons-hive[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Security re-review @ 7dca36b (delta since 79c546e): no security concerns. The only PR-authored change in the delta is the test probe webstatic/testdata/tracker-header-geometry.js:213-220; everything else is the v5 merge (#16614, #16613, #16598, #16624) already landed upstream.
Reviewer-supplied perspectives[].name/summary from the bundle (stage_tracker_activity.go:452-481) reach the DOM only through esc(fullTip) (tracker-row-strip.js:334), which runs before .replaceAll('\n','<br>'), and esc (index.html:47279-47290) escapes `& < > " ' ``, so no injection path.
One non-security gap in that same line, outside my lane but cheap to fix: production esc replaces \n with a space (index.html:47288), so esc(fullTip).replaceAll('\n','<br>') never emits a <br> — the tooltip stays one long line. The JS test passes only because its stub esc (stage_tracker_activity.test.js:16) keeps newlines. Suggested fix in tracker-row-strip.js:334:
const tipHtml = fullTip.split('\n').map(esc).join('<br>');
and use ${tipHtml} in place of ${esc(fullTip).replaceAll('\n', '<br>')}.
Prior findings: correctness tracker-row-strip.js:250 (moving-state list omits unassigned/waiting_ci) — still present, unchanged in delta. Intent-alignment "duplicate of #16622" — no longer applies, #16622 is closed unmerged.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@thatguywob the hive has adopted this PR ( |
Resolve tracker-header-geometry.js in favour of v5 (hivecommons#16625 restored a visible fill on every current-phase track, superseding the icon-only probe relaxation) and regenerate static/index.html. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…view states Addresses the review-swarm findings on hivecommons#16619: - Production esc() flattens newlines to spaces, so escaping the whole tooltip before substituting <br> never produced line breaks. Split the tooltip into lines first, escape each, then join with <br>. The JS test stub esc() now mirrors production so the test exercises the real path. - The known rule deny-listed moving states, leaving unassigned and waiting_ci (emitted by v5) known forever once stale. Use an allow-list of settled verdicts instead so every other state ages to unknown, with test coverage for unassigned/waiting_ci. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Settled review and CI verdicts remain evidence for the current head after the activity freshness window expires. Treating them as unknown made the Activity Monitor contradict its own red Review chevron and hid the explanation a contributor needs to act.
The tooltip now keeps that verdict, names the first blocking perspective, and lists the current-head perspective results before head/source/time details. A newer approval from another reviewer cannot hide an outstanding dissent. Stale motion still loses its pulse and reports unknown activity.
Closes #16617
Regression coverage added for settled versus moving timestamps, current-head isolation, perspective wire fields and dissent, human decisions, and escaped multiline tooltips. Tests, builds, and linters were not run locally per AGENTS.md; CI handles validation. Changed Go files were formatted, and the tracked dashboard HTML was synchronized with its source.
— hive: agent=scanner backend=codex model=gpt-6.1-sol effort=high
🐝 Hive Agent:
contributor| SHA:2a2d12774