Repository navigation
🐛 PR in progress chevron defers to running CI/Review and never speaks the CI verdict - #16644
Conversation
…eaks only lifecycle
Activation resolves CI and Review first: if either runs on the head the
stage chevron (PR in progress, Merge queue …) renders settled-current and
icon only, its words in the tooltip, so CI + Review is the one pair that
can be active together and every other row has exactly one active
chevron. The unpicked-up and owner-wait captions drop the red word
("Unassigned · next: scanner", "Waiting for @author · fix owed"; the
external-PR fixing word reads "Fix owed · …"); the CI / review verdict
stays in the detail. Prelude invariant over every row fixture: active set
⊆ {CI, Review} or size 1, and no stage chevron names a track verdict.
Canonical rules documented in the Activity Monitor section.
Fixes #16643
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
There was a problem hiding this comment.
Read the activation code in tracker-row-strip.js, the remediation captions in stage_tracker_remediation.go and the lane-word fallback in tracker-row.js against v5; the change is coherent and looks correct to me. One small docs gap.
Correct as far as I can verify
tracker-row-strip.js:413-414:waitingOnTracks = tracksRunning >= 1(was=== 2) plus the icon-onlycontentat:508whenwaitingOnTracks && !sg.cap && !decisiongives exactly the rule the new doc section states — the active set is ⊆ {CI, Review} or a single chevron. The tooltip prefix at:472names the one running track correctly when only one runs.stage_tracker_remediation.go:332,344: the PR-in-progress caption now carriesfix owed/UnassignedandredWordis still prepended toout.Detailin both branches, so the CI/Review verdict is not lost, only moved to the detail. The remaining"CI failing · <check> red"atstage_tracker_activity.go:211is the CI lane's own caption, which is where #16643 wants it.static/index.htmlcarries the sametracksRunning >= 1/'Fix owed'edits asstatic-src, so the regenerated bundle is in sync.- Checked for overlap with #16634 (also edits
stageTrackerActivityTrackHtmlin the same files): hunks do not touch and a three-way merge of the two heads is clean.
Finding (low, docs-currency) — src/docs/dashboard-sections/activity-monitor.md:505 still documents the lane word as Red · nobody on it; after tracker-row.js:291 that string is Fix owed · nobody on it (and Fix owed · bot PR). Line 85 of the same file was updated for the external-PR variants but this sentence was not. One-word fix.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
The darker amber the operator saw was .ham-activity-track.active.ham-stalled (a 55 % amber mix with --text) — the stalled-blocker fill from #16600 on rows where nothing moved (CI "not reported" / "no verdict yet" at 050). An active, text-bearing track now has exactly the .ham-seg.active fill; stalled keeps only its stillness and person glyph. Go CI Active follows the state (running / queued) regardless of poll freshness; the observation age rides ObservedAt for the tooltip. Invariants: every text-bearing track is plainly active (prelude over all fixtures), and no CSS rule restyles the active track background. Refs #16643 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Correctness review (read at head 72baa0b, which superseded the dispatched 923b33e)
The change does what #16643 asks: tracker-row-strip.js:413-415 resolves CI/Review first and demotes the stage chevron on tracksRunning >= 1, :505 drops its words to the tooltip, and stage_tracker_remediation.go:332-346 keeps the red verdict in Detail only. The dropped Go freshness guard (stage_tracker_activity.go:256,350) is safe: no Go code consumes CIActivity.Active, and the JS pulse is still gated by its own 2‑minute window (tracker-row-strip.js:273-278), while stageTrackerTrackRunning already counted running/queued state regardless of active (:238). Node suites stage_tracker_remediation_chevron and stage_tracker_activity pass at head (49/49); go build ./pkg/dashboard is clean.
One advisory, not blocking:
- Decision rows with CI genuinely running lose their fill.
stageTrackerTrackRunningonly ignoresdecision_needed/human_attentionon the inferred ring-not-full path (tracker-row-strip.js:249); an explicita.activeorstate: 'running'still counts (:238). WithtracksRunning >= 1the "Needs human decision" chevron now getsham-settled-current(:425) — greysurface-3— while the CI chevron is the amber one. The button is kept (:505), so nothing breaks, and it follows the issue's rule 3 literally; just flagging that a row parked on a person now visually points at CI rather than the person. If you'd rather keep the decision chevron lit, the narrowest change is to exclude decision rows from deferral:
const waitingOnTracks = tracksRunning >= 1 && !((item.decision_needed && item.decision_needed.question) || item.human_attention);
Limits: Go tests could not be run on this host (blocked for agents); CI test (dashboard */4) was still in progress when I read the head.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
CI triage (quality): The fixture passes the lifted stage-tracker row builder to Merge order: #16634 (green, waiting on tide) already converts all four 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Refs #16643 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #16643
Post-roll screenshot (row for #16634): PR in progress ACTIVE "CI failing · unassigned …" beside CI ACTIVE "CI 4/11 · 1 failing (Sign-of…". Two chevrons active that are not the CI + Review pair, and the PR in progress lane speaking the CI verdict.
JS —
tracker-row-strip.jsactivation resolutionstageTrackerTrackRunning). If either runs (tracksRunning >= 1, was=== 2), the stage chevron rendersham-settled-currentand icon only — words move to the tooltip (Waiting on CI, running — …). A decision trigger keeps its button. So the active set is ⊆ {CI, Review} or exactly one chevron; the stage chevron is the ≥ 1 fallback.tracker-row.jsstageTrackerFixingWord: "CI failing · author-owned" / "Red · nobody on it" → "Fix owed · …".Go —
stage_tracker_remediation.goUnassigned · next: scanner(· fixer queued, N aheadkept); owner wait:Waiting for @author · fix owed. The red word (CI failing / Changes requested) rides only inDetail. ConstantsprProgressUnassignedWord/prProgressFixOwedWord.Tests
TestStageTrackerRemediationCaptionNeverNamesTrackVerdict(CI red / review red / both × unassigned / owner wait) + updated captions.stage_tracker_remediation_chevron.test.js:#16634 shape— (a) CI 4/11 · 1 failing still running + unassigned ⇒ CI the only active chevron, PR in progress icon-only settled; (b) nothing running ⇒ PR in progress active "Unassigned · next: scanner", CI red icon; (c) CI + Review running ⇒ both active, stage icon-only. "three qualify" / one-track cases updated.stage_tracker_ui_prelude_test.go): if > 1 lit, no stage chevron is lit; a lit stage chevron's words never matchCI failing | CI n/m | Changes requested.Docs: canonical "Chevron activation" rules added to
docs/dashboard-sections/activity-monitor.md.Note: #16637 (open) also edits
tracker-row-strip.js/stage_tracker_activity.gofrom a pre-#16632 base; this PR is cut from current v5 and does not touch the same hunks, but #16637 will need a rebase regardless.make dashboard-gen-check,go vet,go test ./pkg/dashboard/, docs citation check green locally.Follow-up commit — one fill for an active track (same issue)
The darker amber on #16637 / #16567 was
.ham-seg.ham-activity-track.active.ham-stalled(55 % amber mix +--text): the stalled-blocker fill from #16600, applied on 050 rows where the JS running predicate saw nothing moving (CImissing"not reported" / pre-#16632unknown"no verdict yet"). Now: a text-bearing track has exactly the.ham-seg.activefill (stalled keeps stillness + person glyph); Go CIActive= running/queued regardless of poll age (age stays in the tooltip viaobserved_at); prelude invariant: every text-bearing track is plainlyactivewith no pending/todo/done/failing/settled class; CSS test: no rule sets a background on.ham-activity-track.active.