You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[scanner] Activity Monitor: 071/072 rows with a pushed/checking head still mute a running CI track #16552
stageTrackerWaitingOnPerson (src/pkg/dashboard/static-src/js/tracker-row-strip.js, added in #16545 / afaa0df) treats every 071/072 row as "waiting on a person", so CI/Review tracks are never amber there.
But tracker-row-anchor.js:29 anchors 071/072 rows whose push.state is pushed / checking at column 50 precisely because the contributor already pushed and checks are running on the new head. On those rows the strip now mutes a genuinely in-motion CI track (muted pending/settled instead of amber), contradicting #16540's own rule ("CI is amber only when at least one check-run is in_progress / queued" — and here one is).
Fix
Exempt 071/072 rows with push.state in {pushed, checking} from stageTrackerWaitingOnPerson (mirror the anchor predicate), regenerate static/index.html, and add a fixture in stage_tracker_activity.test.js for a 071 row with push.state: 'checking' and a running check asserting the CI track is active.
Provenance
This exemption was the one part of #16542 (closed as a duplicate of #16545) that #16545 did not carry over; the review on #16542 flagged it ("exempts 071/072 rows whose push.state is pushed/checking from the owner-wait, matching tracker-row-anchor.js:29"). Refs #16540, #16542, #16545.
Decision taken by hive: filed as a narrow follow-up rather than reopening #16540.
Activity