Skip to content

✨ Show ordered preparation rail without changing pipeline stages - #15910

Merged
clubanderson merged 1 commit into
v5from
fix/preparation-queue-visual-order
Oct 31, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/preparation-queue-visual-order

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • Make current-v5 preparation visible directly above the Activity Monitor as a train-style reference rail: confirmed owner first, then persisted first-admission FIFO waiters.
  • Keep actual stages, CI / Review / held signals, custom sorting, filters, pagination, issue/PR trees, and genuine ready/native train semantics unchanged.
  • Explicitly distinguish off-page/filtered members, inactive tickets and unverified recorded identities; never transfer old-head proofs or promise merge order.
  • Suppress redundant preparation/behind-owner pills only for exact-current PRs actually represented in the visible rail. Preserve fallback pills and unknown warnings elsewhere.
  • Remove preparation context from the gold header summary/popover when the rail supplies it; hide the empty ready-train chip while retaining real ready-train information.

Validation

  • Added focused CI regressions for FIFO, release/handoff, re-admission, immutable stages/train data, inactive/unverified/head mismatch, filtering/paging, linked/shared PRs, conditional pill suppression, header/popover deduplication, accessibility and escaping.
  • Regenerated the shipped dashboard SPA using make dashboard-gen.
  • No local tests, builds, lint or docs guards were run, per AGENTS. No Go files changed; CI is the sole verdict.

Scope

Reuses the existing cached base_preparation DTO and train presentation primitives. No engine/store/scheduler/DTO changes, new polling, future-integration dependency, deployment, configuration change or activation.

Owner-requested follow-up to #15887. Includes the explicit requests to remove repeated waiting-behind pills and the redundant 0 train PRs · owner · waiting header entry. Source-only merge is authorized after complete exact-head applicable CI succeeds.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15888 ✨ ioscan: accept omp as a tool-less classifier CLI backend same files src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#15871 🐛 fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-filter-render.js
src/pkg/dashboard/static/index.html
#15853 ✨ Complete native GitHub queue CI and policy integration same files src/pkg/dashboard/static/index.html
#15895 ✨ feature: add abandoned counts to contributor leaderboards same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review @ aa6594a — no blockers. Ran stage_tracker_preparation_visual.test.js against the head sources: 15/15 pass. Verified the pill-suppression path end to end: stageTrackerPreparationVisualSync runs before rows render (tracker-filter-render.js:94), rows re-render when their HTML changes (tracker-motion.js:719-722), nested PRs carry head/base_ref (stage_tracker.go LinkedPR DTO, tracker-row-layout.js:60-66), and static/index.html matches static-src.

One advisory (low, in-scope):

Rail is shown on every deployment before the first scan, even where base preparation is disabled. tracker-filter-render.js:65 calls stageTrackerPreparationVisualSync(null, …) for the initializing/no-items branch, and tracker-preparation.js:100-103 then unhides the region with "Preparation queue unavailable · waiting for a current tracker snapshot." Go only emits base_preparation for repos with RequireCurrentBaseFor (stage_tracker_preparation.go:42), so installs that never use preparation get a labelled "Preparation queues" region during load that then disappears. Previously nothing preparation-related was shown there. If that is not intended, hide the rail unless a prior payload actually carried queues:

      if (!data || !Array.isArray(data.items)) {
        const had = _stageTrackerPreparationShown.size > 0 || (el.innerHTML && el.innerHTML.indexOf('ham-preparation-group') >= 0);
        el.hidden = !had;
        if (had) el.innerHTML = '<p class="ham-preparation-note">Preparation queue unavailable · waiting for a current tracker snapshot.</p>';
        return;
      }

(adjust the inactive policy hides the rail; unavailable/loading state is explicit test accordingly.)

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit 30fc020 into v5 Oct 31, 2026
82 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/preparation-queue-visual-order branch October 31, 2026 01:11
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@clubanderson

Copy link
Copy Markdown
Member Author

Verified source delivery

  • Tested immutable head: aa6594a6607faaee0d1fb19c292d4793a6d010f9.
  • Actual squash merge: 30fc020734214df0fa0ccd038c397761ab7f9a02, merged by clubanderson at 2026-10-31T01:11:06Z.
  • All 19 latest applicable exact-head workflow/event runs were terminal success or scope-skipped: 66 checks passed, 15 scope-skipped, 0 failing or pending CI checks. This includes the complete ARM64 image-build matrix.
  • The sole remaining pending context was tide, the Prow merge controller, not CI. Used the owner's explicit standing source-merge authorization with --admin --squash --match-head-commit aa6594a6607faaee0d1fb19c292d4793a6d010f9; no checks, assertions, protections or gates were changed.
  • Verified the merged commit retains its DCO Signed-off-by. No correction commits or blind CI reruns were required.

Proofs: v2 CI, v2 Tests, complete image-build matrix.

User-visible result

The Activity Monitor has a directly visible train-style preparation reference rail: confirmed owner first, then durable first-admission FIFO waiters. It distinguishes filtered/off-page membership, inactive tickets and unverified recorded heads without promising merge order, approval or ready/native queue membership. Pipeline row stages, sorting, filters, pages and linked issue/PR trees remain unchanged.

Redundant preparation/behind-owner pills disappear only for exact-current PRs actually represented in that rail; fallback pills and unknown/CI/Review/held warnings remain. Preparation no longer repeats in the gold header chip/popover, and the zero-ready-train chip is hidden; genuine ready trains remain separate.

No DTO/store/scheduler/native backend changes, extra polling, production deployment, runtime configuration or activation were performed. CI/source delivery is not a runtime rollout claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant