Skip to content

🐛 fix: restore the inline preparation train and live comments - #15949

Merged
clubanderson merged 2 commits into
v5from
fix/preparation-inline-train
Oct 31, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/preparation-inline-train

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Approved correction

Replaces #15910's external preparation reference panel with the owner's approved compact train pill and side rail on the actual Activity Monitor rows.

  • Reuses the historical be04a9cb4cdaac3aefa65b4171d7bcb44d955f37 train's existing ham-train-head, ham-train-chip, ham-row.ham-train rail/dot geometry, ham-train-k3 palette and theme tokens. No new theme approximation.
  • Keeps actual CI/Review stages, sorts, filters, pagination, linked issue trees and real ready/native memberships unchanged. Ends rails before unrelated/backwards rows; dashed gaps and continuation headers retain truthful FIFO context.
  • Keeps live action notes, attribution, age and tuck/reopen controls. Subdued per-PR comments add current pipeline, queue context, ticket age and linked issue; no redundant preparation-owner/waiting badges or global prose panel.
  • Shows unverified recorded owners through outlined nodes and accessible styled help, without borrowing old admission-head proof or inventing confirmed positions. Store errors remain explicitly unavailable.
  • Adds CI regressions exercising the shipped root/nested row renderers and regenerates the SPA.

Review and validation

Independent code review found and corrected lost action-note controls, mixed-tree closed-child coverage, nested dashed-rail specificity, and a native-hook assertion typo.

Repository policy: no local test/build/lint/docs guards were run. The required dashboard generator was run; full exact-head CI is the sole verdict and will be owned to terminal. No deployment, rollout, live configuration or native/integration activation is included.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15871 🐛 fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static-src/js/tracker-filter-render.js
src/pkg/dashboard/static-src/js/tracker-row-layout.js
src/pkg/dashboard/static/index.html
#15948 ✨ feat: Activity Monitor am.* URL filter state and attended display mode same files src/pkg/dashboard/static/index.html
#15923 🐛 fix: declare the --sp-* spacing ramp on :root instead of only .config-modal same files src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the review swarm requested changes

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

Exact-head CI repair: first head f954e20 exposed a mutable rendered-head identity bug, a scoped selector being mistaken for the shared help-circle rule, and tests selecting continuation headers instead of exact actual row keys. Fixed the source identity and selector; kept strong row-shape assertions and made the closed-child fixture use an actually rendered superseded original. Failures inspected in jobs 124422689470 and 124422842694 (shuffle reproduced the same CSS contract; coverage failed downstream). No blind reruns, gate weakening, local suites, or citation fixer. Owning the new immutable head through full CI before guarded source merge; no rollout.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style review (head ec2efa0) — one concrete fix, one advisory.

1. Help-mark glyph is drawn via ::before, which the shared mobile .config-info recipe overwrites — src/pkg/dashboard/static-src/css/tracker.css:211 (.ham-preparation-help::before { content: '?'; }).
Every other .config-info help mark in the SPA puts the ? in text content (e.g. the section-help-mark renderer, generated static/index.html:9091 / :9099 end with >?<). responsive.css:373 repurposes .config-info::before as the tap ring with content: "" at the same specificity (0,1,1) and it is emitted later in the bundle (static/index.html:1548 vs :5987), so on narrow viewports the preparation train's help mark becomes an empty circle with no glyph. Follow the existing idiom instead:

    .ham-preparation-head .ham-preparation-help { background: none; border-color: var(--ham-train-accent); color: var(--muted); }

and in static-src/js/tracker-preparation.js:129-131 emit the glyph as content when the class is the help mark:

-    function stageTrackerPreparationTooltip(id, text, cls) {
-      return `<span class="config-info ${cls}" tabindex="0" data-stop="1" aria-label="${esc(text)}" aria-describedby="${esc(id)}"><span class="config-tooltip" id="${esc(id)}" role="tooltip">${esc(text)}</span></span>`;
+    function stageTrackerPreparationTooltip(id, text, cls, glyph) {
+      return `<span class="config-info ${cls}" tabindex="0" data-stop="1" aria-label="${esc(text)}" aria-describedby="${esc(id)}">${glyph || ''}<span class="config-tooltip" id="${esc(id)}" role="tooltip">${esc(text)}</span></span>`;

with stageTrackerPreparationHeaderHtml (tracker-preparation.js:144) passing '?'. Then regenerate the SPA. stage_tracker_preparation_visual.test.js has no assertion on the help mark, so an includes('ham-preparation-help')…'>?<' check would pin it.

2. Advisory — render-time clock through module state. tracker-preparation.js:6 introduces _stageTrackerPreparationNow, set in stageTrackerPreparationVisualSync (:83) and read by stageTrackerPreparationHelp (:122) and stageTrackerPreparationCommentHtml (:195). The surrounding row renderers thread nowMs explicitly (tracker-row-layout.js:243 stageTrackerSinceHtml(pr, nowMs), tracker-row-acted.js:150-153 "Pure: …"), and both call sites of stageTrackerPreparationCommentHtml (tracker-row-layout.js:245, :546) already have nowMs in scope. Passing it keeps the new renderers pure and unit-testable without the sync step; the duplicated typeof A === 'function' ? A(…) : typeof B === 'function' ? B(…) : '' ternary at those two lines could also collapse, since stageTrackerPreparationCommentHtml already falls back to stageTrackerEventHtml internally (tracker-preparation.js:187). Not blocking.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit 463cc52 into v5 Oct 31, 2026
80 of 81 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/preparation-inline-train branch October 31, 2026 03:35
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@clubanderson

Copy link
Copy Markdown
Member Author

Source delivery verified: guarded owner-authorized admin squash merged at 2026-10-31T03:35:42Z by clubanderson as 463cc52, now verified in origin/v5 with DCO intact. Tested immutable head: ec2efa0. Final audit: 65 passing checks, 15 scoped skips, all 17 latest workflow/event runs terminal; the only pre-merge pending context was Tide (merge controller, not CI). Actual dashboard helper output confirms all 18 preparation row/tree/identity/comment regressions passed in job 124424988420. CI: v2 CI, v2 Tests, complete image matrix. Original historical ham-train pill/rail/dot styles are reused, external prep panel removed, live comments and native hooks preserved. Independent review findings and real first-head CI failures were repaired; no blind retries or weakened gates. No rollout, deployment or live configuration change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant