Skip to content

πŸ› fix: escape channel repo names in the agent channels list - #15911

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15907
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15907

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #15907

The agent channels list renders events, patterns, schedule and match through esc(), but the repos field was joined raw into innerHTML. Owner-authored values should not reach innerHTML unescaped, so repos now uses ch.repos.map(esc).join(', ') for consistency. Regenerated static/index.html and added a source-assertion test and changelog fragment.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Closes #15907

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: f6dd3b77e

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15890 πŸ› dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html
#15871 πŸ› fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted same files src/pkg/dashboard/static/index.html
#15913 ✨ Expose Event triggers in Settings with scoped scanner presets same files src/pkg/dashboard/static-src/js/config-agent.js
src/pkg/dashboard/static/index.html
#15853 ✨ Complete native GitHub queue CI and policy integration same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

Checked against the v5 tree at 0414166:

  • esc in scope at src/pkg/dashboard/static-src/js/config-agent.js:634 is the single-argument function esc(s) defined in static-src/js/debug-logs.js:474 (same concatenated script scope the adjacent patterns/match lines already use). Passing it straight to .map(esc) is safe: the extra (index, array) arguments are ignored, and non-string entries return '' rather than throwing.
  • The new TestAgentChannelsReposEscaped reuses the existing indexHTML(t) helper (clickable_avatars_test.go:12) and asserts both the escaped form is present and the raw ch.repos.join(', ') is gone, so it fails on the pre-fix static/index.html.
  • static/index.html hunk at 53788 is byte-identical to the source change; body claim matches the diff.

No findings from a correctness, security, scope, style or docs angle. changelog.d/fixed-agent-channel-repos-esc.md follows the <category>-<slug>.md naming the fragment guard requires.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 6f030be into v5 Oct 31, 2026
84 of 88 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15907 branch October 31, 2026 01:33
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#159110414166` sha256:94abf9a215a7bb406878ac1dc8ddc9585a05bb57078d4dd7e347883a814ec6d6 β€” download from the dashboard or `hivectl review evidence #15911`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (security): Channel repos list rendered without esc()

0 participants