Repository navigation
π fix: stop filing the pre-restart kick-undeliverable warning as a fleet issue - #15315
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@odttlnt this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Read the source of the message and the matcher; this looks correct to me.
- The new benign fragment is a verbatim substring of the WARN at
src/crux/agent/busy_visibility.go:178("kick undeliverable; busy-no-activity restart not yet attempted, not self-reporting"), andIsBenignMessagelower-cases the input beforestrings.Contains(fleetreport.go,m := strings.ToLower(msg)β loop at L864), so the already-lower-case fragment matches. - The post-restart path still reports:
busy_visibility.go:187and:225observeClassKickFailedRepeatedlywith a different message, and the new test's negative cases cover that message plus the two otherkick undeliverableWARNs, so neither becomes benign by accident. - The sibling INFO at
busy_visibility.go:161("kick undeliverable while agent turn in progress; not self-reporting") is not matched by this fragment; that is fine since INFO lines are not fed to the defect filer, but worth knowing if it ever gets promoted to WARN.
No findings.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Shared CI baseline incident β not caused by this PR. The failing Tracked in #15322; fix in #15321. No action needed here β once #15321 lands, this PR will go green on its next run / rebase. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
β¦eet issue The kick-undeliverable WARN emitted before busy-no-activity restart has been attempted states that it is not self-reporting (decision B on hivecommons#12787), yet the generic repeated-error feed counted it and filed an agent_pane_timeout issue. Mark the message benign for that feed; kicks that still fail after the restart keep reporting as kick_failed_repeatedly. Hive-Run: hivecommons#15313 Hive-Plan: selfreport agent_pane_timeout, pre-restart kick-undeliverable warning Hive-Spec: fleetreport-benign-messages#kick-undeliverable-pre-restart Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com>
48a99dc to
97a705c
Compare
There was a problem hiding this comment.
Looks correct to me.
Verified against the tree:
src/crux/agent/busy_visibility.go:178emits exactlykick undeliverable; busy-no-activity restart not yet attempted, not self-reportingβ the newbenignSubstringsentry infleetreport.gois a verbatim, already-lower-case suffix of that line, andIsBenignMessagematches viastrings.Containson the lower-cased message, so the WARN is dropped by the feed.- The post-restart report (
β¦after busy-no-activity restart did not recover the sessionβ¦) does not containnot yet attempted, so it stays reportable, as the new test's negative cases assert. isBenignon the ACMM path (fleetreport.go:696) only excludes I/O timeouts and does not consultbenignSubstrings, so this change is scoped to the repeated-error feed, matching the body's claim.
Changelog fragment name follows the fixed-<issue>-β¦md convention.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Ready for a human merge: verdict approved @97a705c, 54/54 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
Test coverage (quality) β approve, no findings (read at head 97a705c).
π Hive Agent: β hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Approved by @clubanderson for Hive auto-merge on green CI.
Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hive queued this PR but could not set the |
|
Merged by hive contributor-lane auto-merge: CI green for β₯30m, reviewer verdict approve, @clubanderson approved this head as the owner decision ( |
β¦87c3cb (#15488) The post-merge trailer check failed v5 687c3cb (squash of #15315): GitHub wrote the PR author's private-email identity 91499691+odttlnt@users.noreply.github.com while the branch's Signed-off-by stayed sachin.naik@ibm.com. Same person; pre-merge DCO passed because the commits API resolves that address to @odttlnt. - check-dco-trailers.sh: same_person_noreply_evidence accepts a noreply author signed off under another address when the inspected branch's own history (DCO_SAME_PERSON_WINDOW, default 500) shows the link: authored-under-signoff-email (same name authored/committed under the sign-off address) or login-and-email-cooccur (both identities on one commit). No GitHub API call. Reported as an informational same-person-noreply line with the evidence commit, counted in the summary; a waiver on an accepted commit is STALE-WAIVER as before. DCO_SAME_PERSON_EVIDENCE_REFS adds refs for local checks. - lib-dco-identity.sh: github_noreply_login helper (pure). - Waive 687c3cb: v5 has no prior commit under the work address (only the PR branch commit 97a705c), so the heuristic has nothing to cite yet. - Self-tests for both evidence kinds, the three negatives (unknown address, different name, repeated ambiguous shape), window=0, waiver fallback, stale-waiver, evidence refs and config errors. - CONTRIBUTING.md / v5-sync-policy.md document the rule. Fixes #15401 Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Fixes #15313
crux/agent/busy_visibility.gologskick undeliverable; busy-no-activity restart not yet attempted, not self-reportingat WARN on every refused kick until the stall restart has run (decision B on #12787: that condition is a dashboard warning, not a fleet issue). The slog feed still counted the WARN, so 33 repeats in 10m crossed the threshold and filed #15313 (agent_pane_timeout).This adds the message to
benignSubstringsinpkg/fleetreport/fleetreport.go, so the generic feed drops it. The WARN stays in local logs. Kicks that keep failing after the restart still report viakick_failed_repeatedly(different message), and other kick-undeliverable warnings remain reportable.Tests:
TestIsBenignMessageKickUndeliverableBeforeRestart(positive case plus the post-restart report and other kick warnings as negatives). Not run locally per AGENTS.md (CI is the verdict; no Go toolchain here).β hive: backend=bob model=premium