Skip to content

πŸ› fix(dashboard): pass open resolver in linked-progress test so v5 compiles - #15321

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-v5-linked-progress-test
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-v5-linked-progress-test

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Why

v5 is red on every pkg/dashboard shard (scheduled run 40823901692):

pkg/dashboard/stage_tracker_linked_progress_test.go:95:31: not enough arguments in call to stageTrackerResolveLinkedPRs
pkg/dashboard/stage_tracker_linked_progress_test.go:101:31: not enough arguments in call to stageTrackerResolveLinkedPRs

#15267 added an open resolver parameter to stageTrackerResolveLinkedPRs; #15236 landed alongside it with a test that still uses the one-argument form. Each PR was green on its own base, so CI could not see the pair conflict until both were on v5. Every open PR against v5 now inherits this failure (e.g. #15314, #15315, #15316, #15300, #15304), so this is one baseline incident rather than N PR failures.

Test-only change; passes nil exactly as stage_tracker_test.go already does, so no behaviour changes and no changelog fragment is needed.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Closes #15322

#15236 and #15267 landed on v5 independently: #15267 added an 'open'
parameter to stageTrackerResolveLinkedPRs while #15236 added a test
that still calls the old one-argument form, so every pkg/dashboard
shard fails to compile on v5. Pass nil like stage_tracker_test.go does.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15324 πŸ› fix(dashboard): pass PR-open predicate to stageTrackerResolveLinkedPRs calls same files src/pkg/dashboard/stage_tracker_linked_progress_test.go

@thatguywob

Copy link
Copy Markdown
Contributor

This PR fully covers #15322: its two call-site updates match the new resolver signature and the fix scoped by the issue. A maintainer can add Fixes #15322 to the PR body so merging it closes the issue; a closing keyword in this comment does not establish that automatic closure.

β€” hive: backend=codex


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm #15321 can be closed as a no-op now that #15301 (2f05d8e) already landed the identical two-line fix on v5.

This change is correct but has already landed on v5, so merging it would be a no-op.

What I verified:

  • The diff here is exactly two lines: stageTrackerResolveLinkedPRs(items) β†’ stageTrackerResolveLinkedPRs(items, nil) at src/pkg/dashboard/stage_tracker_linked_progress_test.go:95 and :101.
  • #15301 merged as 2f05d8e18 (2026-10-29 01:46 -0400) and its diff to this same file is byte-identical: same two lines, same nil argument.
  • origin/v5 HEAD (19b17ed37) already compiles the two-argument form: stage_tracker.go:2948 is func stageTrackerResolveLinkedPRs(items []StageTrackerItem, open func(repo string, number int) bool) and every caller in pkg/dashboard now passes two arguments.

The diagnosis in the body was right (the #15236 / #15267 pair conflict), and the nil choice matches stage_tracker_test.go:662. Nothing wrong with this PR β€” it just lost the race. Flagging for a maintainer: this one can be closed in favour of #15301. I have not closed anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Needs a decision, not a merge:

Head: verdict requires_human @399fbdc, 66/66 checks green, DCO yes, soak 0s of 30m0s.

What to do: approve this head (399fbdc) to merge as-is, or leave a changes requested review (or reply /hive decision <what to change>) and the hive will push the fix.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Closing as redundant: #15301 (2f05d8e18) landed the byte-identical two-line fix to stage_tracker_linked_progress_test.go on v5 before this merged, and v2 Tests on v5 has been green since that commit (runs for 2f05d8e, 79f2ff4, 19b17ed all succeeded). Nothing left for this PR to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shared-ci] test (dashboard 1/4) failing across hivecommons/hive

1 participant