Repository navigation
π fix(dashboard): pass open resolver in linked-progress test so v5 compiles - #15321
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
#15236 and #15267 landed on v5 independently: #15267 added an 'open' parameter to stageTrackerResolveLinkedPRs while #15236 added a test that still calls the old one-argument form, so every pkg/dashboard shard fails to compile on v5. Pass nil like stage_tracker_test.go does. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
This PR fully covers #15322: its two call-site updates match the new resolver signature and the fix scoped by the issue. A maintainer can add β hive: backend=codex π Hive Agent: |
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm #15321 can be closed as a no-op now that #15301 (2f05d8e) already landed the identical two-line fix on v5.
This change is correct but has already landed on v5, so merging it would be a no-op.
What I verified:
- The diff here is exactly two lines:
stageTrackerResolveLinkedPRs(items)βstageTrackerResolveLinkedPRs(items, nil)atsrc/pkg/dashboard/stage_tracker_linked_progress_test.go:95and:101. - #15301 merged as
2f05d8e18(2026-10-29 01:46 -0400) and its diff to this same file is byte-identical: same two lines, samenilargument. origin/v5HEAD (19b17ed37) already compiles the two-argument form:stage_tracker.go:2948isfunc stageTrackerResolveLinkedPRs(items []StageTrackerItem, open func(repo string, number int) bool)and every caller inpkg/dashboardnow passes two arguments.
The diagnosis in the body was right (the #15236 / #15267 pair conflict), and the nil choice matches stage_tracker_test.go:662. Nothing wrong with this PR β it just lost the race. Flagging for a maintainer: this one can be closed in favour of #15301. I have not closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @399fbdc, 66/66 checks green, DCO yes, soak 0s of 30m0s. What to do: approve this head ( How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Why
v5is red on everypkg/dashboardshard (scheduled run 40823901692):#15267 added an
openresolver parameter tostageTrackerResolveLinkedPRs; #15236 landed alongside it with a test that still uses the one-argument form. Each PR was green on its own base, so CI could not see the pair conflict until both were onv5. Every open PR againstv5now inherits this failure (e.g. #15314, #15315, #15316, #15300, #15304), so this is one baseline incident rather than N PR failures.Test-only change; passes
nilexactly asstage_tracker_test.goalready does, so no behaviour changes and no changelog fragment is needed.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
Closes #15322