Repository navigation
🐛 fix: classify proxy plain-HTTP private-destination refusals in selfreport - #15393
Conversation
…report Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Reviewed (security) — no blocking findings.
Advisory (low): src/docs/fleet-report.md:159 and changelog.d/fixed-15391.md describe the new class as "a client ignored its proxy bypass for a private address". The WARN it keys on (src/crux/proxy/github_proxy_connect.go:673-675) is also emitted for class=link-local (cloud metadata), CGNAT and multicast, which the proxy's own comment (github_proxy_connect.go:665-667) treats as an attempt to reach the estate behind the proxy, not a misconfiguration. Suggest the doc row mention checking the class= attribute in the filed issue's diagnostics so a link-local burst isn't read as a NO_PROXY typo. Severity, violation counting and issue filing are otherwise unchanged (runtime.go:177 vs :195).
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
The proxy's refusal of plain-HTTP forwards to private destinations is an expected policy decision, already counted as a violation, but its repeated WARN fell through to the generic unclassified_error_repeated class and filed fleet issues. It now has a dedicated log-fed class, proxy_plain_forward_refused, following the existing proxy classes, with test and docs coverage.
Closes #15391
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88