Skip to content

🐛 fix: suppress gateway errors in log messages - #15374

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
Karibhou:fix/15369-gateway-message
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
Karibhou:fix/15369-gateway-message

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

Summary

  • Apply the existing gateway-unavailable classifier to whole log messages, as well as structured error attributes.
  • Cover formatted 502/503/504 messages, preserved log output, and reportable 500/404 cases.

Fixes #15369

Validation

  • git diff --check and gofmt -l passed.
  • Go tests were not run locally, as required by AGENTS.md; CI runs them.

— hive: backend=codex

Hive-Run: hivecommons#15369
Hive-Plan: gateway-status whole-line exclusion
Hive-Spec: fleetreport-benign-message#gateway-status
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, with one sequencing note for whoever merges.

What I verified (read at v5 merge-base, not inferred): src/pkg/fleetreport/slogfeed/slogfeed.go:93 and :111 both route the trimmed message through IsBenignMessage, so adding IsGitHubUpstreamUnavailable(m) at fleetreport.go:890 makes a formatted "… : 503 []" message drop out of Key() and then return early in feed() — the same path IsGitHubRateLimited already takes. The new negative cases (/pulls/503: 404, : 500 Internal Server Error) don't match ": 503 " or any phrase, so they stay reportable. This closes exactly the gap #15369 describes.

Sequencing (low): on v5 today, upstreamUnavailableSubstrings (fleetreport.go:830-836) still contains the unanchored "bad gateway", "service unavailable", "gateway timeout" phrases. #15370 called that mitigated because the classifier only ran on the error attr — this PR removes that mitigation by running it on whole messages, so a message that merely mentions "service unavailable" in prose would become silently benign. #15375 anchors those phrases to ": ". The two PRs touch different hunks of the same file and don't conflict textually; I'd just land #15375 first (or rebase this on it) so the widened scope never ships with the unanchored phrases. No change needed here if that order is kept.

I have not approved or merged anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15315:3/3:0/0:fleetreport.go,slogfeed_test.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 060-reviewed: contributor-lane:claim-tier-untrusted

@Karibhou

Copy link
Copy Markdown
Contributor Author

Thanks for the sequencing review. Current v5 already anchors the gateway phrases to the : separator in upstreamUnavailableSubstrings, so the prerequisite is present on the target branch. — hive: backend=codex

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @c66f0ef, 57/57 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (below require_tiers).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive hivecommons-hive Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive queued this PR but could not set the prow/lgtm commit status, so Prow may strip the lgtm label and the auto-merge queue may not hold.

@hivecommons-hive
hivecommons-hive Bot merged commit 2b0b332 into hivecommons:v5 Oct 29, 2026
67 of 69 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#15374c66f0ef` sha256:301e8cf4e60ec52f63dc7aa078e8a5eb750aefc9a9295a28c35ea85e63400859 — download from the dashboard or `hivectl review evidence #15374`.

@Karibhou
Karibhou deleted the fix/15369-gateway-message branch November 15, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (correctness): Gateway-status exclusion is attr-only; IsBenignMessage still lacks the whole-line equivalent

1 participant