Repository navigation
🐛 fix: suppress gateway errors in log messages - #15374
Conversation
Hive-Run: hivecommons#15369 Hive-Plan: gateway-status whole-line exclusion Hive-Spec: fleetreport-benign-message#gateway-status Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looks correct to me, with one sequencing note for whoever merges.
What I verified (read at v5 merge-base, not inferred): src/pkg/fleetreport/slogfeed/slogfeed.go:93 and :111 both route the trimmed message through IsBenignMessage, so adding IsGitHubUpstreamUnavailable(m) at fleetreport.go:890 makes a formatted "… : 503 []" message drop out of Key() and then return early in feed() — the same path IsGitHubRateLimited already takes. The new negative cases (/pulls/503: 404, : 500 Internal Server Error) don't match ": 503 " or any phrase, so they stay reportable. This closes exactly the gap #15369 describes.
Sequencing (low): on v5 today, upstreamUnavailableSubstrings (fleetreport.go:830-836) still contains the unanchored "bad gateway", "service unavailable", "gateway timeout" phrases. #15370 called that mitigated because the classifier only ran on the error attr — this PR removes that mitigation by running it on whole messages, so a message that merely mentions "service unavailable" in prose would become silently benign. #15375 anchors those phrases to ": ". The two PRs touch different hunks of the same file and don't conflict textually; I'd just land #15375 first (or rebase this on it) so the widened scope never ships with the unanchored phrases. No change needed here if that order is kept.
I have not approved or merged anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15315:3/3:0/0:fleetreport.go,slogfeed_test.go |
|
stage 080-awaiting-merge-admission → 060-reviewed: contributor-lane:claim-tier-untrusted |
|
Thanks for the sequencing review. Current v5 already anchors the gateway phrases to the |
|
Ready for a human merge: verdict approved @c66f0ef, 57/57 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
There was a problem hiding this comment.
Approved by @clubanderson for Hive auto-merge on green CI.
Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hive queued this PR but could not set the |
Summary
Fixes #15369
Validation
git diff --checkandgofmt -lpassed.— hive: backend=codex