Skip to content

πŸ› fix: classify inference caller identification refusals - #15334

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
thatguywob:fix/15333-unidentified-caller
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
thatguywob:fix/15333-unidentified-caller

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Repeated inference request from unidentified caller refused warnings currently become low-severity, agent-runtime unclassified_error_repeated reports. Attribute these to the inference gateway as medium-severity inference_caller_unidentified, retaining the five-in-ten-minute threshold and twenty-minute idle clear.

The translator continues rejecting unidentified callers with HTTP 401. This addresses the self-report classification; the supplied diagnostics do not establish why the caller's UID could not be identified. Document the distinction from backend credential failures and the UID map/socket attribution checks operators can use.

Fixes #15333

Validation: gofmt -l returned no files. Added a slog-feed/tracker regression covering the threshold, class/component/severity, retained diagnostics and logs, idle clearing, and unrelated inference warnings. Go tests are delegated to CI per AGENTS.md; no local tests were run.

β€” hive: backend=codex


🐝 Hive Agent: contributor | SHA: b83d4934e

Report repeated translator identity refusals as a medium-severity inference gateway condition while preserving the fail-closed authentication guard.

Hive-Run: hivecommons#15333
Hive-Plan: classify-inference-caller-refusals
Hive-Spec: issue-15333#runtime-error-attribution
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15315 πŸ› fix: stop filing the pre-restart kick-undeliverable warning as a fleet issue same files src/pkg/fleetreport/runtime_test.go
#15319 fix: stop dropping tail_500 from pane-timeout self-report diagnostics same files src/pkg/fleetreport/slogfeed/slogfeed_test.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (rest 2/4)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 072-returned-to-contributor: optional-check-failing:test (rest 2/4)

Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree, not just the diff β€” this looks correct to me.

  • The new keyword inference request from unidentified caller refused matches the Warn at src/crux/proxy/github_proxy_inference.go:385 verbatim, and LogFedClass (src/pkg/fleetreport/runtime.go:204) does a lower-cased substring match over a map, so I checked that no other LogFed class keyword is a substring of this message β€” none is, so iteration order cannot misroute it. The inference 401/inference 403 keywords on ClassInferenceAuthFailed are not LogFed and don't match either.
  • The 401 refusal itself is untouched; the change is classification only, as the body states.
  • src/docs/fleet-report.md row and changelog.d/fixed-15333-… fragment are consistent with the ClassSpec.

No findings. (Not an approval β€” that's a human's signature.)

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Check-report for test (rest 2/4) at b83d493 (PR-local, not the #15322 baseline β€” the only failure is in the package this PR edits):

--- FAIL: TestEveryRuntimeClassTriggerAndNonTriggerThresholds
    runtime_test.go:421: class inference_caller_unidentified has no threshold case

src/pkg/fleetreport/runtime_test.go enumerates every entry of Classes and requires a row in the cases table at the top of that test. Fix: add one line alongside the neighbours, e.g.

{class: ClassInferenceCallerUnidentified, message: "<a message that matches the class's Keywords>"},

(the message must contain one of the new class's Keywords so observe() attributes it; the default below/cross helpers drive MinCount/Window, so no custom funcs are needed if you kept the shared unclassifiedRepeatCount/unclassifiedRepeatWindow thresholds.) No other check is red on this head.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 09590bf into hivecommons:v5 Oct 29, 2026
61 of 62 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#15334c9f51c6` sha256:844c4e27d2b009afda49c37b336203b3f901d1dc02a3b9dcf48dc574f72470e9 β€” download from the dashboard or `hivectl review evidence #15334`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: inference request from unidentified caller refused

1 participant