Repository navigation
π fix: classify inference caller identification refusals - #15334
hivecommons-hive[bot] merged 2 commits into
Conversation
Report repeated translator identity refusals as a medium-severity inference gateway condition while preserving the fail-closed authentication guard. Hive-Run: hivecommons#15333 Hive-Plan: classify-inference-caller-refusals Hive-Spec: issue-15333#runtime-error-attribution Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
stage 080-awaiting-merge-admission β 072-returned-to-contributor: optional-check-failing:test (rest 2/4) |
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
There was a problem hiding this comment.
Read the tree, not just the diff β this looks correct to me.
- The new keyword
inference request from unidentified caller refusedmatches theWarnatsrc/crux/proxy/github_proxy_inference.go:385verbatim, andLogFedClass(src/pkg/fleetreport/runtime.go:204) does a lower-cased substring match over a map, so I checked that no otherLogFedclass keyword is a substring of this message β none is, so iteration order cannot misroute it. Theinference 401/inference 403keywords onClassInferenceAuthFailedare notLogFedand don't match either. - The 401 refusal itself is untouched; the change is classification only, as the body states.
src/docs/fleet-report.mdrow andchangelog.d/fixed-15333-β¦fragment are consistent with theClassSpec.
No findings. (Not an approval β that's a human's signature.)
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Check-report for
{class: ClassInferenceCallerUnidentified, message: "<a message that matches the class's Keywords>"},(the π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Repeated
inference request from unidentified caller refusedwarnings currently become low-severity, agent-runtimeunclassified_error_repeatedreports. Attribute these to the inference gateway as medium-severityinference_caller_unidentified, retaining the five-in-ten-minute threshold and twenty-minute idle clear.The translator continues rejecting unidentified callers with HTTP 401. This addresses the self-report classification; the supplied diagnostics do not establish why the caller's UID could not be identified. Document the distinction from backend credential failures and the UID map/socket attribution checks operators can use.
Fixes #15333
Validation:
gofmt -lreturned no files. Added a slog-feed/tracker regression covering the threshold, class/component/severity, retained diagnostics and logs, idle clearing, and unrelated inference warnings. Go tests are delegated to CI per AGENTS.md; no local tests were run.β hive: backend=codex
π Hive Agent:
contributor| SHA:b83d4934e