Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- The repeated-error feed no longer files the "kick undeliverable; busy-no-activity restart not yet attempted, not self-reporting" warning as a fleet issue; kicks that keep failing after the stall restart are still reported ([#15313](https://github.com/hivecommons/hive/issues/15313)).
8 changes: 8 additions & 0 deletions src/pkg/fleetreport/fleetreport.go
Original file line number Diff line number Diff line change
Expand Up @@ -787,6 +787,14 @@ var benignSubstrings = []string{
// is a per-hive operational signal, not a runtime error
// (hivecommons/hive#15009).
"stage labels: pr waits on the hive past the stage dwell",
// The kick-undeliverable WARN (src/crux/agent/busy_visibility.go) says in
// its own message that it is not self-reporting: until busyNoActivityStall
// has restarted the pane the condition is a dashboard warning and a log
// line only (decision B on hivecommons/hive#12787). The WARN repeats on
// every refused kick, so the generic feed filed it as a repeated runtime
// defect anyway (hivecommons/hive#15313). Kicks that keep failing after
// the restart are reported under kick_failed_repeatedly instead.
"busy-no-activity restart not yet attempted, not self-reporting",
}

// rateLimitSubstrings are lower-case fragments that mark a GitHub rate-limit
Expand Down
19 changes: 19 additions & 0 deletions src/pkg/fleetreport/runtime_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,25 @@ func TestIsBenignMessageForwardMergeGuard(t *testing.T) {
}
}

// hivecommons/hive#15313: the kick-undeliverable WARN that says it is not
// self-reporting must not be filed as a repeated runtime defect, while the
// post-restart kick_failed_repeatedly report and the WARNs that do report
// stay reportable.
func TestIsBenignMessageKickUndeliverableBeforeRestart(t *testing.T) {
if !IsBenignMessage("kick undeliverable; busy-no-activity restart not yet attempted, not self-reporting") {
t.Error("pre-restart kick-undeliverable warning not benign")
}
for _, m := range []string{
"kick undeliverable 4 times in a row after busy-no-activity restart did not recover the session (CLI did not reach input prompt; restarted 1m0s ago at 2026-10-29T05:00:00Z, 1 restart(s) this episode)",
"kick undeliverable: TUI menu did not close after Escape",
"re-engagement kick undeliverable; budget not charged",
} {
if IsBenignMessage(m) {
t.Errorf("%q wrongly benign", m)
}
}
}

func TestIsBenignMessageStageHiveHeld(t *testing.T) {
if !IsBenignMessage("stage labels: PR waits on the hive past the stage dwell — reviewer lane needs attention") {
t.Error("hive-held stage dwell warning not benign")
Expand Down
Loading