Skip to content

✨ Improve collapsed Advisory and ACMM headers - #10618

Merged
clubanderson merged 1 commit into
v5from
feat/advisory-acmm-collapsed-headers
Oct 5, 2026
Merged

clubanderson merged 1 commit into
v5from
feat/advisory-acmm-collapsed-headers

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Replace the collapsed Advisory mini count/sparkline with up to three weekly Hive Advice pills and a healthy fallback.
  • Replace the collapsed ACMM Eval seven-level mini dial with a readable level/dimension status pill and tooltip.
  • Add static dashboard contract tests and update the visual summary node fixture.

Validation

  • gofmt -l pkg/dashboard/advisory_acmm_collapsed_headers_test.go pkg/dashboard/dashboard_section_visual_summaries_test.go
  • targeted node helper check for Advisory and ACMM collapsed summaries
  • git diff --check origin/v5...HEAD

Note: per AGENTS.md, no local go test/go build was run; CI is the verdict.

  • CI follow-up: refreshed api-reference citations after CI drift report and replaced unsupported Go regexp lookahead in feedback login validation.
  • CI follow-up: documented /api/feedback/status in OpenAPI and refreshed the style-ratchet baseline to match current static HTML counts reported by CI.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10602 ✨ feat: label-driven repos skip un-park notice and keep needs-human same files dashboard/openapi.json
#10613 ✨ dashboard: Review Queue collapsed row shows a priority-split history sparkline same files src/pkg/dashboard/static/index.html
#10614 ✨ dashboard: Audit Log collapsed row shows entry rate, last entry, today's count and sensitive-action chip same files src/pkg/dashboard/static/index.html
#10638 🐛 dashboard: Overview open-issue/PR totals explain their gap to the forge counts same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from 181883c to 5e0e096 Compare October 5, 2026 16:14
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Shared CI incident: the red checks on this PR (docker (hive), overlayfs-exec-guard, golangci-lint, relative links and anchors resolve, pkg/dashboard/pkg/hub test shards incl. TestAgentsCollapsedSummaryRendersPerAgentTiles / TestOpenAPISpecCoversEveryRegisteredRoute) are the v5 baseline breakage tracked in #10623, not this diff. Fix is carried by #10612; this PR is deferred until it lands, then needs a v5 merge/re-run.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from cd3be50 to 0fde3dd Compare October 5, 2026 16:28
@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2026
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from b3012de to b182984 Compare October 5, 2026 16:40
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from 8187e58 to 3f0a275 Compare October 5, 2026 16:49
@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2026
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from 3f0a275 to b2ee720 Compare October 5, 2026 17:00
@kubestellar-prow kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 5, 2026
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from b2ee720 to 01fec08 Compare October 5, 2026 17:14
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2026
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from 32b963d to 4cb1651 Compare October 5, 2026 17:26
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from 7cf3eae to 3064ee0 Compare October 5, 2026 17:37
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from 9437d76 to e49be48 Compare October 5, 2026 17:50
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the feat/advisory-acmm-collapsed-headers branch from 76298c5 to 5ecda66 Compare October 5, 2026 18:01
@clubanderson
clubanderson merged commit 84d54fa into v5 Oct 5, 2026
5 checks passed
@clubanderson
clubanderson deleted the feat/advisory-acmm-collapsed-headers branch October 5, 2026 18:02
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Changelog fragment needed

This PR changes code under src/ but has no changelog.d/ fragment and no no-changelog label, so the changelog-fragment-guard check fails.

Pick one:

A. The change is user-visible (feature, fix, new env var, behavior/security change) — add one file and push:

# category: added | changed | deprecated | fixed | security
echo '- <one-line entry in the style of CHANGELOG.md>' > changelog.d/<category>-10618.md
git add changelog.d && git commit -s -m "changelog: fragment for #10618"

B. Not user-visible (refactor, internal test plumbing, CI) — ask a maintainer to add the no-changelog label.

Do not edit CHANGELOG.md directly; the release compiler assembles it from fragments (see changelog.d/README.md, #5675). This comment is removed automatically once the check passes.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant