Repository navigation
π dashboard: remove unlabelled collapsed sparklines - #10611
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
99b38ae to
6ddca95
Compare
6ddca95 to
ee28a94
Compare
There was a problem hiding this comment.
Conclusion: the sparkline removal itself is straightforward, but this PR bundles three undisclosed changes that each collide with another open PR β and one of them is the opposite fix to #10612 for the same failing test. Recommend trimming to the index.html + test changes before a maintainer reviews it further. I have not changed anything.
1. Opposite fix to #10612 β src/pkg/dashboard/openapi_route_parity_test.go (medium).
This adds GET /api/feedback/status to the parity test's exclusion list with the reason "browser-only β¦ not a public data API". #10612 instead documents the route in dashboard/openapi.json. Both make TestOpenAPISpecCoversEveryRegisteredRoute pass; both cannot be the project's answer. The route is registered at pkg/dashboard/api.go:67 and the existing exclusions (openapi_route_parity_test.go:50-60) are all k8s probes β /healthz-class endpoints β so a session-attribution JSON API is a stretch for that list. Not mentioned in the body. A maintainer needs to pick one; I lean toward #10612's.
2. Fifth concurrent regexp rewrite β src/pkg/dashboard/feedback.go, src/pkg/hub/feedback.go (low).
Also not in the body. ^[A-Za-z0-9][A-Za-z0-9-]{0,38}(?:\[bot\])?$ plus the HasSuffix(name, "-") / Contains(name, "--") guards is functionally correct (39-cap, no leading/trailing/double hyphen). But #10612, #10617, #10589 and #10594 each rewrite the same two lines differently; whichever lands first, the other four need rebasing. This hunk should live in exactly one of them.
3. src/docs/api-reference.md refresh duplicates #10608 (and #10594). Not in the body.
4. Direct conflict with #10614 β static/index.html. Both PRs edit the same else if (sectionId === 'knowledge-section' || sectionId === 'audit-section') branch. This PR replaces the audit sparkline with miniText(...); #10614 keeps a ${spark} and builds a richer audit collapsed row around it. These are opposite design decisions on the same element, not a textual nit β if "remove unlabelled sparklines" is the policy, #10614's new audit spark is labelled (aria-label, last-entry, today-count), so it may be fine, but someone should say so explicitly on #10614.
Question for a maintainer: should /api/feedback/status be documented in openapi.json (#10612) or excluded from parity as browser-only (this PR)?
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
ee28a94 to
9f349fc
Compare
9f349fc to
f5721b6
Compare
f5721b6 to
29df205
Compare
29df205 to
0d35bb4
Compare
0d35bb4 to
8af96d0
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com>
8af96d0 to
5afd846
Compare
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
Validation
Note: per AGENTS.md, local go test/go build were not run; CI is the verdict.