Skip to content

πŸ› dashboard: remove unlabelled collapsed sparklines - #10611

Merged
clubanderson merged 1 commit into
v5from
fix/knowledge-collapsed-sparklines
Oct 5, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/knowledge-collapsed-sparklines

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • identify and remove unlabelled collapsed Knowledge sparklines
  • remove other bare collapsed-summary sparklines that lacked visible context
  • keep labelled/value-backed collapsed trends and expanded dashboard content intact

Validation

  • gofmt -l src/pkg/dashboard/dashboard_section_visual_summaries_test.go src/pkg/dashboard/dashboard_section_summaries_test.go
  • git diff --check
  • node syntax/visual-summary harness for src/pkg/dashboard/static/index.html

Note: per AGENTS.md, local go test/go build were not run; CI is the verdict.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10647 πŸ› dashboard: hide Clear filter / Rescan / Reset layout while Projects is collapsed same files src/pkg/dashboard/static/index.html
#10614 ✨ dashboard: Audit Log collapsed row shows entry rate, last entry, today's count and sensitive-action chip CONFLICT src/pkg/dashboard/static/index.html
#10613 ✨ dashboard: Review Queue collapsed row shows a priority-split history sparkline same files src/pkg/dashboard/static/index.html
#10645 πŸ› dashboard: time-window filter pills clipped behind following tile same files src/pkg/dashboard/static/index.html
#10638 πŸ› dashboard: Overview open-issue/PR totals explain their gap to the forge counts same files src/pkg/dashboard/static/index.html
#10619 ✨ dashboard: move project actions to toolbar same files src/pkg/dashboard/static/index.html
#10646 🌱 dashboard: restore shaded-area hive-vs-human graph in expanded throughput same files src/pkg/dashboard/static/index.html
#10640 πŸ› dashboard: surface alerts section at top of page same files src/pkg/dashboard/static/index.html
src/pkg/dashboard/webstatic/style_ratchet_test.go
#10618 ✨ Improve collapsed Advisory and ACMM headers same files src/pkg/dashboard/dashboard_section_visual_summaries_test.go
src/pkg/dashboard/static/index.html
src/pkg/dashboard/webstatic/style_ratchet_test.go
#10589 πŸ› fix: route reporter-trust waits through poller relay same files src/pkg/dashboard/static/index.html
src/pkg/hub/stable_promotion.go
#10606 ✨ dashboard: upgrade bee animation in the top navbar; sidebar pill no longer clips same files src/pkg/dashboard/static/index.html
#10630 πŸ› hub: cache stable-promotion status and use authenticated GitHub reads same files src/pkg/hub/stable_promotion.go
#10633 ✨ dashboard: expose Wavefront (Crustify) work source in settings same files src/pkg/dashboard/static/index.html

@clubanderson
clubanderson force-pushed the fix/knowledge-collapsed-sparklines branch from 99b38ae to 6ddca95 Compare October 5, 2026 15:52
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
@clubanderson
clubanderson force-pushed the fix/knowledge-collapsed-sparklines branch from 6ddca95 to ee28a94 Compare October 5, 2026 16:08
@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: the sparkline removal itself is straightforward, but this PR bundles three undisclosed changes that each collide with another open PR β€” and one of them is the opposite fix to #10612 for the same failing test. Recommend trimming to the index.html + test changes before a maintainer reviews it further. I have not changed anything.

1. Opposite fix to #10612 β€” src/pkg/dashboard/openapi_route_parity_test.go (medium).
This adds GET /api/feedback/status to the parity test's exclusion list with the reason "browser-only … not a public data API". #10612 instead documents the route in dashboard/openapi.json. Both make TestOpenAPISpecCoversEveryRegisteredRoute pass; both cannot be the project's answer. The route is registered at pkg/dashboard/api.go:67 and the existing exclusions (openapi_route_parity_test.go:50-60) are all k8s probes β€” /healthz-class endpoints β€” so a session-attribution JSON API is a stretch for that list. Not mentioned in the body. A maintainer needs to pick one; I lean toward #10612's.

2. Fifth concurrent regexp rewrite β€” src/pkg/dashboard/feedback.go, src/pkg/hub/feedback.go (low).
Also not in the body. ^[A-Za-z0-9][A-Za-z0-9-]{0,38}(?:\[bot\])?$ plus the HasSuffix(name, "-") / Contains(name, "--") guards is functionally correct (39-cap, no leading/trailing/double hyphen). But #10612, #10617, #10589 and #10594 each rewrite the same two lines differently; whichever lands first, the other four need rebasing. This hunk should live in exactly one of them.

3. src/docs/api-reference.md refresh duplicates #10608 (and #10594). Not in the body.

4. Direct conflict with #10614 β€” static/index.html. Both PRs edit the same else if (sectionId === 'knowledge-section' || sectionId === 'audit-section') branch. This PR replaces the audit sparkline with miniText(...); #10614 keeps a ${spark} and builds a richer audit collapsed row around it. These are opposite design decisions on the same element, not a textual nit β€” if "remove unlabelled sparklines" is the policy, #10614's new audit spark is labelled (aria-label, last-entry, today-count), so it may be fine, but someone should say so explicitly on #10614.

Question for a maintainer: should /api/feedback/status be documented in openapi.json (#10612) or excluded from parity as browser-only (this PR)?

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson force-pushed the fix/knowledge-collapsed-sparklines branch from f5721b6 to 29df205 Compare October 5, 2026 16:39
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
@clubanderson
clubanderson force-pushed the fix/knowledge-collapsed-sparklines branch from 29df205 to 0d35bb4 Compare October 5, 2026 16:48
@kubestellar-prow kubestellar-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 5, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 5, 2026
@clubanderson
clubanderson force-pushed the fix/knowledge-collapsed-sparklines branch from 0d35bb4 to 8af96d0 Compare October 5, 2026 17:00
@github-actions github-actions Bot added conflicts-with-open-pr Open PR has a merge conflict with another open PR and removed conflicts-with-open-pr Open PR has a merge conflict with another open PR labels Oct 5, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant