Skip to content

πŸ› dashboard: time-window filter pills clipped behind following tile - #10645

Merged
clubanderson merged 3 commits into
v5from
fix/filter-pills-overlap
Oct 5, 2026
Merged

clubanderson merged 3 commits into
v5from
fix/filter-pills-overlap

Conversation

@clubanderson

@clubanderson clubanderson commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Move PR throughput time-window pills back into normal grid flow instead of absolutely positioning them over the metric tiles.
  • Let the pill row wrap and grow the headline area at narrow widths, aligned right on desktop and left on mobile.
  • Move the Hive vs human role dropdown from the tile's top-right corner to the lower-right corner, and constrain that tile's sparkline so the compact select does not overlap it.
  • Pin both layout contracts in the dashboard throughput UI test so the controls do not regress to out-of-flow overlays.

Root cause

The PR throughput window controls were absolutely positioned inside .prt-headline with a fixed top padding reservation. When the controls wrapped, especially after the repo/CSV toolbar occupied the row above, the wrapped pills were not counted in layout and overlapped the following metric tile row. Once the pills flowed correctly, the Hive vs human role select was still anchored at the tile's top-right corner directly below those pills, creating a visual collision.

Validation

  • gofmt -w src/pkg/dashboard/pr_throughput_ui_test.go
  • gofmt -l src/pkg/dashboard/pr_throughput_ui_test.go returned no files
  • git diff --check

Per AGENTS.md, local go test is not run for this repository; CI is the test verdict.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2026
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/filter-pills-overlap branch from 9ecc052 to 7abb50d Compare October 5, 2026 17:18
@kubestellar-prow kubestellar-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible β€” a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking β€”
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly β€” that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10614 ✨ dashboard: Audit Log collapsed row shows entry rate, last entry, today's count and sensitive-action chip same files src/pkg/dashboard/static/index.html
#10613 ✨ dashboard: Review Queue collapsed row shows a priority-split history sparkline same files src/pkg/dashboard/static/index.html
#10619 ✨ dashboard: move project actions to toolbar same files src/pkg/dashboard/static/index.html
#10640 πŸ› dashboard: surface alerts section at top of page same files src/pkg/dashboard/static/index.html
#10589 πŸ› fix: route reporter-trust waits through poller relay same files src/pkg/dashboard/static/index.html
#10638 πŸ› dashboard: Overview open-issue/PR totals explain their gap to the forge counts same files src/pkg/dashboard/static/index.html
#10648 πŸ› dashboard: overview under-reports total open issues same files src/pkg/dashboard/static/index.html
#10618 ✨ Improve collapsed Advisory and ACMM headers same files src/pkg/dashboard/static/index.html
#10633 ✨ dashboard: expose Wavefront (Crustify) work source in settings same files src/pkg/dashboard/static/index.html
#10606 ✨ dashboard: upgrade bee animation in the top navbar; sidebar pill no longer clips same files src/pkg/dashboard/static/index.html
#10647 πŸ› dashboard: hide Clear filter / Rescan / Reset layout while Projects is collapsed same files src/pkg/dashboard/static/index.html

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant