Repository navigation
Conversation
84dac7a to
541726c
Compare
|
Thanks for this one. I checked every entry of the G3D tables against Google's One thing has to change before it merges. When you re-push, could you add the boot's The gate and CI pass on today's base, and I built |
CMU_G3D clocks the Tensor G4's Mali GPU: two PLLs (the stacks' and the L2's), user muxes for CMU_TOP's G3D NoC, global and switch clocks, and the GPU's core, coregroup and stacks clocks. Describe it in the common Tensor G4 clock binding with its four inputs, and add CMU_TOP's three G3D branches (mux, gate and divider each) and the SHARED0 and SHARED1 halves and thirds those branches select at the end of the TOP block and the 19 CMU_G3D identifiers in a new block, leaving the existing ones unchanged. Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-node.c Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Register CMU_G3D, the Mali GPU's clock unit, on the common exynos_arm64_register_cmu() path with its bus input, and CMU_TOP's three G3D branches it takes its inputs from. Firmware sets G3D up and keeps its domain on: the two PLLs (PLL0822x, no rate table), the muxes and the dividers are read-only, and the GPU's core, coregroup and stacks gates and the CMU's own gate are read-only gates, as are CMU_TOP's three G3D gates. The STACKS and L2_GLB dividers have no ratio field in the CAL (only busy and auto-gating bits), so they are 1:1 factors. The GPU's rate changes go through the ACPM firmware, not this CMU. Every offset, width and parent list was checked against zuma's cmucal- sfr.c and cmucal-node.c. On the Pixel 9a the integration kernel 7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, whose clk- zumapro.c (blob ae4948e0dd60) has these G3D and CMU_TOP G3D tables, registers the 30 G3D clocks and runs Panthor on the core, coregroup and stacks gates (fout_g3d at 149.9 MHz, gout_g3d_core at 159.7 MHz). CMU_TOP's G3D GLB and SWITCH muxes also select SHARED0 and SHARED1 divided by 2 and 3, which the driver didn't register, so a mux left on one of them would be an orphan reading 0 Hz. Add the four fixed factors (the CAL's PLL_SHARED0_D2 and _D3, PLL_SHARED1_D2 and _D3). On the Pixel 9a the bootloader leaves the GLB mux on SHARED0_D2: mout/gout_g3d_glb read 1065.984 MHz and dout_g3d_glb 532.992 MHz; NOCD and SWITCH are on SHARED2 (798.72 MHz), dout_g3d_nocd 133.12 and dout_g3d_switch 266.24 MHz. Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-sfr.c Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-node.c Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
541726c to
6b6818c
Compare
|
Thanks, you were right, and it does bite on the 9a. The bootloader leaves
One heads-up: my DT PRs (#80, #81, #85, #87) sit on top of this stack. I'm rebasing them onto it now. They name clocks rather than numbers, so nothing in them changes. |
|
Thanks for the quick turnaround, and for checking it on the phone: good to know GLB really sits on SHARED0_D2, so the fix matters on the 9a and isn't just tidiness. I went through the re-pushed stack against the old one, commit by commit. The only changes are the ones we talked about:
The gate passes on today's base, CI is green on all seven, and One small thing came with the re-push, on #77 (details there): the Thanks also for rebasing #80, #81, #85 and #87 onto the stack. Once #79 is merged, its commits get new ids on |
|
Landed through #79, which carried this commit with the rest of the stack. Thanks! |
Rebased onto
omamobilenow that #40 is merged, so only this PR's two commits remain:dt-bindings: clock: google,zumapro: Add CMU_G3Dandclk: samsung: zumapro: Add CMU_G3D.CMU_G3D clocks the Mali GPU. It's built the same way as #40's HSI0:
exynos_arm64_register_cmu()with thebusinput.top_ro_gateslike MISC's and HSI0's. Their ids are 31-39, appended to the TOP block.google,zumapro-cmu-g3dwith four inputs (oscclk,bus,glb,switch), its 19 ids in a new block, and a node in the example. Nopower-domains.I checked every offset, field width and parent list against zuma's
cmucal-sfr.candcmucal-node.c, the same commit as #40. That covers the three TOP mux selects (3 bits each) and parent orders, the TOP divider widths (GLB 4, NOCD 4, SWITCH 3), the PLL CON3 M/P/S fields, the three internal muxes' parents and widths, and the TOP and NOCP dividers (3 bits each).The palmtop runs these tables today, in the integration kernel named in the commit with its
clk-zumapro.cblob. All 30 G3D clocks register, and Panthor runs the desktop on the core, coregroup and stacks gates. The tegucmu_g3dnode comes with the board PR, as for #40.checkpatch --strict is clean on both new commits,
clk-zumapro.obuilds with W=1, anddt_binding_checkpasses for the binding.