Skip to content

thermal: samsung: gs101_acpm_tmu: Add the Tensor G4 - #86

Merged
derekross merged 2 commits into
derekross:omamobilefrom
W4HO-ham:tegu-acpm-tmu
Oct 27, 2026
Merged

derekross merged 2 commits into
derekross:omamobilefrom
W4HO-ham:tegu-acpm-tmu

Conversation

@W4HO-ham

Copy link
Copy Markdown
Contributor

The Tensor G4 (zumapro) reads its SoC temperatures through the same ACPM TMU service as gs101: channel 9, the same sensor order (big, mid, little, GPU, ISP, TPU), plus a seventh sensor, AUR. This adds google,zumapro-acpm-tmu to the binding and to gs101_acpm_tmu, with the sensor count now in the match data.

Tested on the Pixel 9a (7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, this driver as a module, the DT's thermal-sensor moved under acpm_ipc with the new compatible):

  • the firmware accepts the TMU init (0). Our out-of-tree driver never sent it, so I checked that one on its own first: readings carry on as before;
  • the big, mid, little and GPU zones register, with their cpufreq and panthor devfreq cooling maps attached;
  • they read 46-48 C idle.

This replaces our out-of-tree tegu-acpm-thermal on the palmtop. The 9a's thermal zones come in a board DT change.

checkpatch --strict is clean on both commits, and the driver builds with W=1. dt_binding_check for google,gs101-acpm-ipc.yaml reports only "'clocks' is a dependency of 'assigned-clocks'", which the base gives too.

The Tensor G4 (zumapro) reads its SoC temperatures through the same ACPM
TMU service as gs101, with a seventh sensor, AUR, after the six gs101
has. Add google,zumapro-acpm-tmu.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Tensor G4 (zumapro) reads its SoC temperatures through the same ACPM
TMU service on channel 9, with the same sensor order plus a seventh,
AUR. Make the sensor count part of the match data and add
google,zumapro-acpm-tmu with seven sensors.

Tested on the Pixel 9a: the driver binds the thermal-sensor node under
ACPM, the firmware accepts the TMU init, and the big, mid, little and
GPU thermal zones register with their cpufreq and devfreq cooling maps
and read 46-48 C idle.

Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
@derekross

Copy link
Copy Markdown
Owner

Thanks, this is a tidy extension. I checked it against Google's sources: channel 9 is acpm_tmu's acpm-ipc-channel in zumapro.dtsi, and zumapro-a0-ipop.dts numbers the sensors BIG 0, MID 1, LITTLE 2, G3D 3, ISP 4, TPU 5 and AUR 6, which is your order and count.

Since this driver is shared with the Pixel 6 phones, I built gs101_acpm_tmu.o before and after. For gs101 the probe is now a loop bounded by nr_sensors = 6 instead of six unrolled calls, and the allocation grows by one sensor slot. Same registrations, same ids, same skip for sensors without a zone, so nothing changes on raven or oriole. The Pixel 7 phones don't build it. The binding change can't affect existing boards, and their DTBs validate exactly as before.

Two small requests, neither blocking:

  • Please put the kernel release in the commit's "Tested on" line and the blob id of the gs101_acpm_tmu.c you built as the module (git rev-parse <commit>:drivers/thermal/samsung/gs101_acpm_tmu.c), since the body's release is a -dirty integration tree.
  • Optional: an allOf rule pairing google,zumapro-acpm-tmu with google,zumapro-acpm-ipc, the way the binding already pairs the PMICs.

This can land any time and should land before #87, whose DT uses the new compatible.

@derekross
derekross merged commit c380e7f into derekross:omamobile Oct 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants