Repository navigation
Conversation
The Pixel 9a (zumapro, Tensor G4) connects the same Samsung S5300 modem through HSI1 GEN3A_0. Its root complex has no PHY driver and no secure monitor ATU: the host runs the PHY sequences through four more register windows and programs the outbound iATU itself. Add the compatible, the windows, and drop the PHY and the shareability register from what it requires.
The Pixel 9a's modem link is the gs201 link with four differences, from Google's GPL zuma root complex driver and its channel 0 CAL: - no PHY driver: channel 0's PHY power-down clear, configuration and power-down run from tables, with the host's own channel 0 writes around them (SOC_CTRL, PMU PHY control bit 10, UDBG 0xC800, PMA 0x32C, and PCS 0x150 after training); - no secure-ATU SMC: the host writes the unrolled outbound iATU, config space to bus 1 and the first 2 MiB of the memory window; - APP_XFER_PENDING is raised for training and dropped once the link is up, and the port logic is set for two lanes; - the PHY leaves isolation once and stays out, as stock's node has no use-phy-isol-en. The exported calls are unchanged, so cpif drives either link.
|
Thank you, @W4HO-ham, and thanks for stacking this on my modem series rather than proposing a second driver. Reusing the gs201 link for the 9a's S5300 is the direction I want for the whole zuma family. The header comment that ties each table to the CAL function and branch it comes from, including the lane-loop offset that stock never takes back, is exactly the kind of citation that makes code like this reviewable. What I checked: the gate on this branch merged onto today's It's a draft and hasn't booted, so this is early feedback. These are the things I'd want before it's ready:
Smaller things: a missed PLL lock in |
Draft, stacked on #144 (
curated/5-modem). Two commits. They need my sign-off, and a boot on a kernel that has both #144 and the 9a's board DT.What
The Pixel 9a's modem link (HSI1 GEN3A_0, the same S5300) becomes a second compatible of
pcie-gs201-cp.c,google,zumapro-pcie-cp, not a new driver. The 9a's out-of-tree link module started as a copy of this controller and has run the 9a's modem since 10-28.dt-bindings: pci: google,gs201-pcie-cp: Add the zumapro modem link: the compatible and four more register windows (SOC_CTRL, UDBG, PMA, PCS).physandsamsung,sysregare now required only for gs201.PCI: gs201-cp: Add the zumapro (Pixel 9a) modem link. The differences, from Google's GPL zumapcie-exynos-rc.cand its channel 0 CAL:pcie-zumapro-cp-seq.h), with the host's own channel 0 writes around them.APP_XFER_PENDINGis raised for training and dropped once the link is up, and the port logic is set for two lanes.use-phy-isol-en.The exported calls are unchanged, so cpif drives either link. gs201's paths are untouched apart from
cp_phy_off()wrappingphy_power_off().Not in this PR
The 9a's DT nodes (the HSI1 GEN3A_0 node, the modem node, reserved memory). The stack's base has no zumapro board DT yet, so they come once #144 is on
omamobile. Bring-up parameters from the out-of-tree module are left out (L1 substates, cycle trace).Testing
W=1clean in the project container (arm64, LLVM). checkpatch--strictclean apart from the sign-off.