Repository navigation
mfd, regulator: the S2MPG15 sub-PMIC (Pixel 9a) and its LDOs - #101
Conversation
|
Force-pushed before review: the three GNSS rails, LDO9S (core), LDO10S (RF front end) and LDO11S (auxiliary supply), are now in all three commits (binding pattern, pmic regmap range 0x37-0x39, regulator descriptors with Google's voltage groups 5 and 6). They're off at hand-off on the palmtop and stock turns them on; the palmtop has been running with them described since round gn2. Same checks as before: checkpatch --strict, W=1 for s2mps11.o and sec-acpm.o, dt_binding_check. |
d5e7a2a to
916f691
Compare
|
Thank you for this. I checked every value against Google's GPL sources ( The checks pass on today's Small things, since these land commit by commit:
And one thing for the board PR, not this one: a rail the DT describes with neither a consumer nor With the three descriptions fixed, I'll merge it. |
…lies LDO5S and LDO7S feed the AoC's sensors. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The S2MPG15 is the sub-PMIC paired with Google's Tensor G4 (Pixel 9a), reached through ACPM like the S2MPG14. Describe it with its LDOs that Linux consumers use: LDO5S and LDO7S (the AoC sensors), LDO9S-LDO11S (the GNSS core, RF front end and auxiliary supply), LDO12S (the camera sensors' 1.8 V) and LDO15S (the fingerprint sensor's 3.3 V). Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Add the Tensor G4's sub-PMIC on ACPM channel 2, speedy channel 1, with no interrupt line yet. Its common regmap exposes only the revision, read only; its pmic regmap only the LDO controls the regulator driver uses. One cell, the regulators. Register offsets from Google's GPL s2mpg15-register.h. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Add LDO5S and LDO7S (the AoC sensors), LDO9S-LDO11S (the GNSS core, RF front end and auxiliary supply), LDO12S (the camera sensors' 1.8 V) and LDO15S (the fingerprint sensor's 3.3 V) of the Tensor G4's sub-PMIC, with the S2MPG14's ops: enable control and voltage readback, keeping the firmware's voltage. As for the S2MPG14, only those the board describes are registered. On the Pixel 9a LDO15S is off at hand-off, and the fingerprint trusted app reads chip id 0 until it is on; with ldo15s described as always on it reads 3.3 V and the sensor answers. The three GNSS rails are off at hand-off too, and stock turns them on. Voltage groups from Google's GPL s2mpg15-regulator.c. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
916f691 to
2ca6ba3
Compare
|
Sorry this sat. Both points are done, and I rebased onto today's
checkpatch |
|
Thank you, @W4HO-ham, no need to apologise. Both points are done:
Nothing in Checks on this head, merged onto today's Merged with "Rebase and merge". #164 and #165 then pick up this version when they rebase. |
This adds the S2MPG15, the Pixel 9a's sub-PMIC on ACPM, with the seven LDOs Linux consumers use:
The series has three patches:
Offsets and voltage groups come from Google's GPL
s2mpg15-register.hands2mpg15-regulator.c.Tested on the 9a (7.3.0-rc6-omamobile-tegu-s2mpg15-m1) with the integration tree's version of this code, which also carries the S2MPG15 GPIO block (not in this series):
ldo15sdescribed as always on reads enabled at 3.3 V, and the fingerprint HAL then finds the sensor (sensor0 at (540, 1769), radius 113).checkpatch --strict (only the MAINTAINERS notes for new files), the W=1 builds of the four objects, and
dt_binding_checkof both schemas are clean on today'somamobile. The 9a's DT nodes come with the board DT once #80 is in.