Repository navigation
Conversation
|
Thank you for holding this as a draft until the host test, and for pointing out that the PHY defers without the repeater driver. A few things to put into the runbook before it boots, since USB is the 9a's only link. They cover #107 too:
No review from me until it's out of draft. |
3546333 to
abe9db9
Compare
abe9db9 to
e5680f3
Compare
|
A short note while this is a draft, so it doesn't get lost. The last two pushes rebased it under the board commit's new message and #105's cleanup. The repeater commit and #107's two commits are otherwise unchanged, so the points from my earlier comment still apply when it's ready: the unplug/replug test behind a dead-man switch, Two things for the order:
No full review until it's out of draft. |
30e3920 to
6c129ab
Compare
6c129ab to
f885e02
Compare
|
Rebased with no change, noted. My 10-28 points still apply when it comes out of draft, after #107. |
The TUSB2E11 converts between an SoC's eUSB2 signalling and USB 2.0 on one port, as on the Pixel 9a between the zumapro eUSB2 PHY and the Type-C connector. It takes its role from the eUSB2 link, so the binding only describes its supply and the board's signal tuning, one property per tuning register; the register names follow Google's GPL eusb_repeater driver. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Power the repeater, wait the 3 ms it needs before it answers I2C, enable its port and write the board's tuning from the device tree; at exit, disable the port and the supply. The role needs no driver: the repeater follows the eUSB2 link. Registers and timing follow Google's GPL eusb_repeater driver for the Pixel 9a, which writes the same tuning. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The Pixel 9a's USB 2.0 path runs from the eUSB2 PHY through a TI TUSB2E11 repeater at 0x3e on hsi2c9, powered from the S2MPG14's LDO19M (stock: L19M_EUSB2). Describe it with the board's signal tuning from Google's GPL zuma-tegu-usb.dtsi, and give it to the eUSB2 PHY as its repeater. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
f885e02 to
37d69d1
Compare
|
Thank you for the rebase, @W4HO-ham: all three commits are unchanged, the bottom two are the same patches as #107, and the gate and CI (with |
Draft, stacked on #106 (the DT stack) and #107 (the TUSB2E11 binding and driver); only the last commit is new. Like #107, it waits for the USB host test on the palmtop.
The 9a's USB 2.0 path runs from the eUSB2 PHY through a TI TUSB2E11 repeater at 0x3e on hsi2c9, powered from the S2MPG14's LDO19M (stock:
L19M_EUSB2). This adds LDO19M, the repeater node with the board's tuning from Google's GPLzuma-tegu-usb.dtsi, andphys = <&usb_repeater>onusb_hsphy. The Exynos eUSB2 PHY binding already allows a repeater there.Checks: checkpatch --strict clean; on today's
omamobilewith the stack,zumapro-tegu.dtbbuilds andCHECK_DTBSreports nothing.Why it isn't on the palmtop yet: once
usb_hsphyhasphys, the PHY waits for the repeater's driver. A kernel without it would leave USB gadget mode (our only link) waiting at probe, so this goes in together with #107 after the host test.