Repository navigation
fix(models): release stalled Hugging Face searches - #5247
Merged
gabsprogrammer merged 1 commit intoSep 15, 2026
Merged
gabsprogrammer merged 1 commit into
gabsprogrammer merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
A Hugging Face search whose response headers or JSON body stop arriving leaves the Hub at Searching indefinitely. Retry search is disabled by the same loading state, so the user cannot retry the current query.
Give each dispatched search a 30-second deadline covering headers and body consumption. Abort the request, show a timeout message and release the retry action. Clear the deadline on completion, query replacement and unmount. An unsuccessful search no longer simultaneously claims that no repositories were found.
Overlap check
Searched open/closed PRs by Hub search behavior and HuggingFaceModelBrowser.jsx. Merged #4339 prevents an obsolete response body from overwriting a newer query; its controller has no deadline. #3050 cancels repository-details requests, and #4622 validates details metadata. This change bounds the current search request and retains the existing obsolete-response guard.
Validation
Review and risk
Read-only search change. An upstream search taking more than 30 seconds now requires an explicit retry. There is no automatic request replay or change to artifact import/activation. Independent review remains pending.
AI Assistance
Codex reproduced the stalled UI, implemented the deadline and executed the listed checks. Release lane: public-beta.