Skip to content

fix(models): release stalled Hugging Face searches - #5247

Merged
gabsprogrammer merged 1 commit into
Osmantic:public-betafrom
0xacee:fix/models-release-stalled-hub-searches
Sep 15, 2026
Merged

gabsprogrammer merged 1 commit into
Osmantic:public-betafrom
0xacee:fix/models-release-stalled-hub-searches

Conversation

@0xacee

@0xacee 0xacee commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Why this matters

A Hugging Face search whose response headers or JSON body stop arriving leaves the Hub at Searching indefinitely. Retry search is disabled by the same loading state, so the user cannot retry the current query.

Give each dispatched search a 30-second deadline covering headers and body consumption. Abort the request, show a timeout message and release the retry action. Clear the deadline on completion, query replacement and unmount. An unsuccessful search no longer simultaneously claims that no repositories were found.

Overlap check

Searched open/closed PRs by Hub search behavior and HuggingFaceModelBrowser.jsx. Merged #4339 prevents an obsolete response body from overwriting a newer query; its controller has no deadline. #3050 cancels repository-details requests, and #4622 validates details metadata. This change bounds the current search request and retains the existing obsolete-response guard.

Validation

  • Baseline: 3 of 4 new rendered-component cases fail; successful-search control passes.
  • Candidate: all 56 Hub/model-page tests pass, including stalled headers, stalled JSON body, explicit retry, replacement-query timing, stale response handling and successful completion.
  • Production build passes. Changed-file ESLint has zero errors and 18 existing unused-JSX warnings; the new test has no lint diagnostics. git diff --check passes.
  • Transport stalls and time are controlled in browser-component tests. No live Hugging Face outage was required to reproduce the state transition.
  • Existing frontend CI runs these tests and builds on Linux, macOS and Windows.

Review and risk

Read-only search change. An upstream search taking more than 30 seconds now requires an explicit retry. There is no automatic request replay or change to artifact import/activation. Independent review remains pending.

AI Assistance

Codex reproduced the stalled UI, implemented the deadline and executed the listed checks. Release lane: public-beta.

@gabsprogrammer
gabsprogrammer merged commit 11782d1 into Osmantic:public-beta Sep 15, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants